X2Go Bug report logs - #84
DESTDIR and OPTFLAGS patches for nx-libs

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Wed, 12 Dec 2012 12:03:38 UTC

Severity: normal

Forwarded to https://github.com/ArcticaProject/nx-libs/issues/141

Full log


🔗 View this message in rfc822 format

X-Loop: git-admin@x2go.org
Subject: Bug#84: Hardcoded -O3 in CFLAGS
Reply-To: Bernard Cafarelli <voyageur@gentoo.org>, 84@bugs.x2go.org
Resent-From: Bernard Cafarelli <voyageur@gentoo.org>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: git-admin@x2go.org
Resent-Date: Wed, 09 Jan 2013 00:03:01 +0000
Resent-Message-ID: <handler.84.B84.135768961822364@bugs.x2go.org>
Resent-Sender: git-admin@x2go.org
X-X2Go-PR-Message: followup 84
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: pending
Received: via spool by 84-submit@bugs.x2go.org id=B84.135768961822364
          (code B ref 84); Wed, 09 Jan 2013 00:03:01 +0000
Received: (at 84) by bugs.x2go.org; 9 Jan 2013 00:00:18 +0000
Received: from intrepid.cafarelli.fr (intrepid.cafarelli.fr [88.191.154.185])
	by ymir (Postfix) with ESMTP id 63DDC5DB0A
	for <84@bugs.x2go.org>; Wed,  9 Jan 2013 01:00:18 +0100 (CET)
Received: from enterprise.cafarelli.fr (unknown [IPv6:2a01:e35:2439:f290:922b:34ff:fe33:3399])
	by intrepid.cafarelli.fr (Postfix) with ESMTPSA id 582FDE00B4
	for <84@bugs.x2go.org>; Wed,  9 Jan 2013 01:00:14 +0100 (CET)
Date: Wed, 9 Jan 2013 01:00:11 +0100
From: Bernard Cafarelli <voyageur@gentoo.org>
To: 84@bugs.x2go.org
Message-ID: <20130109010011.4f92023b@enterprise.cafarelli.fr>
In-Reply-To: <alpine.LNX.2.01.1301081706500.14229@nerf07.vanv.qr>
References: <ef1f449976cebc4b8ddb052befd9c231@cafarelli.fr>
	<alpine.LNX.2.01.1301081706500.14229@nerf07.vanv.qr>
Organization: Gentoo Foundation, Inc.
X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-pc-linux-gnu)
X-Face: 7~4(Qk<`!us|JEfF`9/56!o9Lag,791'IUv</}aWl2ZPY?fFxeUzqxXWz]]gw.+0R0Q_d[r
 }+t0sse3,4kQO,*R<g"TAS)}NITD@d9=<@Vf+OC/&^6q"SIJ$U]<xN3_FO!9X2*yn4YBK4<p2NS|Xa
 yp):>mH;`8s>5orOs['3K9z-]Z+q\P>g'
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Le Tue, 8 Jan 2013 17:07:12 +0100 (CET)
Jan Engelhardt <jengelh@inai.de> a écrit:
> Why would autoreconf be rerun if you use ./configure CFLAGS=-O2 
> CXXFLAGS=-O2?

I meant, without first removing the "-O3" from configure.in (before
autoreconf)

With current configure.in, setting CXXFLAGS to "-O2" will give this:
nxcomp $ autoreconf && ./configure && make
[...]
g++ -c -O2 -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include
-Wmissing-declarations -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"
-DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -Wall
-Wpointer-arith   EncodeBuffer.cpp

Editing CXXFLAGS to "$CXXFLAGS -fno-rtti -fno-exceptions" will use
user-defined optimization level 2

If hardcoded "-O3" is required, some test could be added to set "-O3"
if CXXFLAGS is unset, then appending the rtti/exceptions flags

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sun Aug 25 05:39:48 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.