X2Go Bug report logs - #566
X2Go Client for Windows cannot create C:\Users\<username>\ssh\known_hosts file when the username has non-English characters

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: <trakatelis@uom.gr>

Date: Mon, 11 Aug 2014 10:55:01 UTC

Severity: grave

Tags: pending

Found in version 4.0.2.1

Fixed in version 4.0.3.0

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#566: [X2Go-Dev] Bug#566: Bug#566: X2Go Client for Windows 4.0.2.1 cannon create C:\Users\<username>\ssh\known_hosts file when the local Windows account username has non-English characters
Reply-To: Michael DePaulo <mikedep333@gmail.com>, 566@bugs.x2go.org
Resent-From: Michael DePaulo <mikedep333@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Sun, 07 Sep 2014 04:45:01 +0000
Resent-Message-ID: <handler.566.B566.14100650689530@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 566
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: 
Received: via spool by 566-submit@bugs.x2go.org id=B566.14100650689530
          (code B ref 566); Sun, 07 Sep 2014 04:45:01 +0000
Received: (at 566) by bugs.x2go.org; 7 Sep 2014 04:44:28 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham version=3.3.2
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 828F95DEA7
	for <566@bugs.x2go.org>; Sun,  7 Sep 2014 06:44:27 +0200 (CEST)
Received: by mail-wi0-f180.google.com with SMTP id ex7so1112874wid.13
        for <566@bugs.x2go.org>; Sat, 06 Sep 2014 21:44:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=KjcmSxSyyIHF0aKcNu8nIEw0OBZczwimAoNhmMpdaMU=;
        b=biVF71DjEzzmmciSE7H5r2YB26NHMlYw3NS3/k0ob5Hw0wzksSoqdcozU5D05tdR9R
         WFLwmC3txxeg8wOc5gqes0ZQn0uEAwGHSdkCu+8zzN8iZ0BeTQGksb6mQ9u0BT9omqy/
         NsAm4MPnNe/cCw9EEC35B0x6SFVjHyk8n7NtEimP6hfbI+sCzkJBIUk4U2Is5pz6snLi
         jA4WQdi07mpO2GV9WFcdS+XM0AYnCjM0ZYJmUjVVTXJGVuj/DWbEKqB8UB/YfAJNQPgk
         NPloNCy9rcP/0JLm5n74TKBwS67QPajPDCYfqpqcZuK9InQL63jT9wsRlAnvF79wFU7A
         AGqQ==
MIME-Version: 1.0
X-Received: by 10.194.185.230 with SMTP id ff6mr27039wjc.120.1410065067092;
 Sat, 06 Sep 2014 21:44:27 -0700 (PDT)
Received: by 10.180.238.66 with HTTP; Sat, 6 Sep 2014 21:44:25 -0700 (PDT)
In-Reply-To: <CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
References: <000001cfb552$3193a8a0$94baf9e0$@gr>
	<handler.566.B.140775428816658.ack@bugs.x2go.org>
	<000001cfc60a$32831de0$978959a0$@gr>
	<20140901195103.Horde.HOAd34FDzvE7MwwNBCtaAg1@mail.das-netzwerkteam.de>
	<CAMKht8gaM7uupVMhTkPR3pg2jcO5sBRHCbYkMV8kCf0EvKK8sg@mail.gmail.com>
Date: Sun, 7 Sep 2014 00:44:25 -0400
Message-ID: <CAMKht8jxisag8A9F3yFBSg3BQ+PODLzrayu90S0G8OaQKZXtfQ@mail.gmail.com>
From: Michael DePaulo <mikedep333@gmail.com>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 566@bugs.x2go.org
Cc: trakatelis@uom.gr, George Trakatelis <trakatelis@uom.edu.gr>
Content-Type: multipart/mixed; boundary=047d7bb0398c6f50e90502725b88

[Message part 1 (text/plain, inline)]
Hi George,

1st, please use either "diff -c" or "git diff" to prepare the patch.
You can even use "git diff" on a files/folders that are outisde of a
git source tree.

2nd, I tried what I think was your patch. I've attached the change I
used, it is outputted with "git diff". I used the x2goclient master
branch (4.0.3.0.)

Unfortunately, it failed to fix the bug. I did not experience any
regressions though.

I tested it on both a Windows XP 32-bit SP3 machine and a Windows 8.1
64-bit machine (with the latest required updates & optional updates
from MS.)

3rd, the username I used was "δοκιμαστικό χρήστη". That is how Google
Translate translated "test user" into Greek. Because it is not easy
for me to type that name into the Windows login prompt, I simply ran
commands like the following to test it:
runas "/user:δοκιμαστικό χρήστη" "c:\x2gobuilds\x2goclient\dist\x2goclient.exe"

-Mike

On Mon, Sep 1, 2014 at 7:23 PM, Michael DePaulo <mikedep333@gmail.com> wrote:
> On Mon, Sep 1, 2014 at 3:51 PM, Mike Gabriel
> <mike.gabriel@das-netzwerkteam.de> wrote:
>> Hi Mike#2,
>>
>> On  Mo 01 Sep 2014 19:28:50 CEST, George Trakatelis wrote:
>>
>>> A suggested patch is to substitute the Qt4 toAscii() function with
>>> toLocal8Bit()
>>> in two specific places of SshMasterConnection::run().
>>> A git diff is as follows:
>>>
>>> $ diff /c/a/sshmasterconnection.cpp /c/b/sshmasterconnection.cpp
>>> 521c521
>>> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
>>> ---
>>>>
>>>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
>>>
>>> 630c630
>>> <     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>> (mainWnd->getHomeDirectory()+"/ssh").toAscii());
>>> ---
>>>>
>>>>     ssh_options_set ( my_ssh_session, SSH_OPTIONS_SSH_DIR,
>>>> (mainWnd->getHomeDirectory()+"/ssh").toLocal8Bit());
>>>
>>>
>>> The change affects only Windows builds and was tested in Windows 8.1 Pro
>>> and Windows 7 Professional.
>>>
>>> G. Trakatelis
>>
>>
>> Can you review these changes and if appropriate commit them to the master
>> branch of x2goclient.git?
>>
>> Thanks!
>> Mike
>>
>> [...]
>
> Sure. I'm busy today, but I'll do so within the next few/several days.
>
> -Mike

[bug566.test.patch (application/octet-stream, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Apr 18 16:16:34 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.