#610 - Add versioning information to nxcomp

X2Go Bug report logs - #610
Add versioning information to nxcomp

Reported by: Nito Martinez <Nito@Qindel.ES>

Date: Sun, 14 Sep 2014 22:40:01 UTC

Severity: normal

Tags: pending

Found in version 3.5.0.27

Fixed in version 2:3.5.0.28

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Received: (at 610) by bugs.x2go.org; 15 Sep 2014 10:50:32 +0000
From Nito@Qindel.ES  Mon Sep 15 12:50:31 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE
	autolearn=ham version=3.3.2
X-Greylist: delayed 438 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Mon, 15 Sep 2014 12:50:31 CEST
Received: from thor.qindel.com (smtp.qindel.com [89.140.90.34])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 77BC05DB54
	for <610@bugs.x2go.org>; Mon, 15 Sep 2014 12:50:31 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by thor.qindel.com (Postfix) with ESMTP id 89FD160211;
	Mon, 15 Sep 2014 12:43:12 +0200 (CEST)
Received: from thor.qindel.com ([127.0.0.1])
	by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id 8kQCxazWqSQX; Mon, 15 Sep 2014 12:43:02 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by thor.qindel.com (Postfix) with ESMTP id 7770760215;
	Mon, 15 Sep 2014 12:43:02 +0200 (CEST)
X-Virus-Scanned: amavisd-new at thor.qindel.com
Received: from thor.qindel.com ([127.0.0.1])
	by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id 5Fo32xGv4Nxl; Mon, 15 Sep 2014 12:43:02 +0200 (CEST)
Received: from [10.1.0.254] (qvd-254.int.qindel.com [172.26.11.254])
	by thor.qindel.com (Postfix) with ESMTPSA id 3A2A660211;
	Mon, 15 Sep 2014 12:43:02 +0200 (CEST)
Message-ID: <5416C2B5.7090507@Qindel.ES>
Date: Mon, 15 Sep 2014 12:43:01 +0200
From: Nito Martinez <Nito@Qindel.ES>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
CC: 610@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#610: Add versioning information to nxcomp
References: <20140915100226.Horde.D6SPBRPnuoLmC3FHixJFeA1@mail.das-netzwerkteam.de>
In-Reply-To: <20140915100226.Horde.D6SPBRPnuoLmC3FHixJFeA1@mail.das-netzwerkteam.de>
Content-Type: multipart/alternative;
 boundary="------------030907070306020504080005"

[Message part 1 (text/plain, inline)]

Not a problem. Thanks for the feedback. :-) Nito On 09/15/14 12:02, Mike Gabriel wrote: > Control: notfound -1 3.5.0-27 > Control: found -1 3.5.0.27 > > Hi Nito, > > On Mo 15 Sep 2014 00:28:51 CEST, Nito Martinez wrote: > >> Package: nx-libs >> Version: 3.5.0-27 >> >> It would be desirable to add some versions to be able to get the >> version of the >> NXComp library. >> These should be defined in NX.h, to be used from other clients, and >> >> Attached is a patch that defines the following functions: >> >> extern const char* NXVersion(); >> extern int NXMajorVersion(); >> extern int NXMinorVersion(); >> extern int NXPatchVersion(); >> >> In the patch assigned the VERSION has been set to 3.5.28, just to >> highlight that >> it would be good to change the VERSION of nxcomp whenever a patch is >> applied >> to the code. >> >> Regards, >> >> Nito > > Thanks for sending in that patch. > > However, the next upstream release of NX redistributed is planned to > be 3.5.0.28. > > The idea starting the NX version with 3.5.0 was to reflect what > "upstream" version we obtained from NoMachine (they use three digits, > NX redistributed uses _four_ digits in the version string). The fourth > part of the version quadruple is the NX/X2Go/QVD redistributed patch > level, so to say. > > If that will not cause any technical issues, can you rewrite that > patch so it handles four digit version strings (major, minor, micro, > X2Go/QVD-patchlevel). > > Please also note that an upstream version like 3.5.0-28 will cause > convention issues with most Linux distributions. In Debian, for > example, the part left of the "-" denotes the upstream version, the > part right of the "-" denotes the package revision inside Debian. So > we should avoid using a dash in the NX-libs upstream version. > > Thanks! > Mike > > >

[Message part 2 (text/html, inline)]

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Apr 18 22:28:11 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

X2Go Bug report logs - #610 Add versioning information to nxcomp

X2Go Bug report logs - #610
Add versioning information to nxcomp