X2Go Bug report logs - #205
Patch for fix cairo issue

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#205 closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
 (Patch not accepted)
Message-ID: <handler.205.b205.1402914496448.notifdone@bugs.x2go.org>
References: <20140616102807.Horde.ooIsnKngnR3zTMD6oHKgAg1@mail.das-netzwerkteam.de>
X-X2go-PR-Keywords: patch wontfix
X-X2go-PR-Message: they-closed 205
X-X2go-PR-Package: nx-libs
Date: Mon, 16 Jun 2014 10:30:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1402914602-529-0"

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your Bug report
which was filed against the nx-libs package:

#205: Patch for fix cairo issue

It has been closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <mike.gabriel@das-netzwerkteam.de> by
replying to this email.


-- 
205: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=205
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 205@bugs.x2go.org

Cc: 205-submitter@bugs.x2go.org

Subject: Patch not accepted

Date: Mon, 16 Jun 2014 10:28:07 +0000

[Message part 3 (text/plain, inline)]

Control: tag -1 wontfix
Control: close -1

Dear Nicolas,

about a year ago you proposed a patch for NX/X2Go. Thanks for  
contributing to X2Go.

However, I want to inform you that the patch got rejected. We won't  
tweak the X11 version string presented by NX as that is definitely the  
wrong approach to go at this place.

We are rather working on people/developers becoming aware of X2Go and  
adapting their code so that it does not crash on NX.

Greets,
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas DEFFAYET <nicolas@deffayet.com>

To: submit@bugs.x2go.org

Subject: Patch for fix cairo issue

Date: Fri, 10 May 2013 23:07:59 +0200

Package: nx-libs 
Version: 3.5.0.20-0

As cairo enable buggy_repeat (src/cairo-xlib-display.c) for XFree86 <= 40500000; X.Org >= 60700000 & < 70000000; X.Org < 10400000, it's required to have version 70100000 shown to cairo.

On Debian Wheezy, with original cairo, this will result of no fount displayed as show on https://bbs.archlinux.org/viewtopic.php?id=141884.

The problem is already know: https://bugs.freedesktop.org/show_bug.cgi?id=32014

Ubuntu ***seem*** (require more investigation) to have patched their cairo but not Debian.

Patching nx-X11 for show fake version to cairo is for me the best solution as there is no dependance of a patched cairo.

Suggested patch (need more test):

$ vi debian/patches/999_nx-X11_version_hack_for_cairo.patch
---
Description: Version hack for cairo
 As cairo enable buggy_repeat (src/cairo-xlib-display.c) for XFree86 <= 40500000; X.Org >= 60700000 & < 70000000; X.Org < 10400000, it's required to have version 70100000 shown to cairo.
 https://bugs.freedesktop.org/show_bug.cgi?id=32014.
--- a/nx-X11/config/cf/X11.tmpl	2013-03-28 20:36:38.000000000 +0000
+++ b/nx-X11/config/cf/X11.tmpl	2013-05-10 18:20:18.000000000 +0000
@@ -45,7 +45,7 @@
 # if defined XorgVersionString
 #   define XOrgReleaseString	Release XorgVersionString
 # else
-#   define XOrgReleaseString	Release 6.9
+#   define XOrgReleaseString	Release 7.1
 # endif
 #endif
 
--- a/nx-X11/config/util/makedef.cmd	2013-03-28 20:36:38.000000000 +0000
+++ b/nx-X11/config/util/makedef.cmd	2013-05-10 18:41:40.000000000 +0000
@@ -23,13 +23,13 @@
 sASDFeatureId   = '';
 sCountryCode    = '';
 sDateTime       = left(' 'date()' 'time(), 26);
-sDescription    = 'X.Org 6.9';
+sDescription    = 'X.Org 7.1';
 sFixPakVer      = '';
 sHostname       = strip(substr(VALUE('HOSTNAME',,'OS2ENVIRONMENT'), 1, 11));
 sLanguageCode   = '';
 sMiniVer        = '';
 sVendor         = 'X.Org';
-sVersion        = '6.9';
+sVersion        = '7.1';
 

 /*
---
$ echo "999_nx-X11_version_hack_for_cairo.patch" >> debian/patches/series


Thanks

-- 
Nicolas DEFFAYET

Send a report that this bug log contains spam.