X2Go Bug report logs - #923
.xsession-x2go-errors improvements

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#923: [X2Go-Dev] .xsession-x2go-errors improvements
Reply-To: Orion Poplawski <orion@cora.nwra.com>, 923@bugs.x2go.org
Resent-From: Orion Poplawski <orion@cora.nwra.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 24 Aug 2015 15:25:01 +0000
Resent-Message-ID: <handler.923.B923.144042975918018@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 923
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 923-submit@bugs.x2go.org id=B923.144042975918018
          (code B ref 923); Mon, 24 Aug 2015 15:25:01 +0000
Received: (at 923) by bugs.x2go.org; 24 Aug 2015 15:22:39 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
X-Greylist: delayed 362 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Mon, 24 Aug 2015 17:22:35 CEST
Received: from mail.nwra.com (mail.nwra.com [72.52.192.72])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A160A3BC49
	for <923@bugs.x2go.org>; Mon, 24 Aug 2015 17:22:35 +0200 (CEST)
Received: from [10.10.20.7] (NORTHWEST-R.edge3.Denver1.Level3.net [4.28.99.98])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.nwra.com (Postfix) with ESMTPSA id 264743403B7;
	Mon, 24 Aug 2015 08:16:30 -0700 (PDT)
To: Mihai Moldovan <ionic@ionic.de>, 923@bugs.x2go.org
References: <55D3533C.2090101@cora.nwra.com> <55D9ED21.2060706@ionic.de>
From: Orion Poplawski <orion@cora.nwra.com>
Message-ID: <55DB354D.6090000@cora.nwra.com>
Date: Mon, 24 Aug 2015 09:16:29 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <55D9ED21.2060706@ionic.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 08/23/2015 09:56 AM, Mihai Moldovan wrote:
> On 18.08.2015 05:46 PM, Orion Poplawski wrote:
>> Package: x2goserver
>> Version: 4.0.1.19
>>
>> First issue is that ~/.xsession-x2go-errors is always appended to so it grows
>> forever.  It should at least get rotated to .old file.
> 
> I'm not sure that's an issue per se. Isn't that normal behavior for DEs/Login
> Managers?
> 
> It's inconvenient, but I remember other software doing exactly the same thing,
> so it's at least "consistent". But maybe I'm wrong. I see ~/.xsession-errors and
> ~/.xsession-errors.old on my system using LightDM. So you're probably right. But
> that's for LightDM, not sure how other LMs or systems without a LM handle this?

On Fedora, /etc/X11/xinit/Xsession does:

    errfile="$HOME/.xsession-errors"
    if ( umask 077 && cp /dev/null "$errfile" 2> /dev/null ); then
        chmod 600 "$errfile"
        [ -x /sbin/restorecon ] && /sbin/restorecon $errfile
        exec > "$errfile" 2>&1

So it overwrites it without backup.  I would prefer a backup.  Perhaps I'll
file a bug...

> 
>> Second is with shared NFS home directories, multiple X2Go sessions get logged
>> to the same file which is confusing.  I would suggest putting the host name
>> into the log file name.
> 
> Okay, but that will break for systems with misconfigured/unset hostnames or
> environments where every system has the same hostname. Additionally, multiple
> sessions also get logged to the same file, so merely going for one file per host
> name feels half-baked.

I'm happy to have a suggestion for another key.  My one worry would be to not
use a key that is completely unique so we end up with a proliferation of
xsession error files like we already have with x2go session dirs.


-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Send a report that this bug log contains spam.