X2Go Bug report logs - #1315
loadchecker bad auto sleep time leads to faulty service

Full log

Message #12 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 13 Sep 2018 13:50:50 +0000
From x2go@ymir.das-netzwerkteam.de  Thu Sep 13 15:50:32 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 852CD5DAEE; Thu, 13 Sep 2018 15:50:32 +0200 (CEST)
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1315-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1315@bugs.x2go.org
Subject: X2Go issue (in src:x2gobroker) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20180913135032.852CD5DAEE@ymir.das-netzwerkteam.de>
Date: Thu, 13 Sep 2018 15:50:32 +0200 (CEST)

tag #1315 pending
fixed #1315 0.0.4.0
thanks

Hello,

X2Go issue #1315 (src:x2gobroker) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=533a37b

The issue will most likely be fixed in src:x2gobroker (0.0.4.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 533a37bc1650b1caf48e03a101df18e2c89b6f79
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Thu Sep 13 15:49:44 2018 +0200

    x2gobroker/loadchecker.py: Avoid rare cases where at the end of a load checking cycle a negative sleep time would have been calculated. (Fixes: #1315). Thanks to Walid Moghrabi for catching this.

diff --git a/debian/changelog b/debian/changelog
index cbe2446..6c8f0df 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -80,6 +80,9 @@ x2gobroker (0.0.4.0-0x2go1) UNRELEASED; urgency=medium
     - x2gobroker/loadchecker.py: Don't re-read the x2gobroker.conf during
       each cycle of the load checking loop. Rather read it on service startup
       and require a service restart when x2gobroker.conf has been changed.
+    - x2gobroker/loadchecker.py: Avoid rare cases where at the end of a load
+      checking cycle a negative sleep time would have been calculated.
+      (Fixes: #1315). Thanks to Walid Moghrabi for catching this.
   * debian/*:
     + Trigger Makefile's install target and install those files. Drop debhelper
       from-source-installation magic.

Send a report that this bug log contains spam.