From unknown Fri Mar 29 13:16:17 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1056 closed by X2Go Release Manager (X2Go issue (in src:x2gobroker) has been marked as closed) Message-ID: References: <20161201212459.BCF565DBE7@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending patch stable X-X2go-PR-Message: they-closed 1056 X-X2go-PR-Package: x2gobroker-authservice X-X2go-PR-Source: x2gobroker Date: Thu, 01 Dec 2016 21:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1480627802-23000-0" This is a multi-part message in MIME format... ------------=_1480627802-23000-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2gobroker-authservice package: #1056: H264 videos working badly It has been closed by X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager <= git-admin@x2go.org> by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1480627802-23000-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 1 Dec 2016 21:25:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 00A945DBE9; Thu, 1 Dec 2016 22:25:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M2tTrw9vOtjU; Thu, 1 Dec 2016 22:24:59 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id BCF565DBE7; Thu, 1 Dec 2016 22:24:59 +0100 (CET) From: X2Go Release Manager To: 1056-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1056@bugs.x2go.org Subject: X2Go issue (in src:x2gobroker) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20161201212459.BCF565DBE7@ymir.das-netzwerkteam.de> Date: Thu, 1 Dec 2016 22:24:59 +0100 (CET) close #1056 thanks Hello, we are very hopeful that X2Go issue #1056 reported by you has been resolved in the new release (0.0.3.1) of the X2Go source project »src:x2gobroker«. You can view the complete changelog entry of src:x2gobroker (0.0.3.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2gobroker. http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=c6cbbc1e29d858eca271c5475013bcc852fabc8b;hp=5ecedcafe711c6d28a9a8441dbbec3dcb5fa7587 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2gobroker. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2gobroker Version: 0.0.3.1-0x2go1 Status: RELEASE Date: Thu, 01 Dec 2016 22:19:47 +0100 Fixes: 1056 Changes: x2gobroker (0.0.3.1-0x2go1) RELEASED; urgency=low . [ Mike Gabriel ] * debian/python-x2gobroker.preinst: + Use proper comment header explaining about preinst script argument calls (not postinst). * x2gobroker/brokers/base_brokers.py: Remove Perl code in comment that confuses the Epydoc tool. * API Documentation: Sanitize __doc__ strings to make Epydoc happy. Provide Makefile.docupload and provide html API documentation at http://code.x2go.org/doc/python-x2gobroker/ . [ Mihai Moldovan ] * New upstream version (0.0.3.1): - sbin/x2gobroker-authservice: refactor pam.pam section a bit. Always initialize opam with pam and only rewrite it with pam.pam if necessary. - x2gobroker/authmechs/pam_authmech.py: port pam.pam change to this file as well. * debian/control: - Maintainer change in package: X2Go Developers . - Uploaders: add myself. Also, force a rebuild due to the changed versioning. * x2goserver.spec: - Add mandatory perl-generators Build-Requires as per https://fedoraproject.org/wiki/Changes/Build_Root_Without_Perl . [ Walid Moghrabi ] * New upstream version (0.0.3.1): - sbin/x2gobroker-authservice: adapt script to correctly use the newer python-pam module, which now exposes functionality in pam.pam with backwards compatibility. Fixes: #1056. ------------=_1480627802-23000-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 8 Jul 2016 13:22:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id CE9425DDF5 for ; Fri, 8 Jul 2016 15:22:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OCpNZO-2wEWV for ; Fri, 8 Jul 2016 15:22:33 +0200 (CEST) Received: from zm-01.servicemagic.eu (zm-01.servicemagic.eu [176.31.236.17]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 6FA6D5DDD0 for ; Fri, 8 Jul 2016 15:22:33 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by zm-01.servicemagic.eu (Postfix) with ESMTP id 19C8580A62B45 for ; Fri, 8 Jul 2016 15:22:33 +0200 (CEST) X-Amavis-Modified: Mail body modified (using disclaimer) - zm-01.servicemagic.eu X-Virus-Scanned: amavisd-new at servicemagic.eu Received: from zm-01.servicemagic.eu ([127.0.0.1]) by localhost (zm-01.servicemagic.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MN9H5Zzici-I for ; Fri, 8 Jul 2016 15:22:32 +0200 (CEST) Received: from zm-01.servicemagic.eu (localhost.localdomain [127.0.0.1]) by zm-01.servicemagic.eu (Postfix) with ESMTP id 894DB8096AFD2 for ; Fri, 8 Jul 2016 15:22:32 +0200 (CEST) Date: Fri, 8 Jul 2016 15:22:32 +0200 (CEST) From: Walid MOGHRABI To: submit@bugs.x2go.org Message-ID: <436836937.2940303.1467984152461.JavaMail.root@servicemagic.eu> In-Reply-To: <1004595168.2695050.1467900651738.JavaMail.root@servicemagic.eu> Subject: H264 videos working badly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.33.100.18] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC51 (Linux)/7.2.0_GA_2669) Package: x2gobroker-authservice Version: 0.0.3.0 Severity: grave Tags: stable,patch For days I was struggling with x2gobroker-authservice not working when authenticating against PAM. I eventualy discovered it was the pam class instanciation in /usr/sbin/x2gobroker-authservice that was not working with the following error : error: uncaptured python exception, closing channel <__main__.AuthClient connected '' at 0x7f0aa5c11f80> (:'module' object has no attribute 'authenticate' [/usr/lib/python2.7/asyncore.py|read|83] [/usr/lib/python2.7/asyncore.py|handle_read_event|449] [/usr/sbin/x2gobroker-authservice|handle_read|81]) It seems the pam.py module has probably been refaktored in this Ubuntu making the authservice failing. Here is a patch for the fix : ----------------------------------------------------------------------------------------- --- /usr/sbin/x2gobroker-authservice.dist 2016-07-08 15:07:40.387403000 +0200 +++ /usr/sbin/x2gobroker-authservice 2016-07-08 15:07:00.219403000 +0200 @@ -78,7 +78,11 @@ self.send('bad\n') self.logger.warning('bad authentication data received') else: - if pam.authenticate(user, passwd, service): + if pam.pam: + opam = pam.pam() + else: + opam = pam + if opam.authenticate(user, passwd, service): self.send('ok\n') self.logger.info('successful authentication for \'{user}\' with password \'\' against PAM service \'{service}\''.format(user=user, service=service)) else: ----------------------------------------------------------------------------------------- Test conditions : =============== * Ubuntu Server 16.04 LTS up to date (2016-07-08) * python-pampy : 1.8.2 * x2gobroker-authservice : 0.0.3.0 (from x2go/stable ppa) Best regards, Walid Moghrabi --- DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you ------------=_1480627802-23000-0--