From unknown Fri Mar 29 13:55:14 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#411 closed by Mike Gabriel (X2Go issue (in src:nx-libs) has been marked as closed) Message-ID: References: <20140506160737.1F9263D162@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending patch X-X2go-PR-Message: they-closed 411 X-X2go-PR-Package: nx-libs Date: Tue, 06 May 2014 16:10:08 +0000 Content-Type: multipart/mixed; boundary="----------=_1399392608-21522-0" This is a multi-part message in MIME format... ------------=_1399392608-21522-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the nx-libs package: #411: Fix ppc64 build It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1399392608-21522-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 6 May 2014 16:08:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 1F9263D162; Tue, 6 May 2014 18:07:36 +0200 (CEST) From: Mike Gabriel To: 411-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 411@bugs.x2go.org Subject: X2Go issue (in src:nx-libs) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20140506160737.1F9263D162@ymir.das-netzwerkteam.de> Date: Tue, 6 May 2014 18:07:37 +0200 (CEST) close #411 thanks Hello, we are very hopeful that X2Go issue #411 reported by you has been resolved in the new release (2:3.5.0.23) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.23) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=fdeaafb5e2f4520857ca4757261df79d233e05cb;hp=626b5dbae6b7b432d573f88abc8e3e8ae2bdba85 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.23-0x2go1 Status: RELEASE Date: Tue, 06 May 2014 18:05:47 +0200 Fixes: 393 411 412 423 Changes: nx-libs (2:3.5.0.23-0x2go1) RELEASED; urgency=low . [ Orion Poplawski ] * Add patch: 054_nx-X11_ppc64-ftbfs.full.patch. Fix FTBFS on ppc64 architecture. (Fixes: #411). * Add patch: 055_nx-X11_imake-Werror-format-security.full.patch. Fix FTBFS of imake on current Fedora rawhide (21) which uses the compiler option -Werror=format-security for all builds. (Fixes: #412). * Add patch: 056_nx-X11-Werror-format-security.patch. Fix more -Werror=format-security errors that only show up on ARM builds. (Fixes: #423). * nx-libs.spec: - Sync nx-libs.spec in Fedora with upstream's nx-libs.spec file. (Fixes: #393). . [ Mike Gabriel ] * debian/control: + Build our imake against x11proto-core-dev headers. * nx-libs.spec: + Build our imake against xorg-x11-proto-devel. . [ Oleksandr Shneyder ] * Add patch: 205_nxagent_refresh-adsl.full.patch. Fix refresh error on RDP connections to Windows 2012 if speed=ADSL. ------------=_1399392608-21522-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 24 Jan 2014 19:10:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165]) by ymir (Postfix) with ESMTPS id 30D045DA79 for ; Fri, 24 Jan 2014 20:10:20 +0100 (CET) Received: from [10.10.20.7] (barry.cora.nwra.com [10.10.20.7]) (authenticated bits=0) by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id s0OJAHXB016623 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Fri, 24 Jan 2014 12:10:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com; s=default; t=1390590618; bh=WkJhmJ/wZaiDD8HERwgZ9x24x/kBqLcsVA9Q6RHr4YY=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=pa6TQUOgD6rT7LwSksDqWR+xbBoaflbddBZuCJqjIP/w+BRGdV7KMN2PVNkU81+wg ShEIsZ9E6e9yHMXGRReKYEPd+3wluWRtkB6WAzewSwJDxTfH7vngXmLpgsxOkiq5xv T6z4dvSYIcfpSLMpp4qrdcYOxJeLi22bYFSeSJVw= Message-ID: <52E2BA99.6050500@cora.nwra.com> Date: Fri, 24 Jan 2014 12:10:17 -0700 From: Orion Poplawski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Fix ppc64 build X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------080600080706020709080500" This is a multi-part message in MIME format. --------------080600080706020709080500 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Package: nx-libs Version: 3.5.0.22 Tags: patch Apparently gcc on EL7 pcc64 defines a macro named "pixel". This breaks imake: make[7]: Entering directory `/builddir/build/BUILD/nx-libs-3.5.0.22/nx-X11/programs/Xserver/GL/mesa' making Makefiles in programs/Xserver/GL/mesa/main... make[8]: Entering directory `/builddir/build/BUILD/nx-libs-3.5.0.22/nx-X11/programs/Xserver/GL/mesa' In file included from ../../../../../config/cf/Imake.tmpl:2158:0, from Imakefile.c:36: ../../../../../config/cf/X11.tmpl:1704:0: warning: "UseInstalledOnCrossCompile" is not defined [-Wundef] # elif UseInstalledOnCrossCompile ^ In file included from ./Imakefile:25:0, from ../../../../../config/cf/Imake.tmpl:2194, from Imakefile.c:36: ./../../../../../lib/GL/mesa/main/Imakefile.inc:59:0: error: detected recursion whilst expanding macro "pixel" $(MESABUILDDIR)pixel.c \ ^ ./../../../../../lib/GL/mesa/main/Imakefile.inc:168:0: error: detected recursion whilst expanding macro "pixel" LinkSourceFile(pixel.c, $(MESASRCDIR)/src/mesa/main) ^ ./../../../../../lib/GL/mesa/main/Imakefile.inc:168:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:168:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:168:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:168:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:169:0: error: detected recursion whilst expanding macro "pixel" LinkSourceFile(pixel.h, $(MESASRCDIR)/src/mesa/main) ^ ./../../../../../lib/GL/mesa/main/Imakefile.inc:169:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:169:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:169:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:169:0: error: detected recursion whilst expanding macro "pixel" ./../../../../../lib/GL/mesa/main/Imakefile.inc:258:0: error: detected recursion whilst expanding macro "pixel" $(MESABUILDDIR)pixel.o \ ^ ./../../../../../lib/GL/mesa/main/Imakefile.inc:398:0: error: detected recursion whilst expanding macro "pixel" $(MESABUILDDIR)debugger/pixel.o \ ^ ./../../../../../lib/GL/mesa/main/Imakefile.inc:466:0: error: detected recursion whilst expanding macro "pixel" $(MESABUILDDIR)profiled/pixel.o \ ^ make[8]: Leaving directory `/builddir/build/BUILD/nx-libs-3.5.0.22/nx-X11/programs/Xserver/GL/mesa' make[7]: Leaving directory `/builddir/build/BUILD/nx-libs-3.5.0.22/nx-X11/programs/Xserver/GL/mesa' ../../../../../config/imake/imake: Exit code 1. Stop. make[8]: *** [main/Makefile] Error 1 The attached patch fixes. There might be a better place to undefine the macro, but this works. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 http://www.nwra.com --------------080600080706020709080500 Content-Type: text/x-patch; name="nx-libs-ppc64.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nx-libs-ppc64.patch" diff -up nx-libs-3.5.0.22/nx-X11/lib/GL/mesa/main/Imakefile.inc.ppc64 nx-libs-3.5.0.22/nx-X11/lib/GL/mesa/main/Imakefile.inc --- nx-libs-3.5.0.22/nx-X11/lib/GL/mesa/main/Imakefile.inc.ppc64 2014-01-04 13:39:35.000000000 -0700 +++ nx-libs-3.5.0.22/nx-X11/lib/GL/mesa/main/Imakefile.inc 2014-01-24 12:04:00.085272615 -0700 @@ -1,5 +1,8 @@ XCOMM $XFree86: xc/lib/GL/mesa/src/Imakefile.inc,v 1.7tsi Exp $ +/* gcc on ppc64 defines this, causes macro recursion with pixel below */ +#undef pixel + #ifndef MesaBuildDir #define MesaBuildDir $(GLXLIBSRC)/mesa/main/ #endif --------------080600080706020709080500-- ------------=_1399392608-21522-0--