From mike.gabriel@das-netzwerkteam.de Wed Nov 27 11:46:28 2013 Received: (at 349) by bugs.x2go.org; 27 Nov 2013 10:46:28 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 076CE5DA6C for <349@bugs.x2go.org>; Wed, 27 Nov 2013 11:46:28 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 54FD41ECA6; Wed, 27 Nov 2013 11:46:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 31AAB3C1E1; Wed, 27 Nov 2013 11:46:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xfxNIz4+Q1ao; Wed, 27 Nov 2013 11:46:27 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPSA id 093A63C0A7; Wed, 27 Nov 2013 11:46:27 +0100 (CET) Received: from m-047.informatik.uni-kiel.de (m-047.informatik.uni-kiel.de [134.245.254.47]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 27 Nov 2013 10:46:26 +0000 Date: Wed, 27 Nov 2013 10:46:26 +0000 Message-ID: <20131127104626.Horde.w5hvLxXG3VoCZDC6svrcQA2@mail.das-netzwerkteam.de> From: Mike Gabriel To: marcoandredinis@gmail.com, 349@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#349: Make shadow sessions work with --hide option References: <14138471.B8Tpv8tqIx@mcdtux> In-Reply-To: <14138471.B8Tpv8tqIx@mcdtux> User-Agent: Internet Messaging Program (IMP) H5 (6.1.4) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.47 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 Iceweasel/23.0 Content-Type: multipart/signed; boundary="=_19SwLkyEJh3m2L532mm2sg8"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_19SwLkyEJh3m2L532mm2sg8 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Control: retitle -1 Make shadow sessions work with --hide option Control: tag -1 moreinfo Control: clone -1 -2 Control: reassign -2 x2godesktopsharing Control: retitle -2 Add --no-icon cmdline option to x2godesktopsharing Control: severity -2 wishlist Hi Marco, with this mail I split up your report into to separate bug reports. One for x2goclient, one for x2godesktopsharing... On Di 26 Nov 2013 17:01:41 CET, marcoandredinis wrote: > I'm developing a program that will use X2Go software. I dont want > users to notice they are using any other program besides my own. > > I have two problems right now: > > A) X2GoClient > Using SHADOW mode with "--hide" does not work. The interface waits for > selection of Display (usually ":0") and, since there's no input from > user (there's no window) the program does not show anything. > There are possible ways of fixing/improving this situation: > -allow user to set the default display on sessions' file > -create one flag and run program like these: "x2goclient --hide > --sessionid=xxx --select-first-display" > > Anyway, i modified the code of x2goclient/onmainwindow.cpp and added > these lines: > l4348:..if( shadowSession ) > l4349:....slotShadowSess(); > Compiled the program, and now i can run "./x2goclient --hide > --sessionid=xxx" and the window will show up. > This is NOT a fix, this is a nasty workaround. It wontn show the list > even when the "hide" flag is not present. Please provide a patch for what you did. Please improve your patch so it is not a workaround anymore. I guess, I agree with you, that the X2Go Client window should pop up, if there are more than one sharable desktops to select from. If there is only one sharable desktop, this should be auto-selected. Can you code that into X2Go Client, please? > B) X2GoDesktopSharing > Just the icon on SystemTray. If we could pass a flag like "--no-icon" > would be great This part will be handled in a separate bug. I will reply to this once the separate bug is created in X2Go BTS. > I could do these simple changes on my own, but i rather see this > changes on the official code. Let's try to get your needs into upstream code... Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb --=_19SwLkyEJh3m2L532mm2sg8 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAABAgAGBQJSlc2CAAoJEJr0azAldxsxD7sP/2aDSfKgSkU5WflhRCDesPBg RyGG467TQiq81Ti43Sp5hpK9O7AtPo1UGHA1Pb7JNnkcB+2rsvFwA7BsiGbj5WfA MYlMszzXOxq18fAzsEioX0xD2/9JWBc4nAVUSCe0sZelzsUzNddQY3i1vGmtpPpg IxxhjKarmmrQ81FhPkP1rgI3khGIoaVcNkZfuFN84Cv5rTRuBYfUpychtQ2DNnqW HBEDYH5WCG9QwKZzO6xhj0jMMRw1D47VUXW3qNzCMpBJpm6EYBNZv4ME5oGxaV2S qSzouisXd4DW74nQNAKkKmuM4vCHIDRbBaDp66PB3K+MN0YtGFDS/TXtm3tiMvbq xNszv0uytvA5o+VOTceidAKezmF/7BnObWXDoICybQpS3b8UOIkUduCbo6tfgtgX viT55vtCzij29pcbcIP8D9DQdvhj5ly1arVmdjLZ/7lg3MnwPKQheM38q2ubQRsX mdBok4Ou30PpLCVft0WB+aXb8RSy6n+KTpLMhYXB4fUEM0ocid6nH8Erb8w2sJtd CwIWqz8oFmqWAUqa7VHqw73Tl/4GBsnQga9SprBxHQyoHTZqdqvW5FMnoIBrq6tj 1EyYQmpMSzJmQA4jrLWj9j080OGE/Tz9UBBbmc1kWHmwO6Q9qcs0tVmf3MQTpYXm SkAO0yC0oevXTopPbhrA =wWQb -----END PGP SIGNATURE----- --=_19SwLkyEJh3m2L532mm2sg8--