From mike.gabriel@das-netzwerkteam.de Tue May 15 14:19:24 2018 Received: (at 1296) by bugs.x2go.org; 15 May 2018 12:19:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 9C70A5DAE9 for <1296@bugs.x2go.org>; Tue, 15 May 2018 14:19:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 95yMUPZzMz_Y for <1296@bugs.x2go.org>; Tue, 15 May 2018 14:19:17 +0200 (CEST) Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 690275DACE for <1296@bugs.x2go.org>; Tue, 15 May 2018 14:19:17 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 5313760532; Tue, 15 May 2018 12:19:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 49AE6C47EC; Tue, 15 May 2018 14:19:17 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id haZqVHVUvfcI; Tue, 15 May 2018 14:19:11 +0200 (CEST) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id B21CDC47EA; Tue, 15 May 2018 14:19:11 +0200 (CEST) Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Tue, 15 May 2018 12:19:11 +0000 Date: Tue, 15 May 2018 12:19:11 +0000 Message-ID: <20180515121911.Horde.vRMMP4iN7ROEhOjVl9eVz5e@mail.das-netzwerkteam.de> From: Mike Gabriel To: Walid MOGHRABI , 1296@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#1296: x2gobroker-ssh : wrong password after password change in interactive mode References: <1192975666.29026000.1525876455368.JavaMail.root@servicemagic.eu> <444301251.29030144.1525877413102.JavaMail.root@servicemagic.eu> In-Reply-To: <444301251.29030144.1525877413102.JavaMail.root@servicemagic.eu> User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 178.62.101.154 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Content-Type: multipart/signed; boundary="=_At4tGq8kVxdxX5q9cGMGnis"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_At4tGq8kVxdxX5q9cGMGnis Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tags -1 patch Hi Walid, On Mi 09 Mai 2018 16:50:13 CEST, Walid MOGHRABI wrote: > package: x2gobroker-ssh > version: 0.0.4.0-0~1022~ubuntu16.04.1 > priority: bug > > > x2gobroker-ssh supports interactive mode which means that it can=20=20 >=20reports login interactions to the user such as password changes=20=20 >=20requests. > Let's say that my user's password has expired, when I login to the=20=20 >=20broker with x2goclient in broker mode, I'll see a new form asking=20=20 >=20for my old password and I must type/confirm my new password. > Once done, I'll be granted access to the broker and I'll get my=20=20 >=20session profiles list on the right sidebar of the client. > Since I'm using --use-broker-pass, I don't have to re-type my=20=20 >=20password when connecting to a session but in that specific use case,=20= =20 >=20I get an auth error while connecting because of wrong password. > > In fact, it appears that the client keeps the first password that=20=20 >=20has been entered at the broker login prompt (the one that expired)=20= =20 >=20when passing it to the session profile. > Once you get the auth error, you'll be prompted with user/pass for=20=20 >=20the session profile, if you enter the new password, then it works. Can you please test, if the below patch fixes your issue? ``` diff --git a/src/onmainwindow.cpp b/src/onmainwindow.cpp index eca9451..5ab1dc4 100644 --- a/src/onmainwindow.cpp +++ b/src/onmainwindow.cpp @@ -1142,6 +1142,7 @@ void ONMainWindow::slotChangeBrokerPass() return; } broker->changePassword(passDlg.newPass()); + config.brokerPass =3D passDlg.newPass(); setStatStatus ( tr ( "Connecting to broker" ) ); stInfo->insertPlainText ( "broker url: "+config.brokerurl ); setEnabled ( false ); ``` Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_At4tGq8kVxdxX5q9cGMGnis Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAlr60D8ACgkQmvRrMCV3 GzEhfhAAt841LZgGk60lSSsNouHti3zBmN2KIwOgFkue9n/SGSZFjWIVq29Oyzdq xxXqQZCLzzM9iQt2QyP3hQ+DwR0mZfhbgcUMDKkyAsLoWSFFN3pRdim/MYWN7O6N e3L6L8eBr7D7GRPrT0VnsdbLF9tqgW2wYq4kTDqfLmxUkqkViNG0ZrXJ6li/5ut0 Fpvgj9uOGIiG3UrYw00tnUn5FuXbEGD8iAqo7q+yNVmPUec07I6qyK+Vx8gcRgzb LVYqL3X8P5fiO99YuS3PzEleiJ3/YK6VkbKg5CeNxHBEE35BxT/N5OmDa5gAMoGm 2r0KC/8IQx6lTEcDF4OGRvAXeHbn+tXHW9SOh34gTcPWEnpUJ4AeV4BrdFS72gmy ZOAg5aAl9ngS9z915AgjuxCmh8R8bYwTNHEVhMJv+1Z2wKY8Tltvcxpxq45vN3HP mEaE+6sThVozvNQtsmWYSYuGrgEDnjJjuVRBvBrOq8ceCJwTGGdaHSzWjdHYXNjA JFS46/IwdCi6Nlhrko+MblJjkPy+7W2SXqxFOhVIc0jn+YJwTRRK/h/3/2sU6lta LwgDfBbJgj6sYlPfFl282zknIpWG3fYs6SntV/0dK4Anm3PhpL4twBoqCyjR5LnE Y7OtYeUYd2TjEvFXF1o74Ry+wyrDqdre7FeR3x7GLSP5U/SmOJA= =d7gh -----END PGP SIGNATURE----- --=_At4tGq8kVxdxX5q9cGMGnis--