From Nito@Qindel.ES Fri May 8 00:43:18 2015 Received: (at submit) by bugs.x2go.org; 7 May 2015 22:43:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,HTML_MESSAGE autolearn=ham version=3.3.2 Received: from thor.qindel.com (smtp.qindel.com [89.140.90.34]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3DCBC5DA80 for ; Fri, 8 May 2015 00:43:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by thor.qindel.com (Postfix) with ESMTP id 9AF6F6020B for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) Received: from thor.qindel.com ([127.0.0.1]) by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hco9KOVYgj1I for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by thor.qindel.com (Postfix) with ESMTP id 24A8D6020D for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at thor.qindel.com Received: from thor.qindel.com ([127.0.0.1]) by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3QukMzDm-Hvr for ; Fri, 8 May 2015 00:35:09 +0200 (CEST) Received: from [10.1.0.254] (qvd-254.int.qindel.com [172.26.11.254]) by thor.qindel.com (Postfix) with ESMTPSA id E99E06020B for ; Fri, 8 May 2015 00:35:09 +0200 (CEST) Message-ID: <554BE89D.2030304@Qindel.ES> Date: Fri, 08 May 2015 00:35:09 +0200 From: Nito Martinez User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) Content-Type: multipart/mixed; boundary="------------080608060800020002070205" This is a multi-part message in MIME format. --------------080608060800020002070205 Content-Type: multipart/alternative; boundary="------------090100070408080602080009" --------------090100070408080602080009 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Package: nx-libs Version: 3.5.0.28 Description: The attached patch fixes some compilation errors when the following macros are enabled: (TEST/DEBUG/DUMP). See the lines: #undef TEST #undef DEBUG ... and the conditinal ifdefs #ifdef TEST #ifdef DEBUG ... which are normally not compiled. During debugging and testing when these macros gets activated, there are some compilation errors, which need to be manually fixed each time the Macros are enabled. This patch tries to leverage that error. The patch does not affect code outside of those ifdef, and only provides developer support. Regards, Nito --------------090100070408080602080009 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Package: nx-libs
Version: 3.5.0.28

Description:

The attached patch fixes some compilation errors when the following macros are enabled: (TEST/DEBUG/DUMP). See the lines:

#undef TEST
#undef DEBUG
...

and the conditinal ifdefs

#ifdef TEST
#ifdef DEBUG
...

which are normally not compiled.

During debugging and testing when these macros gets activated, there are some compilation errors, which need to be manually fixed each time the Macros are enabled. This patch tries to leverage that error.

The patch does not affect code outside of those ifdef, and only provides developer support.

Regards,

Nito

--------------090100070408080602080009-- --------------080608060800020002070205 Content-Type: text/x-diff; name="macro_debugging.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="macro_debugging.patch" diff --git a/nxcomp/Agent.h b/nxcomp/Agent.h index fac5acd..1a59412 100644 --- a/nxcomp/Agent.h +++ b/nxcomp/Agent.h @@ -205,7 +205,7 @@ class Agent { #if defined(TEST) || defined(INFO) *logofs << "Agent: proxyCanRead() is " - << ((int) FD_ISSET(proxy -> getFd(), readSet) + << ((int) FD_ISSET(proxy -> getFd(), readSet)) << ".\n" << logofs_flush; #endif diff --git a/nxcomp/ClearArea.cpp b/nxcomp/ClearArea.cpp index 7b693c7..81beb1e 100644 --- a/nxcomp/ClearArea.cpp +++ b/nxcomp/ClearArea.cpp @@ -92,7 +92,7 @@ void ClearAreaStore::dumpIdentity(const Message *message) const ClearAreaMessage *clearArea = (ClearAreaMessage *) message; - *logofs << name() << ": Identity exposures " << clearArea -> (unsigned int) exposures + *logofs << name() << ": Identity exposures " << (unsigned int) clearArea -> exposures << ", window " << clearArea -> window << ", x " << clearArea -> x << ", y " << clearArea -> y << ", width " << clearArea -> width << ", height " << clearArea -> height << ", size " << clearArea -> size_ diff --git a/nxcomp/Proxy.cpp b/nxcomp/Proxy.cpp index 7258fcf..b4b23a9 100644 --- a/nxcomp/Proxy.cpp +++ b/nxcomp/Proxy.cpp @@ -5169,7 +5169,7 @@ char *Proxy::handleSaveAllStores(const char *savePath) const *(cacheDumpName + DEFAULT_STRING_LENGTH - 1) = '\0'; - mode_t fileMode = umask(0077); + fileMode = umask(0077); cacheDump = new ofstream(cacheDumpName, ios::out); diff --git a/nxcomp/ServerChannel.cpp b/nxcomp/ServerChannel.cpp index 52551e7..7f3ef07 100644 --- a/nxcomp/ServerChannel.cpp +++ b/nxcomp/ServerChannel.cpp @@ -5475,7 +5475,7 @@ int ServerChannel::handleColormap(unsigned char &opcode, unsigned char *&buffer, *logofs << "handleColormap: Dumping colormap entries:\n" << logofs_flush; - const unsigned char *p = unpackState_[resource] -> colormap -> data; + const unsigned int *p = unpackState_[resource] -> colormap -> data; for (unsigned int i = 0; i < unpackState_[resource] -> colormap -> entries; i++) --------------080608060800020002070205-- From mike.gabriel@das-netzwerkteam.de Fri May 8 12:03:14 2015 Received: (at 866) by bugs.x2go.org; 8 May 2015 10:03:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EEFE75DA80 for <866@bugs.x2go.org>; Fri, 8 May 2015 12:03:13 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 6D080AAD; Fri, 8 May 2015 12:03:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C66E83BAC4; Fri, 8 May 2015 12:03:12 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PDEPpt6DKMFj; Fri, 8 May 2015 12:03:12 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 682493B99B; Fri, 8 May 2015 12:03:12 +0200 (CEST) Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 08 May 2015 10:03:12 +0000 Date: Fri, 08 May 2015 10:03:12 +0000 Message-ID: <20150508100312.Horde.Iab2cuAyMS--SO_aEOyiaw6@mail.das-netzwerkteam.de> From: Mike Gabriel To: Nito Martinez , 866@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#866: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) In-Reply-To: <554BE89D.2030304@Qindel.ES> User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.97 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_pzw2ixTOF-YPllhCnON4tA2"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_pzw2ixTOF-YPllhCnON4tA2 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nito, On Fr 08 Mai 2015 00:35:09 CEST, Nito Martinez wrote: > Package: nx-libs > Version: 3.5.0.28 > > Description: > > The attached patch fixes some compilation errors when the following=20=20 >=20macros are enabled: (TEST/DEBUG/DUMP). See the lines: > > #undef TEST > #undef DEBUG > ... > > and the conditinal ifdefs > > #ifdef TEST > #ifdef DEBUG > ... > > which are normally not compiled. > > During debugging and testing when these macros gets activated, there=20= =20 >=20are some compilation errors, which need to be manually fixed each=20=20 >=20time the Macros are enabled. This patch tries to leverage that error. > > The patch does not affect code outside of those ifdef, and only=20=20 >=20provides developer support. > > Regards, > > Nito We (people from X2Go and Arctica) changed the nx-libs development=20=20 workflow=20a bit, recently: Now, we normally file pull requests (even internally in our team,=20=20 except=20for small fixes) against the nx-libs 3.6.x branch on Github.=20=20 All=20greater code changes happen for nx-libs 3.6.x first and then get=20= =20 backported=20to 3.5.0.x later (or not at all). All major commits/change=20= =20 shall=20reveive a code review and approval of another dev on the team. So, the initial bug tracking / pull request tracking for nx-libs has=20=20 been=20relocated to Github. Bugs for nx-libs on the X2Go bug tracker are=20= =20 for=20marking PRs or commits worth of being backported to the 3.5.0.x=20=20 branch=20(which is handled by the X2Go devs, mainly Mihai Moldovan at=20=20 the=20time being). Basic splitup of workload: Arctica Project context maintains nx-libs=20=20 3.6.x,=20X2Go context maintains nx-libs 3.5.0.x. Also, Mihai fixed several TEST/DEBUG/DUMP issues on both branches=20=20 (3.5.0.x=20and 3.6.x). It may well be that the fixes you provide here=20=20 already=20exist on 3.5.0.x/HEAD (haven't checked that)? Thus, could you do these following steps: o rebase your patch against nx-libs 3.6.x branch o clone https://github.com/ArcticaProject/nx-libs o create a pr/ branch on your account o file a PR against ArcticaProject/nx-libs 3.6.x branch o wait for Ionic or me to review In the future, I'd be happy to welcome you as another potential pull=20=20 request=20reviewer, so we can distribute the workload even better. Once=20= =20 I=20see your PR, I will grant you write/commit access to nx-libs on=20=20 github.com/ArcticaProject. Greets, Mike --=20 DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_pzw2ixTOF-YPllhCnON4tA2 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJVTIngAAoJEJr0azAldxsxFp0QAKu28HqGMmRhJOkji9ePgvTT 70iTH/dTeLWjgIDf3MCHJF68L1WHrJNU5y4VrLuqyYBp/RFdYUcWJXIuXwv0HvHU XXy2Rt04e/G5Uuya0EgwJ169O4Mu52/Y/Iu3PaWHfPCt+FpMr/v6audUYSqL+Mvf +CxtPyvjw4vZTv9h20usPpr8+T49H4uG5FDZecp2vvkmnTWYdjIKb/xuWM+k4nb8 5W2eZuYeR+cWgSpNJoX5aH6qDCfmgJXZZF11HOpE9fEsAaaGleGgEvPPbYc/1n7P xH08jeAmTg5GBRCcTSnRdEXGSQFpMCBxymvTVzcZVqS7k7tcoH9ejEAV4kmBdMs+ q5Bo0pu68YgBDwoY4Qu1u4wT4yZAcxQAF+2Sjf1ZMlvzhLHFwa+uz7ycIa9qjCWd q6r8hGhdSRMMLoZMysC21sFa3ML2NMwNu3ON5usv6pbhfyi74LK5U/ELTBifqMic +xQSfQxT+B8KQY0ZP4a8E/BGTIT9sQaFkVUhYOO/bzi+uqovkvHG39ZX/bqbG511 MdshB+5nQ+0Lc7B1Ymu2U3zZw3VHN704nSuJG2apc22ke/5XOVtoUncPmpQNKGwN Xe+ZBnKSKXTUwIWATxKrS6zkhfg07Vijval0taSmTDZxp6hWLBW5FnlDX//c1NK1 zRy4O9gThjcQOqtl+MVI =dXQj -----END PGP SIGNATURE----- --=_pzw2ixTOF-YPllhCnON4tA2-- From mike.gabriel@das-netzwerkteam.de Fri May 15 15:48:10 2015 Received: (at control) by bugs.x2go.org; 15 May 2015 13:48:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,MISSING_SUBJECT, URIBL_BLOCKED autolearn=no version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 5DDA85DA82 for ; Fri, 15 May 2015 15:48:10 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 166FFB24 for ; Fri, 15 May 2015 15:48:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id F3E823B980 for ; Fri, 15 May 2015 15:48:08 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jPSQDvKE8CIH for ; Fri, 15 May 2015 15:48:08 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 8C2403B961 for ; Fri, 15 May 2015 15:48:08 +0200 (CEST) Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 15 May 2015 13:48:08 +0000 Date: Fri, 15 May 2015 13:48:08 +0000 Message-ID: <20150515134808.Horde.17u5RrqmdurLW_FR-9JDrA2@mail.das-netzwerkteam.de> From: Mike Gabriel To: control@bugs.x2go.org User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.97 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_aKaj4yUW8i4-mSErWma8Lg7"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_aKaj4yUW8i4-mSErWma8Lg7 Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable tags #865 patch tags #866 patch thanks --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_aKaj4yUW8i4-mSErWma8Lg7 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJVVfkYAAoJEJr0azAldxsx3MMQAINT9dh7yHDDjWiyy81/a/cV u7OOTAdwaE1ihEmsePjoO+MHDuxbK7Dm3VS8opf4gM5T2GIDXTBan9zpKvARsZr0 hY4riLAW1Da/38x+R2bQOslGHcsYgWC/lYYCkxKO0MR9/kKhZ+UuA4iW3tQqKhe2 FIxM44l8lUSDzRVWy4zPWWnNvcrDmpzDbB/C4UDJk5nFNYkGApFbbs1scTtsH1m1 iRyJlFXEw5vIvyH7mrcBLK40hBYNc4/MXpxKLjpOU6CPE4K7QwzFAKXmdemrHKEh AW+QISI5In3a9BSmcT+iMvzj72hXsNgMOznJE/6tJ5gfFkuFrFJI41YXbNYWlO/T x4QoU22ZgZqZxpHD7HVZOLA3W6KV2lRzl4WOvkH7CJX/+97HA0Xn6phmjQotayok 6MXlzd0+2Xu8cJXCiwJUKKf5kE3dGQ3kmZzBd4oE7ynZPONbSdAuIWPjSxymIE4Z cwkUSHUeGsmWM4VFBYfB/XwIzkpU5k5kSU4VsPRcB9vgBmZbr1wNGhU9knkxzZ4u 428Jim+kEgoDxJQdm/5iC/EZ7z5MB9PBAEvx0O6bR4X7JDKDLPN3FxKg+PsQvKzs wL4t09+xSVllKRst6WejFYibQHt4WlJsiPNCg2gla7kMV5FQwwFi1LDbkpZ4PibF eURCzqpWKY5LDsq2vZG7 =SyeB -----END PGP SIGNATURE----- --=_aKaj4yUW8i4-mSErWma8Lg7-- From mike.gabriel@das-netzwerkteam.de Mon Feb 29 10:03:59 2016 Received: (at 866) by bugs.x2go.org; 29 Feb 2016 09:04:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id CB15A5DA95 for <866@bugs.x2go.org>; Mon, 29 Feb 2016 10:03:59 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TZufYRjfPm9A for <866@bugs.x2go.org>; Mon, 29 Feb 2016 10:03:52 +0100 (CET) Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2D1715DA88 for <866@bugs.x2go.org>; Mon, 29 Feb 2016 10:03:52 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E5461B24; Mon, 29 Feb 2016 10:03:51 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 73EAA3B993; Mon, 29 Feb 2016 10:03:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2B0iUjDMVf3M; Mon, 29 Feb 2016 10:03:44 +0100 (CET) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 52B2A3B987; Mon, 29 Feb 2016 10:03:44 +0100 (CET) Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 29 Feb 2016 09:03:44 +0000 Date: Mon, 29 Feb 2016 09:03:44 +0000 Message-ID: <20160229090344.Horde.qMvOYFh1ZBB1q_bGz61vUOf@mail.das-netzwerkteam.de> From: Mike Gabriel To: 866@bugs.x2go.org Cc: Nito Martinez Subject: Re: [X2Go-Dev] Bug#866: Bug#866: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) References: <554BE89D.2030304@Qindel.ES> <20150508100312.Horde.Iab2cuAyMS--SO_aEOyiaw6@mail.das-netzwerkteam.de> In-Reply-To: <20150508100312.Horde.Iab2cuAyMS--SO_aEOyiaw6@mail.das-netzwerkteam.de> User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 178.62.101.154 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.5.0 Content-Type: multipart/signed; boundary="=_h0VEsjB8fVwkLwM9BWjEUQZ"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_h0VEsjB8fVwkLwM9BWjEUQZ Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tags -1 fixed-upstream Control: fixed -1 3.5.99.0 Control: forwarded -1 https://github.com/ArcticaProject/nx-libs/pull/26 On Fr 08 Mai 2015 12:03:12 CEST, Mike Gabriel wrote: > Hi Nito, > > On Fr 08 Mai 2015 00:35:09 CEST, Nito Martinez wrote: > >> Package: nx-libs >> Version: 3.5.0.28 >> >> Description: >> >> The attached patch fixes some compilation errors when the following=20= =20 >>=20macros are enabled: (TEST/DEBUG/DUMP). See the lines: >> >> #undef TEST >> #undef DEBUG >> ... >> >> and the conditinal ifdefs >> >> #ifdef TEST >> #ifdef DEBUG >> ... >> >> which are normally not compiled. >> >> During debugging and testing when these macros gets activated,=20=20 >>=20there are some compilation errors, which need to be manually fixed=20= =20 >>=20each time the Macros are enabled. This patch tries to leverage that=20= =20 >>=20error. >> >> The patch does not affect code outside of those ifdef, and only=20=20 >>=20provides developer support. >> >> Regards, >> >> Nito This issue has been resolved on the 3.6.x branch of nx-libs [1] and a=20=20 backport=20to 3.5.x is recommended, but not critical. Mike [1] https://github.com/ArcticaProject/nx-libs/pull/26 --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/mailxchange/kronolith/fb.php?u=3Dm.gabriel= %40das-netzwerkteam.de --=_h0VEsjB8fVwkLwM9BWjEUQZ Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJW1AlwAAoJEJr0azAldxsxmk4P/0FSzEgcF2rSQKG7d6saw8CF l30lvdFXgcHNHKpQiqpj9G5bH+1RbDj6EgcBmM2C0elA7j7DFRgAI/qFTdD8efdh 6zpsBLJNZP8Ih1fGq+n8iQOtXv6NvigAWy0bYuiXuD3PxloAFP1bSfgxkOgQlQ6U Bz/wUENrS9b7uOKDgoTFdD0eFUeU4sDSZ3xM2bXjRi1310WL9tH2jEOLc6HauLJq VPiJPJifKKlGBQiU4AOIccRyj30Y/44GBRKJWLLewOIwcgd1R/mRClx+EknNnaIU q74nc4r8b4kq6S1gU9NpWlEcgHcou/DQONqIpVtiiI/T76qtXOy2lB/pqIXMN+lI HAqh2oS8IpU5Ig0CL3Y0Bvqe7gCOnaggf+LTX6VbZ2uXdp6vgWjPp4xI5smZJ4sw RF2l3IHnlsfKYTVixWfF2NPckik3O1y+RTNB/ZeWaz6pmnO/d3Lc19KhyzAZv3RU Gnpl9D3yTOhvEmjQ2bVwMQ6OpOKX6REsYJ1xeLNiEwDCW+IaggOuB4vDhyQWuUbf VtoVEgAG+dwjt0UmvYdoT2YmiRyFv0h8RFiwfU/8cNt4JcH+RtuIWb6kl90aNRs1 +rrOuB4arwCEp2IdR4BA7cap7iS+oiuIb9vy+iyv/TI6duwJoBOUOBM7tb/k4FTH Qr6aiWu2rsDASs/jf+IH =bQiD -----END PGP SIGNATURE----- --=_h0VEsjB8fVwkLwM9BWjEUQZ-- From X2Go-ML-1@baur-itcs.de Tue Jan 30 22:57:44 2024 Received: (at 866-quiet) by bugs.x2go.org; 30 Jan 2024 21:57:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F3DD05DA21 for <866-quiet@bugs.x2go.org>; Tue, 30 Jan 2024 22:57:43 +0100 (CET) Received: from [192.168.0.25] ([178.202.75.45]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MWhxY-1rX1Z90z28-00X0xc for <866-quiet@bugs.x2go.org>; Tue, 30 Jan 2024 22:57:43 +0100 Message-ID: <55179376-aa6c-4385-91a3-c5e411551930@baur-itcs.de> Date: Tue, 30 Jan 2024 22:57:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Stefan Baur Content-Language: en-US To: 866-quiet@bugs.x2go.org Subject: Closing/Archiving Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:X4pnBWr7Ps3ddU2IdMqFqmMPa/TMQ4mvEcQybYIsws0Jnv1gAQz AyqCPXMJ3DwDaM1Eok31XQRDKK2BhxsKYcHZ7LDehJhQrb5BeY1GPL789P2/cFcwFG91CtG nr3jegUD9PK5on0xvAvDvZbpfieYcEgzH4oUcyy125fQqhiDRMDKpGtilWtVmad/6JJAsjE ppTiUHuWS+64+Ui3bvMSA== UI-OutboundReport: notjunk:1;M01:P0:LvL1iV4ouYc=;QXYiSl/mLGa6wFoZjbmGVubXtWL fWLwdwdRlQ++UlIAjVb28k6VvAsCnAKgj6XmyDRNRvZlyw66uYwaT/WFvFUpBxT75aVzYHoE4 eO8DvhClQjcxndRY6ARmOgbkEdZrYwKKuK8/Lq8i6uJPxD5yzSsIVD4irzIXmbHE2dYHlJa9S DNNu4QSn3sp+93azpk3SfS9Slvh3oUcDUTaigMn/ukmo7huqh1FeafRaaijEfeaP50FAM2Km0 /8E3+RUF8U35+kdrnWG2IFtjuAd84lmPmsHizxl0xhtEH2xdTDnO01KK+x4FuWJFzpX9B6DdC fjAAwTbqgF8+ih8AkfYxd9mSYJcwlPWTxhH5dE51j4beuVHh9+5x82jJmHUW8fS6s5i8Ce1b/ a5+ROVg7gSJc+WJQq3Au4V9tiUHDdQ03fE7hvfHMBIRiFUrGH8gR3hIZUEzD/Jb0ALMIk3rqi Um0epbs2C7sAFygBd1eHfiqpGb5JOLMqvL7XGUhUT4ZO309Zi2HkeQ8opMkpEokd4lLF3yxpj wWY9kZA/uOguQKZuVW/OjrEhpTqWqA72iK98HxJTllJXHDQfVdvXGxAGkUk4eTHoXDX2B4LYN xg0Ne4TCGp4eds+uKtEWlVq/MYFMoQ05JEXRWwRs15CNn8CpmFGSZoOzrF//AJ6cQ4ri6PZx+ 8kRAn8eeEva/rt7pnSpKWrrOUUzaP1ppzI/tr420F0EFgSqamJlhNS/TKGzG0UJ2zQXykNfA/ MVKAvPUoXe0t58gypEmmKCJK1/OyaRt/gjqaO4YMerGHX/pVH5Pe3SrOhmiBEtR/30E+alVPZ cmPxg/tWXauURyh7WOFjblkfn/es/YggcZldtlBpEwruYE4KuSJKsJ6Thrvap4jt2xrLHli55 1991qIMoTiM1aTA== Control: close -1 Control: archive -1 This bug has long since been moved to the Arctica Project Github issue tracker. Kind Regards, Stefan Baur -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243