From antonio.e.russo@gmail.com Tue Nov 15 14:31:40 2016 Received: (at submit) by bugs.x2go.org; 15 Nov 2016 13:31:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: * X-Spam-Status: No, score=1.2 required=3.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 7F86C3CBB6 for ; Tue, 15 Nov 2016 14:31:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nfyD5ZR-JWfF for ; Tue, 15 Nov 2016 14:31:34 +0100 (CET) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.161.171]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A82593CBB5 for ; Tue, 15 Nov 2016 14:31:33 +0100 (CET) Received: by mail-yw0-f171.google.com with SMTP id r204so94184521ywb.0 for ; Tue, 15 Nov 2016 05:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=BsAOMIqe/RWhjvtyEc2l62Jxy03fZ1Ir1i9C8LQCe2A=; b=EKoGY+JhEsNNpLKH+XfmwnZ2oGVLbcIpTPPJ/qsk17uugEeQSfrj3uILHtlzGqsKHS oc7P8lQMa8iTaZjByPFTmuFpj6p7LvmXT/VDy1LtHLIgdraJoItnTECdOvhPm8nHRpm5 Q+M0Lh5VshwiTjpTZV3CaUy7NDBbCYnt+zVsyXf2Axwv32yt0BbbvJMgwYhVxsKopjFe /BA/uWPXVhZMhDmVNu96R0M5fZqU0yv7fC2teXbXiwGd+YfIYVYdoq8+GvMrJ7du4Ule egV1VULvXAHENl7Qb1IB6aKKUDdUK4jBtpsPegtSJeiXGwE3tOnnffY9OZmP/uZsclnw TkWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=BsAOMIqe/RWhjvtyEc2l62Jxy03fZ1Ir1i9C8LQCe2A=; b=bwEiYpIfyq9k8URYE9exsCIxS9qt0mBhjzklqyZuZLt9ugPF5L2BhDW7N7hJMoTDHs ms3662E2jGOl+JoHgWWjgK2b8EAq17AuEysB4vTDVbKG8L2LnGCiD0Ry4xNwE6yAbgeC jh+A4pkTfbmGO/PafTI24vRW6yZ4mDORO8JkRGZ2aYrJiTl5J/0ObW2f3RZy8CDqgBSD MbeSuDoRVczBvbXpLi5iliFd6hLJwB9j5UEmq9fHOKBdXMJlPqj/pdjM5R6ZuwPl/35n eNBBPHEQcTusR5C2qKHl9kJU+pmz9aliSx8PTIMTIm6TPjoelK2a4hwX4eVtI57rdVks hRpQ== X-Gm-Message-State: ABUngveF0090i7RcgYnWZt1ko2OcxJfvc3l9Zt8Hrlq3XWushcW2UJmGioc2MeeLs/fTQA== X-Received: by 10.129.71.8 with SMTP id u8mr22593678ywa.115.1479216692289; Tue, 15 Nov 2016 05:31:32 -0800 (PST) Received: from [192.168.1.100] ([24.49.13.30]) by smtp.gmail.com with ESMTPSA id d69sm10166654ywh.1.2016.11.15.05.31.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2016 05:31:31 -0800 (PST) To: submit@bugs.x2go.org From: Antonio Russo Subject: segfault on missing ssh-key Message-ID: <20b7866a-787d-5ebd-7ad0-5e30f496730e@gmail.com> Date: Tue, 15 Nov 2016 08:31:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.5.2 (though, presumably, all versions should be affected) On line 1100 of src/sshmasterconnection.cpp, consider the line: > ssh_private_key prkey=privatekey_from_file(my_ssh_session, keyName.toLatin1(), 0,""); If keyName.toLatin1() is not an existing file, you'll get an invalid pointer free. This might be a bug in libssh, but it took me an embarrassingly long time to figure out what was wrong, so others might be similarly confused. Thanks From ionic@ionic.de Sun Feb 26 05:56:02 2017 Received: (at control) by bugs.x2go.org; 26 Feb 2017 04:56:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MISSING_SUBJECT,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id E7C195DBE3 for ; Sun, 26 Feb 2017 05:55:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5StYsW1FXVha for ; Sun, 26 Feb 2017 05:55:51 +0100 (CET) Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 248975DBE2 for ; Sun, 26 Feb 2017 05:55:51 +0100 (CET) Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41]) by mail.ionic.de (Postfix) with ESMTPSA id BA35B4F0072E for ; Sun, 26 Feb 2017 05:55:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1488084951; bh=V/aRH9jYfmXtVhvqpldPjBQQ6wf0AX3KjWwtqTaKq6o=; h=To:From:Date:From; b=fTNDO9FtKUAo2hFxCdt56m8ktRVhZDrI90WyqFt6dz/fdor6Fmhdl5S7bgRdXu7s6 ykTeqzK/4sP/FIxkLMN7uXYqvrA23oNaX9S4sVDOo68cl0SYGjAeW4FGtJqu7XSs2r GeeFeJpk2JsIP8MNTNYjA7z1zARV0GBLaJhL4HIQ= To: control@bugs.x2go.org From: Mihai Moldovan Message-ID: <72ef8ffd-785d-b7af-0c10-d401c34f3e80@ionic.de> Date: Sun, 26 Feb 2017 05:55:49 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="X1HuVNFghxKcf4b2jLOiu9u8J44vTWoei" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X1HuVNFghxKcf4b2jLOiu9u8J44vTWoei Content-Type: multipart/mixed; boundary="IG1SRFFAQr1hQ3aMrwJH7jKkuUfeMmcaE"; protected-headers="v1" From: Mihai Moldovan To: control@bugs.x2go.org Message-ID: <72ef8ffd-785d-b7af-0c10-d401c34f3e80@ionic.de> --IG1SRFFAQr1hQ3aMrwJH7jKkuUfeMmcaE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable merge 1119 1112 thanks --IG1SRFFAQr1hQ3aMrwJH7jKkuUfeMmcaE-- --X1HuVNFghxKcf4b2jLOiu9u8J44vTWoei Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJYsl/VAAoJEB/WLtluJTqHjScP/Ro0UtLxku4y0YI7bTYAB7/g RU+b3/EjdctWBBYOPStQHC+FYASYuPzUtME/BLlDfoKSlQPzl/Tn02s7FMjwaCBa +jvqMzwlHaGAq5IqX/kcvlhfxehDNMVf5kYJUh1i78bSyLqYusDed3x0/s+4jS7y zIP9etFKs6htqMyzEDihqp65n5EiYfpYGY1G0nBEnpA8gMjqORaqtx2Dlo2oBEFf PWuM7yI6t0NiA/f0bPRELCXNkicf2q2lVQ4KmUU/lf1iPoqLyMaBCm95cUeH5n55 r3gGEPecbsImUt0egn3t+0Vr3xch1fe/ecM5s6/kNMNARyWkBv/fmt/UoPuBA4gM QN4fh4hFptkVyInYB5/LMg00sa47VgO/bz3WAzE8EvrAj3fNePbMJZM4lVwaTiSQ 7uuqMEiMLJvTseYxZb0FQHa0zObMnwaGUWts/4SKviDMFknBAINuqLRpg/vqsTaf HlX5GudUYQYwx1lPlOXpNB6RBkUVusZS/Wl61I5RHArMy+UbikmwytKQWGYzmePq rtb7BPKm1miss43gp4RnFqfSe9Cw2EiYxqjosAuVyW5AbyRMMHJ1YEPjfoEACyGh VEkWUJdrhBiU53QgQ6Y2hSzhGexucVHrFDO7bxmcQyGKYm3x7oI408AnlhBcY77m 6RGkh8d96KV5amKdos9f =+Dp4 -----END PGP SIGNATURE----- --X1HuVNFghxKcf4b2jLOiu9u8J44vTWoei-- From x2go@ymir.das-netzwerkteam.de Thu Mar 2 09:14:39 2017 Received: (at control) by bugs.x2go.org; 2 Mar 2017 08:14:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id D10C53BC8D; Thu, 2 Mar 2017 09:14:39 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4NOC3O0uQG2b; Thu, 2 Mar 2017 09:14:32 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id CB6B65DBE2; Thu, 2 Mar 2017 09:14:32 +0100 (CET) From: Mihai Moldovan To: 1119-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1119@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as pending for release Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailer: http://snipr.com/post-receive-tag-pending Message-Id: <20170302081432.CB6B65DBE2@ymir.das-netzwerkteam.de> Date: Thu, 2 Mar 2017 09:14:32 +0100 (CET) tag #1119 pending fixed #1119 4.1.0.1 thanks Hello, X2Go issue #1119 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=d46c15e The issue will most likely be fixed in src:x2goclient (4.1.0.1). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit d46c15e51682f61afc66ff2b5505c50ce242a67d Author: Mihai Moldovan Date: Thu Mar 2 09:14:04 2017 +0100 src/sshmasterconnection.cpp: use new PKI-based libssh API for public key authentication for libssh 0.6.0 and higher. Fixes: #1119. diff --git a/debian/changelog b/debian/changelog index f1bff6b..796376c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -129,6 +129,8 @@ x2goclient (4.1.0.1-0x2go1) UNRELEASED; urgency=medium any address. Fixes: #31. - src/onmainwindow.cpp: check for sessionExplorer->getLastSession() to be valid in all places but obvious ones. Fixes: #499. + - src/sshmasterconnection.cpp: use new PKI-based libssh API for public key + authentication for libssh 0.6.0 and higher. Fixes: #1119. [ Oleksandr Shneyder ] * New upstream version (4.1.0.1): From ionic@ionic.de Sun Oct 29 08:17:01 2017 Received: (at control) by bugs.x2go.org; 29 Oct 2017 07:17:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MISSING_SUBJECT,RDNS_NONE autolearn=no autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 452925DAD1 for ; Sun, 29 Oct 2017 08:17:01 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k8nkpuN1crvB for ; Sun, 29 Oct 2017 08:16:48 +0100 (CET) Received: from mail.ionic.de (unknown [IPv6:2001:41d0:a:588b:1::2]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A96A75DA81 for ; Sun, 29 Oct 2017 08:16:48 +0100 (CET) Received: from [10.20.40.15] (178.162.222.163.adsl.inet-telecom.org [178.162.222.163]) by mail.ionic.de (Postfix) with ESMTPSA id D0A6B4F001C7 for ; Sun, 29 Oct 2017 08:16:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1509261407; bh=FhIjYfBD2BqJGGFEiKu5gLsQq+7+GSaS/fIhtRDbSDE=; h=To:From:Date:From; b=GgGRtTr0xCWInFhl7PCpQcmrvlIIOzWrvFDovLBSj5EKvHnXshZF2wrITCu+HmHci gpjnEjdcvpzoNhVOK+7IkYIYxw/PpCyVnEN2IC3TCKkKGrABbs/SZCg0edycxFdMR0 NMi++TumerH2JuK/6H2rsO2EBaxgNFIf9aHJ8cMw= To: control@bugs.x2go.org From: Mihai Moldovan Message-ID: <9477f15a-6500-b119-ee94-b9ee46aa3120@ionic.de> Date: Sun, 29 Oct 2017 08:16:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UaU23RKUCILnFu9Dx0W4kdODwj9pAaOWX" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UaU23RKUCILnFu9Dx0W4kdODwj9pAaOWX Content-Type: multipart/mixed; boundary="JC24bGfW4nIDo1aOkrhaaXsSJxsU3gouc"; protected-headers="v1" From: Mihai Moldovan To: control@bugs.x2go.org Message-ID: <9477f15a-6500-b119-ee94-b9ee46aa3120@ionic.de> --JC24bGfW4nIDo1aOkrhaaXsSJxsU3gouc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable notfixed 870 4.1.0.1 fixed 870 4.1.1.0 notfixed 1121 4.1.0.1 fixed 1121 4.1.1.0 notfixed 1093 4.1.0.1 fixed 1093 4.1.1.0 notfixed 31 4.1.0.1 fixed 31 4.1.1.0 notfixed 499 4.1.0.1 fixed 499 4.1.1.0 notfixed 1119 4.1.0.1 fixed 1119 4.1.1.0 notfixed 930 4.1.0.1 fixed 930 4.1.1.0 notfixed 966 4.1.0.1 fixed 966 4.1.1.0 notfixed 592 4.1.0.1 fixed 592 4.1.1.0 notfixed 31 4.1.0.1 fixed 31 4.1.1.0 unarchive 1152 reopen 1152 notfixed 1152 4.1.0.1 fixed 1152 4.1.1.0 notfixed 1165 4.1.0.1 fixed 1165 4.1.1.0 thanks --JC24bGfW4nIDo1aOkrhaaXsSJxsU3gouc-- --UaU23RKUCILnFu9Dx0W4kdODwj9pAaOWX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCgAdFiEEbhHQj3UzgcdE8cg8H9Yu2W4lOocFAln1gF4ACgkQH9Yu2W4l Oof9pw//f678yYdC0uVkHa2Fc6GW6e2dzpJ3mY2sbi8i0OpQ+rJihpYp39wdRliu Dm82Ja7eQlV32S45hMcubjfSYavzuL2ou9BpYz4BbAsqtIsHDuuA1UZaFO+6NGvE uusaf2pY+IdoGDR7pSUkEICXtSk5JOhvjtokTbciSm3/V6UkFw9t1Mpv20380KvP rmTxOpMpjFMzpnI7Iu7T06tAGNG2l0iRqe9IMTGv/YfzQ3JeNuAuLTjpP802szUj a16Tb/mTTWh5OZDmSsjcHuc6E9/SSOGpj61qUI98SYXlCrzba1BW4oS622DvYEg4 l0rUda9LJw5CCr8cQx779SrL4DHVeCU3HGsNPTV8zYNDB0LDV1vy4smqFL7EHBEK gydwR2zrQb+0ewlBSONFADnLHJAxTbAKitK0mIoc0Zvj8TkVADdnUS6g4/Gv3j6E WBgx7FLRLzlPBNBZ9jOmKaLDexh8RcZI+Dm9BBphZ7qH5BccAacdFYdI3//w3QU9 v3L9z4Iq0KfT+VsMNpMUKC2mfsTeLFdT0Gm4X1n0p6G7CedC8RDgqPpTcuZtstAn YRwAyUPXT6mk3zN9ZL4Uifc8PtSfQmjjt910UTeNeaqdUVEGK6llQH+PH+AiBngn TkmvHZ5v362lAsGqpvv15XMJ1sSbBPbQJTlVfAKpGyKYW6PyaBA= =RY9x -----END PGP SIGNATURE----- --UaU23RKUCILnFu9Dx0W4kdODwj9pAaOWX-- From x2go@ymir.das-netzwerkteam.de Sun Oct 29 08:46:17 2017 Received: (at control) by bugs.x2go.org; 29 Oct 2017 07:46:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 6DD805DAD7; Sun, 29 Oct 2017 08:46:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OJlg7C1lmTFo; Sun, 29 Oct 2017 08:46:12 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id EBD1C5DAD8; Sun, 29 Oct 2017 08:45:52 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1119-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1119@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20171029074552.EBD1C5DAD8@ymir.das-netzwerkteam.de> Date: Sun, 29 Oct 2017 08:45:52 +0100 (CET) close #1119 thanks Hello, we are very hopeful that X2Go issue #1119 reported by you has been resolved in the new release (4.1.1.0) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.0) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eafcb63c2ac63ae7ce43886949945e710c81bd3d;hp=add03ee78f3dcbee3317bf17a08dcb2cbeb12ee7 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.0-0x2go1 Status: RELEASE Date: Sun, 29 Oct 2017 08:43:45 +0100 Fixes: 31 499 592 870 930 966 1093 1100 1119 1121 1152 1165 1185 1186 Changes: x2goclient (4.1.1.0-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.0): - src/sshmasterconnection.cpp: use ssh_channel_listen_forward () instead of ssh_forward_listen () for newer libssh versions. Fixes: #870. - src/sshmasterconnection.cpp: with libssh 0.6.0 and newer, get the public key via ssh_get_server_publickey () (0.8.0 and higher) or ssh_get_publickey () (0.7.x and lower) and its hash via ssh_get_publickey_hash () instead of using the deprecated ssh_get_pubkey_hash () function. Additionally, replace free () with the more appropriate ssh_string_free_char () function after using ssh_get_hexa (). This will break on very old systems with a hopelessly outdated libssh version, but we do not care about these systems in the first place. - src/sshmasterconnection.cpp: replace string_free () with its successor ssh_string_free (). Will break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_new () function with ssh_channel_new (). Might break on ancient systems, but we don't care. Also, add error handling in case ssh_channel_new () failed... - src/sshmasterconnection.cpp: replace deprecated channel_open_forward () function with ssh_channel_open_forward (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_open_session () function with ssh_channel_open_session (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_request_exec () function with ssh_channel_request_exec (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_poll () function with ssh_channel_poll (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_read () function with ssh_channel_read (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_is_eof () function with ssh_channel_is_eof (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_write () function with ssh_channel_write (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_send_eof () function with ssh_channel_send_eof (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_close () function with ssh_channel_close (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_free () function with ssh_channel_free (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: use QString::arg () to insert function name and thus deduplicate error translation messages. Also re-add the full stop sign and remove it when needed for x2goDebug. - src/sshmasterconnection.cpp: fix up some debug strings. - src/sshmasterconnection.cpp: port more occurrences of "QString to C string" akin to 1b21d75f2c10609f3586f5b5e0b4ceb7fca83fdd. - src/sshmasterconnection.cpp: enable parsing of ~/.ssh/config. Fixes: #1121. Shorthands as host names and other bells and whistles like inferred port or user name values are now supported. - src/{onmainwindow,httpbrokerclient}.cpp: fix up error/warning message displayed when the server-specified key is unknown, but we have another key type stored already. - src/pulsemanager.cpp: fix up a debug string. Qt drops a space where I'd like to have one and inserts a space where I'd like none, so work around that fancifully. - src/sshmasterconnection.cpp: libssh < 0.6.0 does not have the ssh_options_get () API, but instead expects users to pull out information directly from the ssh_session structure. This fixes compile issues on systems with older libssh versions. - src/sshmasterconnection.cpp: turns out libssh < 0.6.0 doesn't support fetching the host, port and username parameters at all. We're in the clear for non-SSH-proxied connections and can use config file parsing, but have to disable config file parsing in the proxy settings, as there's no way to query the remote endpoint information. As a result we will be unable to open a new socket to the remote endpoint and proxying will fail badly. - src/x2goutils.cpp: ensure that add_to_path () also processes the first value passed. Fixes startup problems in MacPorts. Fixes: #1093. - res/i18n/x2goclient_et.ts: various fixups for the Estonian translation file. - res/i18n/x2goclient_*.ts: go the extra mile and fix up translation files manually after the "anothertype" fix in 8e503d89ee2d03a313c3deff11f0516fce503022. - {src/{onmainwindow,httpbrokerclient}.cpp,res/i18n/x2goclient_*.ts}: fix another occurrence of a string missing a space separator between words and update translation files. - src/onmainwindow.cpp: don't duplicate depth warning message needlessly, use correct plural forms in translations and split string up in a translation-friendly form. I'll leave translators to handle this beast, as languages are unique in the number of plural forms and the like. - {src/printdialog.cpp,res/i18n/x2goclient_*.ts}: drop spurious left-over parenthesis in warning message and adapt translations. - src/onmainwindow.cpp: make the "not loading translator" message non-translatable, as it doesn't make a lot of sense to actually translate it. - {src/{configdialog,x2goutils}.cpp,res/i18n/x2goclient_*.ts}: change XQuartz project homepage references, adapt translations. - src/pulsemanager.{cpp,h}: make get_* () functions const. - src/pulsemanager.{cpp,h}: make is_server_running () const. - src/pulsemanager.{cpp,h}: add new pulse_version_valid_ boolean class member variable, set it correctly and use it whenever the version is accessed. - src/pulsemanager.cpp: make fetch_pulseaudio_version () more resilient. Instead of aborting hard when the version number could not be detected, break out of the loops only. We can make stuff work, even if the version is unknown. Or just continue without PA support as such. - src/pulsemanager.{cpp,h}: add show_startup_warning () for both PA server and (debug) startup sound playback. - src/pulsemanager.cpp: check server_binary_ before using it and jump over code that assumes the PA server binary to be available. - src/pulsemanager.cpp: don't fail hard on OS X if the PA server binary could not be found in the constructor. We can live without PA and will show a warning message to the user later on when PA is supposed to be started. - src/pulsemanager.cpp: deduplicate warning/error messages - make use of show_startup_warning (). This does imply changes to the translation files, coming up next. - res/i18n/x2goclient_*.ts: regenerate translation files and fix up some SSH and PulseManager messages manually, where possible. - src/x2ogutils.h: guard UNUSED macro definition. - {macbuild.sh,src/{x2goutils.h,{pulsemanager,onmainwindow}.cpp}, x2goclient.pro}: make MacPorts prefix selectable at compile time. Much cleaner for downstream package maintainers (like, for instance, MacPorts itself.) - res/i18n/x2goclient_fi.ts: remove outdated comment. - src/sshprocess.cpp: bind direct tunnel socket to localhost instead of any address. Fixes: #31. - src/onmainwindow.cpp: check for sessionExplorer->getLastSession() to be valid in all places but obvious ones. Fixes: #499. - src/sshmasterconnection.cpp: use new PKI-based libssh API for public key authentication for libssh 0.6.0 and higher. Fixes: #1119. - src/sshmasterconnection.cpp: add YubiKey challenge auth prompt. - src/sshmasterconnection.cpp: fix compile errors on pre-libssh-0.6.0 systems and add a TOCTU-race check to see if the file exists prior to calling privatekey_from_file () on such systems. Additionally fix a type issue. - macbuild.sh: fix long-standing issue that made the DMG bundle contain a symlink made up of only a space to /Applications. - res/img/icons/dmg: add new image disk.svg, used as the basis for the new OS X DMG bundle icon. - res/img/icons/dmg: add new disk-drive-and-x2goclient icon for use as the volume icon of the OS X DMG bundle. - macbuild.sh: use the new volume icon that actually also looks like a disk drive. Fixes: #930. - src/onmainwindow.cpp: typo fix only. - src/onmainwindow.cpp: do not automatically set login user name to current system user if empty. Unbreaks default user name fetching via libssh. Might break some use cases (especially RDP, XDMCP). - src/x2goclient.cpp: revert change bypassing the UNIX cleanup helper. - src/onmainwindow.cpp: revert old behavior and select user name field after a session has been suspended/terminated if user name was not provided. Do not insert an user name, though, but leave it to autodetection by default. - src/sshmasterconnection.cpp: fix SSH-proxied connections with port numbers of zero. In order to authenticate the remote server, SSH-proxied connections must be reset to their remote host and port values after connecting via the SSH tunnel. If the original port value was zero, setting it was skipped, leading to connections like $REMOTE_HOST:$PROXY_PORT, which is certainly wrong. Fetch the inferred port value and set this instead, fixing this issue. - Makefile: add new QMAKE_OPTS variable so that packagers can pass additional options to qmake directly. - src/sshmasterconnection.cpp: typo fix in log message only. - src/sshmasterconnection.cpp: don't leak ssh_session data, free it once we're done with it. - Makefile: qmake seems to act weird if QMAKE_C(XX)FLAGS starts with a space followed by additional non-whitespace characters. Refactor the variables a bit to work around this issue. - Makefile: turns out the only somewhat portable way to do something like this is via shell hackery. - Makefile: reset to the original state and make sure that we don't pass CXXFLAGS on to the actual build process to not override the values generated by qmake. - Makefile: the only way to prevent variables on the command line to be passed down seems to be to remove them from MAKEOVERRIDES. .MAKEOVERRIDES is the FreeBSD-make-equivalent variable. MAKEFLAGS has no effect on this behavior, so removing it again. - Makefile: add comment explaining why we need to do this in the first place and why it's so complicated. - src/sshmasterconnection: ignore "garbage", but require at least one line to start with a known challenge auth prompt. Fixes: #966. - x2goclient.pro: add libssh_threads library. We need this since X2Go Client is multi-threaded. - copy-deps-win32.bat: also copy libssh_threads.dll to go with the previous change. - src/{onmainwindow,sshmasterconnection}.{cpp,h}: correctly initialize and finalize libssh. We ought to do both only once - in our main thread. Previously, we initialized libssh in a new thread, which might be problematic. - src/sessionexplorer.cpp: open the correct tab when editing a session from the exports menu. - src/onmainwindow.cpp: try to workaround window placement if settings contain a (newly) invalid position (e.g., a position that refers to a disconnected display.) - src/onmainwindow.cpp: try to find a display that can hold the window's position fetched from the sizes settings. Use the default if none could be found. - src/onmainwindow.cpp: fix up main window position check; use QRect.intersects (). - src/pulsemanager.{cpp,h}: rename shutdownState to shutdown_state_, reorder in initializer list. - res/i18n/: regenerate translations. - res/i18n/x2goclient_es.ts: fixup Spanish translation file. - res/i18n/x2goclient_et.ts: fixup some typos in the Estonian translation file. - res/i18n/x2goclient_sv.ts: add singular form to translation entry as discussed on list. - res/i18n/x2goclient_es.ts: add singular form to translation entry as discussed off list. - res/i18n/x2goclient_nl.ts: various fixups for Dutch translation file. - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway) translation file. - res/i18n/x2goclient_nl.ts: fix whitespace issues in Dutch translation file and re-add numerus form translation. - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway) translation file, including numerus form. - src/sshmasterconnection.cpp: for proxied connections, fetch the user name matching the given host, not proxy host. - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file. - res/i18n/x2goclient_fi.ts: another tiny whitespace fixup for Finnish translation file. - src/onmainwindow.cpp: fix "XMDCP" typo. - res/i18n/x2goclient_de.ts: various fixups for German translation file. - src/onmainwindow.cpp: fix "loose" vs. "lose" spelling mistake. - res/i18n/x2goclient_et.ts: remove obsolete and wrongly capitalized "x2go" part from an Estonian translation message. - res/i18n/x2goclient_sv.ts: minor whitespace fixup. - res/i18n/x2goclient_*.ts: apply "XMDCP" -> "XDMCP" fix manually to translation files. - res/i18n/x2goclient_nb_no.ts: remove obsolete comments (leading to problems when regenerating translation files.) - res/i18n/x2goclient_nl.ts: remove obsolete comments (leading to problems when regenerating translation files.) - res/i18n/x2goclient_*.ts: regenerate translations. - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file. - src/sshmasterconnection.cpp: spelling fix. (Quiting -> Quitting) - x2gobrowserplugin-2.4_1/src/qtbrowserplugin.cpp: spelling fix. (convertable -> convertible) * x2goclient.spec: - Respect %{optflags} and pass QMAKE_STRIP=: to fix missing debug info issues. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.0): - Interaction with SSH server (for example for changing expired password). Fixes: #592. - Fixing setting widget style issue in InteractionDialog on Windows client. - SSH Interaction for SSH Broker and SSH Server. - SSH Iteraction for method keyboard-interactive. - Move PulseManager MsgBox functions to main window: GUI functions should be used only from main thread. - Check "norecord" option on the first start of PulseAudio. - Disable/Enable PulseAudio in config dialog. New command line options: --disable-pulse to disable start of PulseAudio --disable-pulse-record to disable audio input. - Check if PulseAudio running at session start and resuming when sound is enabled. Show warning if PulseAudio not running and disable the sound support for the session to avoid session freezes. - Add session config file option "sshproxysamekey". With this option client will use for proxy authentication same key as for X2Go server. This is important in first case for broker users, where key can be generated "on the fly". Maybe it makes sence to add this option in UI and command line later. - Correct negative display coordinates for FS sessions. . [ Robert Parts ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_et.ts: update Estonian translation file. - res/i18n/x2goclient_et.ts: update Estonian translation file. . [ Martti Pitkänen ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_fi.ts: update Finnish translation file. - res/i18n/x2goclient_fi.ts: update Finnish translation file. - res/i18n/x2goclient_fi.ts: update Finnish translation file. . [ Mike DePaulo ] * New upstream version (4.1.1.0): - Windows: Upgrade PulseAudio from 6.0 to 7.1 Fixes: #1152 Issues with audio when playing HTML5 videos - Windows: Remove uninstaller from start menu. It is still available in "Programs and Features". - Windows: Upgrade Win32 OpenSSL from 1.0.1t to 1.0.2k Fixes numerous CVEs - Windows: Upgrade libssh from 0.7.0 to 0.7.4 (while maintaining Pageant support). The possibly relevant changes are: + CVE-2016-0739 was fixed + improved id_ed25519 support + numerous bug fixes - Windows: Update PuTTY from 0.67 to 0.68 The possibly relevant changes are: + CVE-2016-6167 was fixed (did not affect X2Go Client by default because the installation dir is not writeable by users) + CVE-2017-6542 was fixed - Don't override PATH for the actual session or application command. Fixes: #1100 . [ Walid Moghrabi ] * New upstream version (4.1.1.0): - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: let --background take a directory and randomly pick an SVG file in there. Fixes: #1165. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: pass-through broker credentials when connecting to a direct RDP session. Fixes: #1185. Adds a new --broker-use-creds-for-session parameter. - src/onmainwindow.cpp: support --close-disconnect for direct RDP sessions. Fixes: #1186. . [ Daniel Lindgren ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_sv.ts: update Swedish translation file. . [ Ricardo Díaz Martín ] * New upstream release (4.1.1.0): - res/i18n/x2goclient_es.ts: update Spanish translation file. . [ Jos Wolfkamp ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_nl.ts: update Dutch translation file. - res/i18n/x2goclient_nl.ts: update Dutch translation file. . [ Klaus Ade Johnstad ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file. - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file. . [ Stefan Baur ] * New upstream release (4.1.1.0): - res/i18n/x2goclient_de.ts: update German translation file. . [ Sébastien Ducoulombier ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_fr.ts: update French translation file. From unknown Thu Mar 28 21:30:46 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1112 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2goclient) has been marked as closed) Message-ID: References: <20171029074552.EBD1C5DAD8@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 1112 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Sun, 29 Oct 2017 07:50:12 +0000 Content-Type: multipart/mixed; boundary="----------=_1509263412-25193-1" This is a multi-part message in MIME format... ------------=_1509263412-25193-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #1112: segfault on missing ssh-key It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1509263412-25193-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 29 Oct 2017 07:46:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 6DD805DAD7; Sun, 29 Oct 2017 08:46:17 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OJlg7C1lmTFo; Sun, 29 Oct 2017 08:46:12 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id EBD1C5DAD8; Sun, 29 Oct 2017 08:45:52 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1119-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1119@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20171029074552.EBD1C5DAD8@ymir.das-netzwerkteam.de> Date: Sun, 29 Oct 2017 08:45:52 +0100 (CET) close #1119 thanks Hello, we are very hopeful that X2Go issue #1119 reported by you has been resolved in the new release (4.1.1.0) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.0) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eafcb63c2ac63ae7ce43886949945e710c81bd3d;hp=add03ee78f3dcbee3317bf17a08dcb2cbeb12ee7 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.0-0x2go1 Status: RELEASE Date: Sun, 29 Oct 2017 08:43:45 +0100 Fixes: 31 499 592 870 930 966 1093 1100 1119 1121 1152 1165 1185 1186 Changes: x2goclient (4.1.1.0-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.0): - src/sshmasterconnection.cpp: use ssh_channel_listen_forward () instead of ssh_forward_listen () for newer libssh versions. Fixes: #870. - src/sshmasterconnection.cpp: with libssh 0.6.0 and newer, get the public key via ssh_get_server_publickey () (0.8.0 and higher) or ssh_get_publickey () (0.7.x and lower) and its hash via ssh_get_publickey_hash () instead of using the deprecated ssh_get_pubkey_hash () function. Additionally, replace free () with the more appropriate ssh_string_free_char () function after using ssh_get_hexa (). This will break on very old systems with a hopelessly outdated libssh version, but we do not care about these systems in the first place. - src/sshmasterconnection.cpp: replace string_free () with its successor ssh_string_free (). Will break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_new () function with ssh_channel_new (). Might break on ancient systems, but we don't care. Also, add error handling in case ssh_channel_new () failed... - src/sshmasterconnection.cpp: replace deprecated channel_open_forward () function with ssh_channel_open_forward (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_open_session () function with ssh_channel_open_session (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_request_exec () function with ssh_channel_request_exec (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_poll () function with ssh_channel_poll (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_read () function with ssh_channel_read (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_is_eof () function with ssh_channel_is_eof (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_write () function with ssh_channel_write (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_send_eof () function with ssh_channel_send_eof (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_close () function with ssh_channel_close (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: replace deprecated channel_free () function with ssh_channel_free (). Might break on ancient systems, but we don't care. - src/sshmasterconnection.cpp: use QString::arg () to insert function name and thus deduplicate error translation messages. Also re-add the full stop sign and remove it when needed for x2goDebug. - src/sshmasterconnection.cpp: fix up some debug strings. - src/sshmasterconnection.cpp: port more occurrences of "QString to C string" akin to 1b21d75f2c10609f3586f5b5e0b4ceb7fca83fdd. - src/sshmasterconnection.cpp: enable parsing of ~/.ssh/config. Fixes: #1121. Shorthands as host names and other bells and whistles like inferred port or user name values are now supported. - src/{onmainwindow,httpbrokerclient}.cpp: fix up error/warning message displayed when the server-specified key is unknown, but we have another key type stored already. - src/pulsemanager.cpp: fix up a debug string. Qt drops a space where I'd like to have one and inserts a space where I'd like none, so work around that fancifully. - src/sshmasterconnection.cpp: libssh < 0.6.0 does not have the ssh_options_get () API, but instead expects users to pull out information directly from the ssh_session structure. This fixes compile issues on systems with older libssh versions. - src/sshmasterconnection.cpp: turns out libssh < 0.6.0 doesn't support fetching the host, port and username parameters at all. We're in the clear for non-SSH-proxied connections and can use config file parsing, but have to disable config file parsing in the proxy settings, as there's no way to query the remote endpoint information. As a result we will be unable to open a new socket to the remote endpoint and proxying will fail badly. - src/x2goutils.cpp: ensure that add_to_path () also processes the first value passed. Fixes startup problems in MacPorts. Fixes: #1093. - res/i18n/x2goclient_et.ts: various fixups for the Estonian translation file. - res/i18n/x2goclient_*.ts: go the extra mile and fix up translation files manually after the "anothertype" fix in 8e503d89ee2d03a313c3deff11f0516fce503022. - {src/{onmainwindow,httpbrokerclient}.cpp,res/i18n/x2goclient_*.ts}: fix another occurrence of a string missing a space separator between words and update translation files. - src/onmainwindow.cpp: don't duplicate depth warning message needlessly, use correct plural forms in translations and split string up in a translation-friendly form. I'll leave translators to handle this beast, as languages are unique in the number of plural forms and the like. - {src/printdialog.cpp,res/i18n/x2goclient_*.ts}: drop spurious left-over parenthesis in warning message and adapt translations. - src/onmainwindow.cpp: make the "not loading translator" message non-translatable, as it doesn't make a lot of sense to actually translate it. - {src/{configdialog,x2goutils}.cpp,res/i18n/x2goclient_*.ts}: change XQuartz project homepage references, adapt translations. - src/pulsemanager.{cpp,h}: make get_* () functions const. - src/pulsemanager.{cpp,h}: make is_server_running () const. - src/pulsemanager.{cpp,h}: add new pulse_version_valid_ boolean class member variable, set it correctly and use it whenever the version is accessed. - src/pulsemanager.cpp: make fetch_pulseaudio_version () more resilient. Instead of aborting hard when the version number could not be detected, break out of the loops only. We can make stuff work, even if the version is unknown. Or just continue without PA support as such. - src/pulsemanager.{cpp,h}: add show_startup_warning () for both PA server and (debug) startup sound playback. - src/pulsemanager.cpp: check server_binary_ before using it and jump over code that assumes the PA server binary to be available. - src/pulsemanager.cpp: don't fail hard on OS X if the PA server binary could not be found in the constructor. We can live without PA and will show a warning message to the user later on when PA is supposed to be started. - src/pulsemanager.cpp: deduplicate warning/error messages - make use of show_startup_warning (). This does imply changes to the translation files, coming up next. - res/i18n/x2goclient_*.ts: regenerate translation files and fix up some SSH and PulseManager messages manually, where possible. - src/x2ogutils.h: guard UNUSED macro definition. - {macbuild.sh,src/{x2goutils.h,{pulsemanager,onmainwindow}.cpp}, x2goclient.pro}: make MacPorts prefix selectable at compile time. Much cleaner for downstream package maintainers (like, for instance, MacPorts itself.) - res/i18n/x2goclient_fi.ts: remove outdated comment. - src/sshprocess.cpp: bind direct tunnel socket to localhost instead of any address. Fixes: #31. - src/onmainwindow.cpp: check for sessionExplorer->getLastSession() to be valid in all places but obvious ones. Fixes: #499. - src/sshmasterconnection.cpp: use new PKI-based libssh API for public key authentication for libssh 0.6.0 and higher. Fixes: #1119. - src/sshmasterconnection.cpp: add YubiKey challenge auth prompt. - src/sshmasterconnection.cpp: fix compile errors on pre-libssh-0.6.0 systems and add a TOCTU-race check to see if the file exists prior to calling privatekey_from_file () on such systems. Additionally fix a type issue. - macbuild.sh: fix long-standing issue that made the DMG bundle contain a symlink made up of only a space to /Applications. - res/img/icons/dmg: add new image disk.svg, used as the basis for the new OS X DMG bundle icon. - res/img/icons/dmg: add new disk-drive-and-x2goclient icon for use as the volume icon of the OS X DMG bundle. - macbuild.sh: use the new volume icon that actually also looks like a disk drive. Fixes: #930. - src/onmainwindow.cpp: typo fix only. - src/onmainwindow.cpp: do not automatically set login user name to current system user if empty. Unbreaks default user name fetching via libssh. Might break some use cases (especially RDP, XDMCP). - src/x2goclient.cpp: revert change bypassing the UNIX cleanup helper. - src/onmainwindow.cpp: revert old behavior and select user name field after a session has been suspended/terminated if user name was not provided. Do not insert an user name, though, but leave it to autodetection by default. - src/sshmasterconnection.cpp: fix SSH-proxied connections with port numbers of zero. In order to authenticate the remote server, SSH-proxied connections must be reset to their remote host and port values after connecting via the SSH tunnel. If the original port value was zero, setting it was skipped, leading to connections like $REMOTE_HOST:$PROXY_PORT, which is certainly wrong. Fetch the inferred port value and set this instead, fixing this issue. - Makefile: add new QMAKE_OPTS variable so that packagers can pass additional options to qmake directly. - src/sshmasterconnection.cpp: typo fix in log message only. - src/sshmasterconnection.cpp: don't leak ssh_session data, free it once we're done with it. - Makefile: qmake seems to act weird if QMAKE_C(XX)FLAGS starts with a space followed by additional non-whitespace characters. Refactor the variables a bit to work around this issue. - Makefile: turns out the only somewhat portable way to do something like this is via shell hackery. - Makefile: reset to the original state and make sure that we don't pass CXXFLAGS on to the actual build process to not override the values generated by qmake. - Makefile: the only way to prevent variables on the command line to be passed down seems to be to remove them from MAKEOVERRIDES. .MAKEOVERRIDES is the FreeBSD-make-equivalent variable. MAKEFLAGS has no effect on this behavior, so removing it again. - Makefile: add comment explaining why we need to do this in the first place and why it's so complicated. - src/sshmasterconnection: ignore "garbage", but require at least one line to start with a known challenge auth prompt. Fixes: #966. - x2goclient.pro: add libssh_threads library. We need this since X2Go Client is multi-threaded. - copy-deps-win32.bat: also copy libssh_threads.dll to go with the previous change. - src/{onmainwindow,sshmasterconnection}.{cpp,h}: correctly initialize and finalize libssh. We ought to do both only once - in our main thread. Previously, we initialized libssh in a new thread, which might be problematic. - src/sessionexplorer.cpp: open the correct tab when editing a session from the exports menu. - src/onmainwindow.cpp: try to workaround window placement if settings contain a (newly) invalid position (e.g., a position that refers to a disconnected display.) - src/onmainwindow.cpp: try to find a display that can hold the window's position fetched from the sizes settings. Use the default if none could be found. - src/onmainwindow.cpp: fix up main window position check; use QRect.intersects (). - src/pulsemanager.{cpp,h}: rename shutdownState to shutdown_state_, reorder in initializer list. - res/i18n/: regenerate translations. - res/i18n/x2goclient_es.ts: fixup Spanish translation file. - res/i18n/x2goclient_et.ts: fixup some typos in the Estonian translation file. - res/i18n/x2goclient_sv.ts: add singular form to translation entry as discussed on list. - res/i18n/x2goclient_es.ts: add singular form to translation entry as discussed off list. - res/i18n/x2goclient_nl.ts: various fixups for Dutch translation file. - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway) translation file. - res/i18n/x2goclient_nl.ts: fix whitespace issues in Dutch translation file and re-add numerus form translation. - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway) translation file, including numerus form. - src/sshmasterconnection.cpp: for proxied connections, fetch the user name matching the given host, not proxy host. - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file. - res/i18n/x2goclient_fi.ts: another tiny whitespace fixup for Finnish translation file. - src/onmainwindow.cpp: fix "XMDCP" typo. - res/i18n/x2goclient_de.ts: various fixups for German translation file. - src/onmainwindow.cpp: fix "loose" vs. "lose" spelling mistake. - res/i18n/x2goclient_et.ts: remove obsolete and wrongly capitalized "x2go" part from an Estonian translation message. - res/i18n/x2goclient_sv.ts: minor whitespace fixup. - res/i18n/x2goclient_*.ts: apply "XMDCP" -> "XDMCP" fix manually to translation files. - res/i18n/x2goclient_nb_no.ts: remove obsolete comments (leading to problems when regenerating translation files.) - res/i18n/x2goclient_nl.ts: remove obsolete comments (leading to problems when regenerating translation files.) - res/i18n/x2goclient_*.ts: regenerate translations. - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file. - src/sshmasterconnection.cpp: spelling fix. (Quiting -> Quitting) - x2gobrowserplugin-2.4_1/src/qtbrowserplugin.cpp: spelling fix. (convertable -> convertible) * x2goclient.spec: - Respect %{optflags} and pass QMAKE_STRIP=: to fix missing debug info issues. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.0): - Interaction with SSH server (for example for changing expired password). Fixes: #592. - Fixing setting widget style issue in InteractionDialog on Windows client. - SSH Interaction for SSH Broker and SSH Server. - SSH Iteraction for method keyboard-interactive. - Move PulseManager MsgBox functions to main window: GUI functions should be used only from main thread. - Check "norecord" option on the first start of PulseAudio. - Disable/Enable PulseAudio in config dialog. New command line options: --disable-pulse to disable start of PulseAudio --disable-pulse-record to disable audio input. - Check if PulseAudio running at session start and resuming when sound is enabled. Show warning if PulseAudio not running and disable the sound support for the session to avoid session freezes. - Add session config file option "sshproxysamekey". With this option client will use for proxy authentication same key as for X2Go server. This is important in first case for broker users, where key can be generated "on the fly". Maybe it makes sence to add this option in UI and command line later. - Correct negative display coordinates for FS sessions. . [ Robert Parts ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_et.ts: update Estonian translation file. - res/i18n/x2goclient_et.ts: update Estonian translation file. . [ Martti Pitkänen ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_fi.ts: update Finnish translation file. - res/i18n/x2goclient_fi.ts: update Finnish translation file. - res/i18n/x2goclient_fi.ts: update Finnish translation file. . [ Mike DePaulo ] * New upstream version (4.1.1.0): - Windows: Upgrade PulseAudio from 6.0 to 7.1 Fixes: #1152 Issues with audio when playing HTML5 videos - Windows: Remove uninstaller from start menu. It is still available in "Programs and Features". - Windows: Upgrade Win32 OpenSSL from 1.0.1t to 1.0.2k Fixes numerous CVEs - Windows: Upgrade libssh from 0.7.0 to 0.7.4 (while maintaining Pageant support). The possibly relevant changes are: + CVE-2016-0739 was fixed + improved id_ed25519 support + numerous bug fixes - Windows: Update PuTTY from 0.67 to 0.68 The possibly relevant changes are: + CVE-2016-6167 was fixed (did not affect X2Go Client by default because the installation dir is not writeable by users) + CVE-2017-6542 was fixed - Don't override PATH for the actual session or application command. Fixes: #1100 . [ Walid Moghrabi ] * New upstream version (4.1.1.0): - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: let --background take a directory and randomly pick an SVG file in there. Fixes: #1165. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: pass-through broker credentials when connecting to a direct RDP session. Fixes: #1185. Adds a new --broker-use-creds-for-session parameter. - src/onmainwindow.cpp: support --close-disconnect for direct RDP sessions. Fixes: #1186. . [ Daniel Lindgren ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_sv.ts: update Swedish translation file. . [ Ricardo Díaz Martín ] * New upstream release (4.1.1.0): - res/i18n/x2goclient_es.ts: update Spanish translation file. . [ Jos Wolfkamp ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_nl.ts: update Dutch translation file. - res/i18n/x2goclient_nl.ts: update Dutch translation file. . [ Klaus Ade Johnstad ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file. - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file. . [ Stefan Baur ] * New upstream release (4.1.1.0): - res/i18n/x2goclient_de.ts: update German translation file. . [ Sébastien Ducoulombier ] * New upstream version (4.1.1.0): - res/i18n/x2goclient_fr.ts: update French translation file. ------------=_1509263412-25193-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 15 Nov 2016 13:31:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: * X-Spam-Status: No, score=1.2 required=3.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 7F86C3CBB6 for ; Tue, 15 Nov 2016 14:31:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nfyD5ZR-JWfF for ; Tue, 15 Nov 2016 14:31:34 +0100 (CET) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.161.171]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A82593CBB5 for ; Tue, 15 Nov 2016 14:31:33 +0100 (CET) Received: by mail-yw0-f171.google.com with SMTP id r204so94184521ywb.0 for ; Tue, 15 Nov 2016 05:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=BsAOMIqe/RWhjvtyEc2l62Jxy03fZ1Ir1i9C8LQCe2A=; b=EKoGY+JhEsNNpLKH+XfmwnZ2oGVLbcIpTPPJ/qsk17uugEeQSfrj3uILHtlzGqsKHS oc7P8lQMa8iTaZjByPFTmuFpj6p7LvmXT/VDy1LtHLIgdraJoItnTECdOvhPm8nHRpm5 Q+M0Lh5VshwiTjpTZV3CaUy7NDBbCYnt+zVsyXf2Axwv32yt0BbbvJMgwYhVxsKopjFe /BA/uWPXVhZMhDmVNu96R0M5fZqU0yv7fC2teXbXiwGd+YfIYVYdoq8+GvMrJ7du4Ule egV1VULvXAHENl7Qb1IB6aKKUDdUK4jBtpsPegtSJeiXGwE3tOnnffY9OZmP/uZsclnw TkWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=BsAOMIqe/RWhjvtyEc2l62Jxy03fZ1Ir1i9C8LQCe2A=; b=bwEiYpIfyq9k8URYE9exsCIxS9qt0mBhjzklqyZuZLt9ugPF5L2BhDW7N7hJMoTDHs ms3662E2jGOl+JoHgWWjgK2b8EAq17AuEysB4vTDVbKG8L2LnGCiD0Ry4xNwE6yAbgeC jh+A4pkTfbmGO/PafTI24vRW6yZ4mDORO8JkRGZ2aYrJiTl5J/0ObW2f3RZy8CDqgBSD MbeSuDoRVczBvbXpLi5iliFd6hLJwB9j5UEmq9fHOKBdXMJlPqj/pdjM5R6ZuwPl/35n eNBBPHEQcTusR5C2qKHl9kJU+pmz9aliSx8PTIMTIm6TPjoelK2a4hwX4eVtI57rdVks hRpQ== X-Gm-Message-State: ABUngveF0090i7RcgYnWZt1ko2OcxJfvc3l9Zt8Hrlq3XWushcW2UJmGioc2MeeLs/fTQA== X-Received: by 10.129.71.8 with SMTP id u8mr22593678ywa.115.1479216692289; Tue, 15 Nov 2016 05:31:32 -0800 (PST) Received: from [192.168.1.100] ([24.49.13.30]) by smtp.gmail.com with ESMTPSA id d69sm10166654ywh.1.2016.11.15.05.31.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2016 05:31:31 -0800 (PST) To: submit@bugs.x2go.org From: Antonio Russo Subject: segfault on missing ssh-key Message-ID: <20b7866a-787d-5ebd-7ad0-5e30f496730e@gmail.com> Date: Tue, 15 Nov 2016 08:31:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.5.2 (though, presumably, all versions should be affected) On line 1100 of src/sshmasterconnection.cpp, consider the line: > ssh_private_key prkey=privatekey_from_file(my_ssh_session, keyName.toLatin1(), 0,""); If keyName.toLatin1() is not an existing file, you'll get an invalid pointer free. This might be a bug in libssh, but it took me an embarrassingly long time to figure out what was wrong, so others might be similarly confused. Thanks ------------=_1509263412-25193-1-- From unknown Thu Mar 28 21:30:46 2024 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@bugs.x2go.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Bug archived. Date: Mon, 27 Nov 2017 06:24:02 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # Bug archived. thanks # This fakemail brought to you by your local debbugs # administrator