From unknown Thu Mar 28 10:09:36 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#684: [X2Go-Dev] Bug#684: select_session offers offline servers to X2Go Client Reply-To: Mike Gabriel , 684@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sat, 06 Dec 2014 23:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 684 X-X2Go-PR-Package: python-x2gobroker X-X2Go-PR-Keywords: Received: via spool by 684-submit@bugs.x2go.org id=B684.14179065695851 (code B ref 684); Sat, 06 Dec 2014 23:00:02 +0000 Received: (at 684) by bugs.x2go.org; 6 Dec 2014 22:56:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 7AA1E5E0E0 for <684@bugs.x2go.org>; Sat, 6 Dec 2014 23:56:07 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 06E87E26; Sat, 6 Dec 2014 23:56:07 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 707873BDE2; Sat, 6 Dec 2014 23:56:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yB4i5TlKWPGa; Sat, 6 Dec 2014 23:56:06 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 93A503BD2D; Sat, 6 Dec 2014 23:56:05 +0100 (CET) Received: from p50815251.dip0.t-ipconnect.de (p50815251.dip0.t-ipconnect.de [80.129.82.81]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Sat, 06 Dec 2014 22:56:05 +0000 Date: Sat, 06 Dec 2014 22:56:05 +0000 Message-ID: <20141206225605.Horde.h0QDOmvCPLZG5RzMvTt6XA3@mail.das-netzwerkteam.de> From: Mike Gabriel To: Sergey Savko , 684@bugs.x2go.org References: <143861477.96320.1417796055431.JavaMail.zimbra@tophouse.ru> <1123477056.96337.1417796091693.JavaMail.zimbra@tophouse.ru> In-Reply-To: <1123477056.96337.1417796091693.JavaMail.zimbra@tophouse.ru> User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 80.129.82.81 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_Oy8JzmEkPC0b2OV3XAc9SQ1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_Oy8JzmEkPC0b2OV3XAc9SQ1 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: clone -1 -2 -3 Control: reassign -2 x2goclient Control: reassign -3 python-x2go Control: retitle -1 add exclude-hosts parameter to selectsession task Control: retitle -2 request another server from broker provided server is d= own Control: retitle -3 request another server from broker provided server is d= own Control: severity -1 wishlist Control: severity -2 wishlist Control: severity -3 wishlist Control: block -2 by -1 Control: block -3 by -1 Control: tag -1 - patch Hi Sergey, On Fr 05 Dez 2014 17:14:51 CET, Sergey Savko wrote: > This patch work after patch from=20=20 >=20http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D686 After thinking this through a little, I come to the conclusion that=20=20 the=20broker cannot decide if a machine is down or not. We have to think very generically. There may be a scenario where the=20=20 broker=20machine may be on an network segment where it cannot ping/reach=20= =20 the=20X2Go Servers. The X2Go Clients can reach the X2Go Broker. The broker provides an=20=20 X2Go=20Server address on the "selectsession" broker task to the X2Go=20=20 Client.=20Then the X2Go Client should test if that X2Go Server address=20= =20 works=20(via a simple ping6/ping command, machines should always be=20=20 pingable!!!).=20If the ping fails, X2Go Client should go back to the=20=20 broker=20and say: hey, that server failed for me, give me another one=20=20 (but=20not the one you already gave me). I fear we need to do four things for this bug to get fixed: 1. extend broker/client communication protocol (second/third/...=20=20 selectsession =20 call with a list of hosts that did not work on previous attempts) 2. extend X2Go Session Broker with an exclude-hosts (or so)=20=20 parameter=20for the selectsession task 3. Adapt X2Go Client: ping X2Go Server, go back to the broker if=20=20 server=20is down and request another server 4. Adapt Python X2Go: dito Regards, Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_Oy8JzmEkPC0b2OV3XAc9SQ1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUg4mFAAoJEJr0azAldxsxG/4P/RJwSiJZdCylF4cCn8H4q00G A7lAI45oXOu0WUiScExm3CowcJrGYGocerJplZW6UpSIljwfvgF4xiFaz1zLhQ2n hYLQWXF+OSPt2xQyzmdv7BRlF5X3WD5Y/6hNMfri+SWtnO/9W0QxSyOOga07jPDx th/dlCS4T2c+QfOMtqFbJxHNJTxHWxT6zJlnWK2jNGkQVHDYaRP2qlPdFaQFtSla ITdTi1SJk03js//+gWCTXJTmZi1bwW3YfdDVEA2bYIcanyJX8/TYsSzGqykPYVcg v5y3BqlV51JrZAT6DvTU7pEade7QOwrT2lEUnbPsUzZqGb8Lcmu1oPYtcdZbn3Rd QaRjBiZh2AgxiROCYcOLBIHr1OjU5mb1Nrr9pvMQ+JM5A+/w+bVJ0oWG6ZoGbGd6 KSl8VMNst+M6mXu/VOhiOHOJu9WUpG9XoROG6bNhqQHzMLMBpFsza6joe+G7NrlJ hPU1lE3w7xkyLMkuTazGU1emItGvpI2Q39jAO+eFwYTaknuVP3xVhv+CFAsrwEdb n1WI4HGspiW1Gh9gf8kiLXsvDwX3KlxBRyq9ZuKhIE/xVpo7n2ZsSvJ9++JDI7/G QwLcp39KhNPMKsOws2EC9Nd6psqWYfLCAnWCj22wyP/NY5WRqNXFsqi8WimuAGwm 2clI4zeiu6eO4b4cwwi2 =6UhK -----END PGP SIGNATURE----- --=_Oy8JzmEkPC0b2OV3XAc9SQ1--