From unknown Fri Mar 29 12:12:35 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#490 closed by Mike Gabriel (X2Go issue (in src:nx-libs) has been marked as closed) Message-ID: References: <20140630122435.2BA9A5DB56@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending patch X-X2go-PR-Message: they-closed 490 X-X2go-PR-Package: nx-libs Date: Mon, 30 Jun 2014 12:25:12 +0000 Content-Type: multipart/mixed; boundary="----------=_1404131112-4601-0" This is a multi-part message in MIME format... ------------=_1404131112-4601-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the nx-libs package: #490: Attempt at aarch64 support It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1404131112-4601-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 30 Jun 2014 12:24:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RELAYS autolearn=unavailable version=3.3.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 2BA9A5DB56; Mon, 30 Jun 2014 14:24:34 +0200 (CEST) From: Mike Gabriel To: 490-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 490@bugs.x2go.org Subject: X2Go issue (in src:nx-libs) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20140630122435.2BA9A5DB56@ymir.das-netzwerkteam.de> Date: Mon, 30 Jun 2014 14:24:34 +0200 (CEST) close #490 thanks Hello, we are very hopeful that X2Go issue #490 reported by you has been resolved in the new release (2:3.5.0.25) of the X2Go source project »src:nx-libs«. You can view the complete changelog entry of src:nx-libs (2:3.5.0.25) below, and you can use the following link to view all the code changes between this and the last release of src:nx-libs. http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=be23e057f28a6624380a91d1ba36cbf5df6c3fff;hp=460a3cb3911bbfb717d0259947fe05f68d964948 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:nx-libs. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:nx-libs Version: 2:3.5.0.25-0x2go1 Status: RELEASE Date: Mon, 30 Jun 2014 14:05:46 +0200 Fixes: 40 339 490 504 505 515 516 Changes: nx-libs (2:3.5.0.25-0x2go1) RELEASED; urgency=low . [ Mihai Moldovan ] * Add 029_nxcomp_ppc64.full+lite.patch. Fix sockaddr handling on Big Endian systems (like PPC64). (Fixes: #515). * Add 057_nx-X11_sanitize-eventmasks.full.patch. Fix failures in session windows coming up on Big Endian systems like PPC64. (Fixes: #516). * Improve 105_nxagent_export-remote-keyboard-config.full.patch. Don't print out nonsensical information, if there really was no error when creating the keyboard file or the other way around. Also add the reason when failing to create the keyboard file. Only print an error message if SessionPath *really* is not defined. * Improve 028_nx-X11_abstract-kernel-sockets.full.patch. Make it more Big Endian robust by assigning correct types for socklen_t objects. * Add 990_fix-DEBUG-and-TEST-builds.full.patch. Fix debug builds (e.g. when globally setting -DDEBUG and -DTEST at build time). . [ Nito Martínez ] * Add 212_nxcomp_build-on-Android.patch. Fix FTBFS of nxproxy/nxcomp when build against the Android system. (Fixes: #339). . [ Oleksandr Shneyder ] * Add 210_nxagent_nxcomp_save_session_state.full+lite.patch. Save session state in path specified by "state" option in agent options file. If option is omitted, session state will not be saved. Session states are: STARTING, RUNNING, SUSPENDING, SUSPENDED, RESUMING, TERMINATING, TERMINATED. * Add 211_nxcomp_set_default_options.full+lite.patch. Set default arguments for options 'link' and 'pack' to avoid session damage by resuming with incorrect options file. . [ Mike Gabriel ] * Add 606_nx-X11_build-on-aarch64.full.patch. Build on aarch64 architectures. (Fixes: #490). * Add 027_nxcomp_abstract-X11-socket.full+lite.patch. In proxy mode "server" let NX proxy attempt connecting to the abstract X11 socket first, and only fallback to the file system socket, if the abstract socket is not available. (Fixes: #505). * Add 028_nx-X11_abstract-kernel-sockets.full.patch. Provide abstract local socket support for Linux based systems. This patch pulls in abstract socket relevant code from xtrans 1.2.7. (Fixes: #504). * Add 302_nx-X11_xkbbasedir-detection.patch. For detecting XkbBaseDir test for xkb/rules/base instead of testing for deprecated file xkb/keymap.dir. (Fixes: #40). * Add 206_nxagent_clipboard-as-nxoption.full.patch. Make the clipboard option configurable in nxagent via NX options as addition to the command line parameter -clipboard. Note that the command line parameter overrides the clipboard NX option. Possible values are both or 1, client, server, none or 0. . * Update patches, to make them apply cleanly after above changes: + 220_nxproxy-bind-loopback-only.full+lite.patch + 016_nx-X11_install-location.debian.patch + 056_nx-X11-Werror-format-security.full.patch + 108_nxagent_wine-close-delay.full.patch + 300_nxagent_set-wm-class.full.patch + 320_nxagent_configurable-keystrokes.full.patch . * Rename patches to match our naming scheme: + 008_nxcomp_sa-restorer.full+lite.patch + 009_nxagent_add-man-page.full.patch + 009_nxproxy_add-man-page.full+lite.patch + 056_nx-X11_Werror-format-security.full.patch + 209_x2goagent_add-man-page.full.patch + 220_nxproxy_bind-loopback-only.full+lite.patch ------------=_1404131112-4601-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 8 May 2014 02:43:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E3D8A5DB15 for ; Thu, 8 May 2014 04:43:40 +0200 (CEST) Received: from pacas.cora.nwra.com (63-228-76-253.hlrn.qwest.net [63.228.76.253]) (authenticated bits=0) by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id s482hZ5h008099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 7 May 2014 20:43:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com; s=default; t=1399517018; bh=9Xu0au+tIb0ndDKPpywF0eZxr3OHeaQ/07qrKPu2fU8=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=S5+DmGWFKxdZLk/tXv1JCxCSSokDVca4xZqWB3rw9gtZyhGIxT0Pc740LZPWKVjt3 b1jktbbTWd9SnC7WUvqzPxuCUqUSAKKd1xGvoUBYOodAowh5XsNICudYGc/Ho3hbaz HLsRP3Znl/rU6gVujFEibz1MIgTzi3PHQVMXAksk= Message-ID: <536AEF57.7050606@cora.nwra.com> Date: Wed, 07 May 2014 20:43:35 -0600 From: Orion Poplawski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Attempt at aarch64 support X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------070509000109070701020102" This is a multi-part message in MIME format. --------------070509000109070701020102 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Package: nx-libs Version: 3.5.0.24 Tags: patch This is quick hack attempt at aarch64 support. It allows nx-libs to compile, but I have nothing to test on and I suspect it may be incorrect, but it's a start. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane orion@cora.nwra.com Boulder, CO 80301 http://www.cora.nwra.com --------------070509000109070701020102 Content-Type: text/x-patch; name="nx-libs-aarch64.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nx-libs-aarch64.patch" diff -up nx-libs-3.5.0.24/nx-X11/config/cf/Imake.cf.aarch64 nx-libs-3.5.0.24/nx-X11/config/cf/Imake.cf --- nx-libs-3.5.0.24/nx-X11/config/cf/Imake.cf.aarch64 2014-05-07 01:56:12.000000000 -0600 +++ nx-libs-3.5.0.24/nx-X11/config/cf/Imake.cf 2014-05-07 19:27:07.748795509 -0600 @@ -908,6 +908,9 @@ XCOMM Keep cpp from replacing path eleme # endif # undef __ARMEB__ # endif +# ifdef __aarch64__ +# define Arm64Architecture +# endif # ifdef mc68000 # define Mc68020Architecture # undef mc68000 diff -up nx-libs-3.5.0.24/nx-X11/config/cf/linux.cf.aarch64 nx-libs-3.5.0.24/nx-X11/config/cf/linux.cf --- nx-libs-3.5.0.24/nx-X11/config/cf/linux.cf.aarch64 2014-05-07 02:00:04.000000000 -0600 +++ nx-libs-3.5.0.24/nx-X11/config/cf/linux.cf 2014-05-07 19:28:17.823777953 -0600 @@ -844,6 +844,16 @@ InstallNamedTargetNoClobber(install,file # define ServerExtraDefines -DGCCUSESGAS XFree86ServerDefines #endif /* Arm32Achitecture */ +#ifdef Arm64Architecture +# define DefaultCCOptions +# ifndef OptimizedCDebugFlags +# define OptimizedCDebugFlags -O3 +# endif +# define LinuxMachineDefines -D__aarch64__ -U__arm -Uarm +# define ServerOSDefines XFree86ServerOSDefines -DDDXTIME +# define ServerExtraDefines -DGCCUSESGAS XFree86ServerDefines +#endif /* Arm64Achitecture */ + #ifdef HPArchitecture # define OptimizedCDebugFlags -O2 GccAliasingArgs # define LinuxMachineDefines -D__hppa__ diff -up nx-libs-3.5.0.24/nx-X11/config/cf/Imake.tmpl.aarch64 nx-libs-3.5.0.24/nx-X11/config/cf/Imake.tmpl --- nx-libs-3.5.0.24/nx-X11/config/cf/Imake.tmpl.aarch64 2014-05-07 02:00:04.000000000 -0600 +++ nx-libs-3.5.0.24/nx-X11/config/cf/Imake.tmpl 2014-05-07 19:59:05.266769630 -0600 @@ -526,6 +526,10 @@ XCOMM the platform-specific parameters - #define ByteOrder X_BIG_ENDIAN #elif defined(Arm32Architecture) #define ByteOrder X_LITTLE_ENDIAN +#elif defined(Arm64ebArchitecture) +#define ByteOrder X_BIG_ENDIAN +#elif defined(Arm64Architecture) +#define ByteOrder X_LITTLE_ENDIAN #elif defined(RsArchitecture) #define ByteOrder X_BIG_ENDIAN #elif defined(PpcArchitecture) || defined(Ppc64Architecture) diff -up nx-libs-3.5.0.24/nx-X11/programs/Xserver/include/servermd.h.aarch64 nx-libs-3.5.0.24/nx-X11/programs/Xserver/include/servermd.h --- nx-libs-3.5.0.24/nx-X11/programs/Xserver/include/servermd.h.aarch64 2014-05-07 01:56:12.000000000 -0600 +++ nx-libs-3.5.0.24/nx-X11/programs/Xserver/include/servermd.h 2014-05-07 19:55:11.760395141 -0600 @@ -154,6 +154,28 @@ SOFTWARE. #endif /* __arm32__ */ +#ifdef __aarch64__ + +#ifdef __AARCH64EL__ +#define IMAGE_BYTE_ORDER LSBFirst +#define BITMAP_BIT_ORDER LSBFirst +#endif +#ifdef __AARCH64EB__ +#define IMAGE_BYTE_ORDER MSBFirst +#define BITMAP_BIT_ORDER MSBFirst +#endif + +# if defined(XF86MONOVGA) || defined(XF86VGA16) +# define BITMAP_SCANLINE_UNIT 8 +# endif + +#define GLYPHPADBYTES 4 +#define GETLEFTBITS_ALIGNMENT 1 +#define LARGE_INSTRUCTION_CACHE +#define AVOID_MEMORY_READ + +#endif /* __aarch64__ */ + #if defined (hpux) || defined __hppa__ #define IMAGE_BYTE_ORDER MSBFirst --------------070509000109070701020102-- ------------=_1404131112-4601-0--