From unknown Thu Mar 28 14:41:25 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#200: [X2Go-Dev] Bug#200: When user-directories do not exist, saving sqlpass with x2godbadmin is not possible Reply-To: Nable 80 , 200@bugs.x2go.org Resent-From: Nable 80 Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 07 May 2013 19:48:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 200 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by 200-submit@bugs.x2go.org id=B200.136795607811266 (code B ref 200); Tue, 07 May 2013 19:48:02 +0000 Received: (at 200) by bugs.x2go.org; 7 May 2013 19:47:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-bk0-f50.google.com (mail-bk0-f50.google.com [209.85.214.50]) by ymir (Postfix) with ESMTPS id 3EC965DB18 for <200@bugs.x2go.org>; Tue, 7 May 2013 21:47:58 +0200 (CEST) Received: by mail-bk0-f50.google.com with SMTP id ik5so499168bkc.9 for <200@bugs.x2go.org>; Tue, 07 May 2013 12:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=osHv6NqAPhjFTT3u+5vTRQsNRoVdgCvKJAeNIKU+61c=; b=p3ieyWHEK6bKATSOmJXnZlkLHlMFfWgyV2OmuWlDG+gMnKFk6oo8NV2168UZt9lZvp MJ3TzttTyZxsFVpHc8DeP09I5OFSrwf5uouXIHO7Yk8f9/ha8tcpXoQj9+fKC08CEZ2t x+GVj+AIAEK1ywgIs8tJpgKnh5uKaS8IxwnotrkyHasQAeAUqngpco+WpTledBz7Q4w6 14zaRH3/ClI3o6pJftLAKtgLJoqs0acb3rDvEw/w0M+fn4Iwxj6dYcb2boYYftkj3XvP fq6MOO8tgMkehJBhy5F4+jVwfSqg+AunpiCTgNNvW33ubnI0yPyJkvmR/96kfC3k/I1Q XJnQ== MIME-Version: 1.0 X-Received: by 10.205.65.81 with SMTP id xl17mr1009971bkb.54.1367956077881; Tue, 07 May 2013 12:47:57 -0700 (PDT) Received: by 10.204.170.208 with HTTP; Tue, 7 May 2013 12:47:57 -0700 (PDT) In-Reply-To: References: Date: Tue, 7 May 2013 23:47:57 +0400 Message-ID: From: Nable 80 To: Michael Kromer , 200@bugs.x2go.org, x2go-dev@lists.berlios.de Content-Type: text/plain; charset=ISO-8859-1 Hi, Michael. > system("mkdir -p $dir/.x2go"); Are you sure that nothing will break if `$dir' contains space or some other special^W sensitive characters? Of course, i understand that using such characters in homedir path is a really bad idea but.. i think apps must be secure by design. And second thing: > and is deeper than /home/$USER I think that this comment is wrong. As I understand, it doesn't matter how deep dir, what matters is whether user's homedir exits or not. And if I've understood correctly (manual page for x2godbadmin is too short, although comments in the program are rather good) x2godbadmin doesn't create users, it only manages DB and creates ~/.x2go/ part if it's missing. So, if user is present in system (getpwnam returns info about existing users) but his homedir is missing I think that it's better to issue some warning instead of silent homedir creation (at least because this homedir won't contain files from /etc/skel, especially ~/.profile and ~/.bashrc).