From unknown Fri Mar 29 03:05:53 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1277: fix default keyboard shortcut of viewport_move_left Reply-To: =?UTF-8?Q?Ren=C3=A9?= Genz , 1277@bugs.x2go.org Resent-From: =?UTF-8?Q?Ren=C3=A9?= Genz Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 21 Mar 2018 23:50:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1277 X-X2Go-PR-Package: x2goagent X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.152167603124857 (code B); Wed, 21 Mar 2018 23:50:01 +0000 Received: (at submit) by bugs.x2go.org; 21 Mar 2018 23:47:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_40,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3C48F5DAE9 for ; Thu, 22 Mar 2018 00:47:08 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id byAGEtPpfIEZ for ; Thu, 22 Mar 2018 00:47:03 +0100 (CET) X-Greylist: delayed 306 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Thu, 22 Mar 2018 00:47:03 CET Received: from mout0.freenet.de (mout0.freenet.de [IPv6:2001:748:100:40::2:2]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 82CA95DAC9 for ; Thu, 22 Mar 2018 00:47:03 +0100 (CET) Received: from [195.4.92.141] (helo=mjail1.freenet.de) by mout0.freenet.de with esmtpa (ID liebundartig@freenet.de) (port 25) (Exim 4.90_1 #2) id 1eynMi-0002cl-Rj for submit@bugs.x2go.org; Thu, 22 Mar 2018 00:41:56 +0100 Received: from [::1] (port=39546 helo=mjail1.freenet.de) by mjail1.freenet.de with esmtpa (ID liebundartig@freenet.de) (Exim 4.90_1 #2) id 1eynMi-0002vc-KL for submit@bugs.x2go.org; Thu, 22 Mar 2018 00:41:56 +0100 Received: from mx18.freenet.de ([195.4.92.28]:49668) by mjail1.freenet.de with esmtpa (ID liebundartig@freenet.de) (Exim 4.90_1 #2) id 1eynKk-0002A3-Ch for submit@bugs.x2go.org; Thu, 22 Mar 2018 00:39:54 +0100 Received: from p200300d3c3d79b40160f8052b4bfce2b.dip0.t-ipconnect.de ([2003:d3:c3d7:9b40:160f:8052:b4bf:ce2b]:58616) by mx18.freenet.de with esmtpsa (ID liebundartig@freenet.de) (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (port 465) (Exim 4.90_1 #2) id 1eynKk-0005Ar-5r for submit@bugs.x2go.org; Thu, 22 Mar 2018 00:39:54 +0100 To: submit@bugs.x2go.org From: =?UTF-8?Q?Ren=C3=A9?= Genz Message-ID: <71df3dd3-cd84-e529-f0b8-a3f8cc31730d@freenet.de> Date: Thu, 22 Mar 2018 00:37:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Icedove/52.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4F32538238BD04250EC3B6CF" Content-Language: en-US X-Originated-At: 2003:d3:c3d7:9b40:160f:8052:b4bf:ce2b!58616 This is a multi-part message in MIME format. --------------4F32538238BD04250EC3B6CF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Package: x2goagent Version: 3.5.0.33 Tag: patch The viewport keyboard shortcuts are bound to: * Ctrl+Alt+arrow keys for up, right, down * Ctrl+Shift+Alt+arrow keys for left This patch removes the '+Shift' for moving left. Hence, all viewport movement shortcuts use the same set of keys. I guess the '+Shift' was a copy-paste error. I dare not to open dedicated bug reports for these minor problems: On the website: https://wiki.x2go.org/doku.php/wiki:advanced:nx-keyboard-shortcuts please, rename the file: keystroke.cfg to: keystrokes.cfg For the bug submission I noticed on the website: https://wiki.x2go.org/doku.php/wiki:development:join-the-team you can read: Whenever you find a bug, an improvement, try to fix it, try to implement it. what you come up with → Send it as a patch to the developers' mailing list for reviewing. Maybe this should be updated because on the website: https://wiki.x2go.org/doku.php/wiki:development:git in the paragraph: Sending in Patches you can read: ... For submitting X2Go patches, please use the X2Go Bug Tracker System. Attachment: fix-viewport_move_left-shortcut.diff -- Kind regards, René --------------4F32538238BD04250EC3B6CF Content-Type: text/x-patch; name="fix-viewport_move_left-shortcut.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-viewport_move_left-shortcut.diff" diff --git a/etc/keystrokes.cfg b/etc/keystrokes.cfg index 007a182..13c286a 100644 --- a/etc/keystrokes.cfg +++ b/etc/keystrokes.cfg @@ -12,7 +12,7 @@ - + --------------4F32538238BD04250EC3B6CF--