From X2Go-ML-1@baur-itcs.de Sat Jan 14 13:59:51 2017 Received: (at submit) by bugs.x2go.org; 14 Jan 2017 12:59:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 787E73CDDE for ; Sat, 14 Jan 2017 13:59:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JXn9T6p4JKxH for ; Sat, 14 Jan 2017 13:59:32 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 784753CDDD for ; Sat, 14 Jan 2017 13:59:32 +0100 (CET) Received: from [192.168.0.23] ([78.43.90.159]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPSA (Nemesis) id 0Lgpjq-1cp51v28NK-00oEIh; Sat, 14 Jan 2017 13:54:29 +0100 To: submit@bugs.x2go.org Cc: Oleksandr Shneyder , Mike Gabriel From: Stefan Baur Subject: Multiple issues with x2gousbmount Message-ID: Date: Sat, 14 Jan 2017 13:54:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx" X-Provags-ID: V03:K0:o2jxPZKN6wDxEUcWz4AKXnAOjV4yQ7Fvr9obSWSqoGEkN5fKXcS 46HAj5kIx0wGAlXuhlQP43uxSCVYcEfLj5xVXEy7W1vffSzGVQvNofG9uKoL4lBpEC1DZUJ uPKJeI3PB2qYPapoRMCw5wUpuNB+RXL/b88z8hjsa+kDE4UD5XHY65nG5ttkhrX5ied8KUt dQn7P5RbHvyuikWO7cgDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:EkxQqP7FTzo=:gqWe6k2/J2/DMX5HnZi75W oNQHidZ/IEWxSJdNPKMt9CVevb5NFPb6AHgekvLoINrqADXbkMqcp3uctDneXa2GKAO7x/Vb4 YTPOZtUy6uMScHbgmA7gDylUNxGdf7nvlRFlpclipjq/o7ukv8FJtsAsgYjpO82f2npVg9oQK rgalOCwcUaCWRhtFf4nVSkNRjYC14w1A15kZ5j9IPffupFM7SpvW4/4ZBAN1t2/vIdXdbz8KP s2KFd/dEV8wHY9JgqZMalZOFWd8d57ftJFhkNmsLKOeW7ioWQTYBCsOa1f/UfIGAMShSDWIE+ yIwv5+xHO0dLKs7Xgw3ea5jZbeZmrYj2mi+CeMPTYX2k3QQqYBcK0ZA20nI5o3GQE+jtqq3RN oeqLZoY3l2BTTonFUpIr+JdYECfFLRpNcxeXxWBe6gAxE6WnOeOhGgqXbTxDe2wdbaEvh/MYS 30OAPG3ts03+x1DbtJnPz+cc0Z3FbwibV/bchHCUUAFgIWRIcXIE2A8S0hquOBGeOg0tQrNpM qv/El8kE91EDPY2RezUagQQpgkpwzYThlyZyz1XCbF53r3LeUM144GvIibToWZi3RsLh+XPCx gaZnFKYvc3ZZFu0d43Pf1eBWrJoQXAkulbQ12HChWJ4ujkc2T5pi1j0LjvfLZJS+sei/4mN7t UEWXBYEdK+4eMesvVesGeFRUWG6qDlG4Zns4TdUMTrPYohUyMa2osE0acVROKkozDmLA= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx Content-Type: multipart/mixed; boundary="F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC"; protected-headers="v1" From: Stefan Baur To: submit@bugs.x2go.org Cc: Oleksandr Shneyder , Mike Gabriel Message-ID: Subject: Multiple issues with x2gousbmount --F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable package: x2gousbmount Hi $LIST, hi Alex, hi Mike#1, due to a recent bug report on X2Go-User, I needed to take a closer look at the x2gousbmount package, and the script /usr/lib/x2go/tce/x2gousbmount in it. I'll be referencing http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dblob;f=3Dusbmount/= x2gousbmount;h=3D4da1fbd90b14dda1beb230ea4b08441a77d9e4eb;hb=3D75211b6e72= 4bd896d85d915c754703cabcf37187 for line numbers below, even though that version is more advanced as the one in the stable x2gousbmount package. I'm hoping that Alex or someone else that has a clue wrt/ Perl and this script can shed some light on these issues. Mike#1, you're in CC due to issue #3, which seems to have been introduced in your commit. Feel free to suggest I should turn every issue into a separate bug report - I'm not filing them separately at the moment because the issues seem all more or less interconnected, so I figured I should start with one bug report for "the big picture". Issue #1: Lines 88 and 138 contain a call ... expand_filename("~x2gothinclient ... Now, I understand that this is an attempt to determine the path to the home directory of the user named "x2gothinclient". Which, in the classic X2Go-TCE, is "/var/lib/x2gothinclient". So far, so good. But: Lines 107 and 148 contain what looks to me like a subtle typo: ... expand_filename("~/x2gothinclient ... Which means, instead of selecting the home directory of the user x2gothinclient, it would go to the home directory of the user under which the script is being executed, and a subdirectory "x2gothinclient" there, so most likely /root/x2gothinclient (which doesn't exist) So the script will probably fail whenever it encounters encrypted volumes= =2E (I can't test this myself, I don't have a setup with encrypted USB media.= ) Issue #2: The user name "x2gothinclient" is hardcoded in several places inside the script. This calls at least for a "my $user=3D'x2gothinclient';" at the beginning= of the script, and the replacement of every occurrence of "x2gothinclient" with "$user". The reason being that TCE-Live uses a different user name, namely "user" (and a different home directory, /home/user), so we need to be able to swap out the name in one central location. There are two ways of determining that we're running in TCE-Live, I am not sure which one would be the preferable one: 1) Checking /proc/cmdline for the appearance of (in regex syntax) "\W*live\W*" or "\W*boot=3Dlive\W*" (in case your mail software turns asterisks into bold type, there's an asterisk after each capital W). 2) Checking if the directory /lib/live or /lib/live/config exists. If any of these match, then $user should be set to 'user' instead of 'x2gothinclient'. Issue #3: Comparing the master branch in git with the version in stable, line 37 is different. There now is an additional check for the existence of a directory "/usr/share/doc/x2gothinclient-minidesktop". Which script/package creates this directory and why is it equivalent to detecting a running x2gothinclientd? Looks like http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 introduced that change, see http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 but there's no meaningful commit message. Mike#1? Issue #4: I am unhappy with the subroutine check_x2gothinclientd. Indeed, grepping for substrings so you don't trigger on the parameters of your own grep command in the output of ps is a neat hack, but a hack remains a hack. The clean way of handling this, IMO, would be to change the subroutine as follows: sub check_x2gothinclientmode { # check if X2GoClient is running in thinclient mode # old code would check if x2gothinclientd was running, # which fails on X2Go-TCE-live my $x=3D`ps u -C x2goclient`; if ( $x=3D~m/\W*--thinclient\W*/ ) { return 1; } return 0; } This will no longer detect if x2gothinclientd is running, but if x2goclient has been called with parameter --thinclient. Which should be the case in both TCE-Classic and TCE-Live. Due to the name change of the subroutine, line 37 needs to be changed to use check_x2gothinclientmode instead of check_x2gothinclientd. Maybe the changed check means the || - part in line 37 is no longer needed as well? Issue #5: Lines 88 and 138 silently assume that there is a subdirectory "export". I can't see it being created anywhere, though. Same goes for lines 107 and 148 and the subdirectory "logins". Issue #6: Why do we need two separate subdirectories "export" and "logins", anyways= ? Issue #7: Somewhere around line 48, I'm missing a comment that explains what this part of the code is for. I would suggest adding: # mntdir is not the directory where the mountpoint will be rooted, # but where tracking of mount states takes place Issue #8: Why do we have to track these mountpoints manually, anyways? Is the information in /proc/mounts insufficient? -Stefan --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC-- --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYeh97AAoJEG7d9BjNvlEZNE4IAKzB5ZKpxZObcz3u8f4a8gBp ZpE/kQTGCtltYjcDHt7Embg1KQU7F+lTWO1MiaykNLsQguuAagtV+X5bwT+hC2Mt lBJKRXW2dBzNnYqldkGsvyp3+SopqMNMCV6rEKaBpFANxj2pnz72aW7aZwMPtHRq X7VxQUvWcDxvpaBOE9aTzkKqhijk4lHk7OpQj503iLYYSNRFXE14zl2mix1e/WfO s/ie8/Z3s8vvqB94/yjXI2M482Sv+3JvtbmedCd22Ee88nxvoT0TBa5tJWKeLcCF /DqEN4psm2J+l+/Oqh4/Z5HM1sWSy5IvKqFVCYatnbBVzy5i7t35O3s2R09pEO0= =M4U2 -----END PGP SIGNATURE----- --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx-- From mike.gabriel@das-netzwerkteam.de Mon Jan 16 16:35:55 2017 Received: (at 1136) by bugs.x2go.org; 16 Jan 2017 15:35:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 9B04D3CDDE for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:35:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vxee4kq7DDF0 for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:35:48 +0100 (CET) Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 566BA3CDDD for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:35:48 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:131:20c1:5254:ff:fe24:f0dd]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E29BB5E; Mon, 16 Jan 2017 16:35:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 392D83BD53; Mon, 16 Jan 2017 16:35:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mqHZ4iCVYk3B; Mon, 16 Jan 2017 16:35:22 +0100 (CET) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id E5D443BBAB; Mon, 16 Jan 2017 16:35:21 +0100 (CET) Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 16 Jan 2017 15:35:21 +0000 Date: Mon, 16 Jan 2017 15:35:21 +0000 Message-ID: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> From: Mike Gabriel To: Stefan Baur , 1136@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#1136: Multiple issues with x2gousbmount In-Reply-To: User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 178.62.101.154 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Content-Type: multipart/signed; boundary="=_wO6Uu425wNjJvI6C9UfdIxp"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_wO6Uu425wNjJvI6C9UfdIxp Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stefan, On Sa 14 Jan 2017 13:54:16 CET, Stefan Baur wrote: > Issue #3: > Comparing the master branch in git with the version in stable, line 37 > is different. > > There now is an additional check for the existence of a directory > "/usr/share/doc/x2gothinclient-minidesktop". > > Which script/package creates this directory and why is it equivalent to > detecting a running x2gothinclientd? > > Looks like > http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 > introduced that change, see > http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 > but there's no meaningful commit message. Mike#1? The mini desktop is a minimal MATE desktop env running on the thin=20=20 client.=20With that minimal desktop, x2gothinclientd is not used and the=20= =20 role=20is taken over by MATE's session manager. Simple as that. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_wO6Uu425wNjJvI6C9UfdIxp Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYfOg5AAoJEJr0azAldxsx4J8P/REl+hq7A4I7IGY5V8d5VuA/ hQAuA32s2KP19g/t74VNRNcHwJykA8Suv3Jq5xDrP6JuzbnsoMy2xbJETxu118zg 7g8yfBVOODQdi3Pv/G1Yc9Gk8LOUJ6uR7hGX1HfJWytXzTkei9vAwSFkj3HtaKV+ fFo6MO1qP9p7dPJf5TGiqyJpc7D7ZMCNJXOYuoYiQYsJjEe/wW/Uxn9gpuzHMvaV IX6l9qqacejR/m6AhHwe2oyGRn+ISEUdQ9bfmCt/frva2rcU+/M6pNGur+0mgMB3 011u7pPxKfDqDrnAHgQPb7IUQyFffH/CckYcAxSm6nmA49y8dYGnIqMbcNYbr92U UraWldE7V8XNXzKMCYQYSWYCswQvWjAEMvQPnlR2Izq4Y0gpuIs+7Nq/eZ5WCtMi A2nM8r3X6UTroCqJbzqXnzjfDYWWtvkLoffi7DhE69rvLRf0Mbge568WgWrRG1L4 V9BTgrwovLuMvKrX9HBR3Tqrg3PTHeRyRYXZinwNajIgHzLq7FM/qeBKUGrFwrrn pjycuJ0QC/3/0ErFx70HJZbLL4ZIja1m2NgD19nA+Ou1S22yV/sSa4okl6Fxnzxk 6zbnIk4meC9X7pEpvUBfiX3nhPSE2v5baF0LBDD2XT7DnIPS3lRRNFBEOzilFM3o 88VRSkyixmB7jobpPS4r =a2XD -----END PGP SIGNATURE----- --=_wO6Uu425wNjJvI6C9UfdIxp-- From X2Go-ML-1@baur-itcs.de Mon Jan 16 16:40:02 2017 Received: (at 1136) by bugs.x2go.org; 16 Jan 2017 15:40:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A555A3CDDF for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:40:02 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gy68rVnvaR9K for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:39:55 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 598473CDDD for <1136@bugs.x2go.org>; Mon, 16 Jan 2017 16:39:55 +0100 (CET) Received: from [192.168.0.23] ([78.43.90.159]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPSA (Nemesis) id 0Lr6Nr-1cyeeg1OXz-00eZJA; Mon, 16 Jan 2017 16:39:53 +0100 Subject: Re: [X2Go-Dev] Bug#1136: Multiple issues with x2gousbmount To: Mike Gabriel , 1136@bugs.x2go.org References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> From: Stefan Baur Message-ID: <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> Date: Mon, 16 Jan 2017 16:39:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HGLq0N6WdBstIURoirNdP2goWvV3m9tD8" X-Provags-ID: V03:K0:mJJZQrx6zoDDBuj2nsvTXsNPqRhvRabkWqiPfNPsq7C6wuZCeR4 BKPH7LogcXFC6MN04+r5bx4yj5dSfqQ5QvLFiUHWtQDjbKXkthMXPoNk0UDU6V/HCeE7M6m JcMYYicguZYiW1rWmQr7gXsqz2jFIbvOIdk4MC7Zypcubr1p044pF/3Whdtd+96GRJhQMOi lnpGDKhRcZ4xjZ5w2OzPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:5z/yeV/7Hjg=:AneEEJ5c8dEc5iR1kw3EnM LpOif+L6YbwVXUv/J8M5tVbZekNJ0sXWaFx4hXs5fCDrN39pM0Es5cJrmXatBSf7n6woABCt5 +zwMa5O+QTRCXTmFQkFuMR7nJL9bfemsMPnaGxR+vlXVWPL3Krg9uRuuM3ZGOiRosdMmWCCqn A7qqH1pP3CsjB25OGiYKjCpkhf4vimNEwxVtGfbuZGCR9z7XkByXGwkljHr4exQh9sBW5KzT6 7+s24bzt91UGvncKXBVbNi74XtHdtu4fQTN11pacaMhH1mD3q1soS8f9idA2RUWph0Mf2RH2k c2UY3BWZ9kJvDZp65IvRC7hCrWdT7yY5KrEktYxsuoHCen5/TAjFQYeITZsd4Mp3iSSLpXL8L K1y3O2Bd23/87xx+WxjIAySOYGea7jdFuaijZDDcn/8uT2Jq+zt0SQWmbmDef5Rx1j88V5D7n /OT/115M2qlyhqo8XGnIybccmZxFSXLaGT+8nVPyWOQTUM7URAWZHgedaX0By+25xO9RdrUxi FK/ysQxYkOf/4ai6UtKN0rxQgn1ZYkt6at/ubW3J9jZFhrIiKCPeErG5xIDT+Zq0mIH4wcsot /NDRYhYMUWDUl9UThkFgbYeWt2tKRCEZt6xp6reWy9/7oPjoS23Gnhj4na6nSkMFtNiAAfj5c /1VgAwZdXJ3hsMZUWORrSwAqgsTu7zW9mafpyXB3+CzCHMexlPYYGM0dns6t636HAvE0= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HGLq0N6WdBstIURoirNdP2goWvV3m9tD8 Content-Type: multipart/mixed; boundary="06MVW6wcEQ6PVBPb01TwGwcumBO6XxA5I"; protected-headers="v1" From: Stefan Baur To: Mike Gabriel , 1136@bugs.x2go.org Message-ID: <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> Subject: Re: [X2Go-Dev] Bug#1136: Multiple issues with x2gousbmount References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> In-Reply-To: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> --06MVW6wcEQ6PVBPb01TwGwcumBO6XxA5I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 16.01.2017 um 16:35 schrieb Mike Gabriel: >=20 > The mini desktop is a minimal MATE desktop env running on the thin > client. With that minimal desktop, x2gothinclientd is not used and the > role is taken over by MATE's session manager. >=20 > Simple as that. Does that mean that at the very moment when an USB plug/unplug event is detected, there is no x2goclient running that has --thinclient set? Because if you *do* call x2goclient [...] --thinclient [...] for that minidesktop session, then the new detection in the subroutine check_x2gothinclientmode will trigger on that as well, so the "|| ..." part would no longer be needed. Kind Regards, Stefan Baur --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --06MVW6wcEQ6PVBPb01TwGwcumBO6XxA5I-- --HGLq0N6WdBstIURoirNdP2goWvV3m9tD8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYfOlHAAoJEG7d9BjNvlEZyaYH/30iZTAi3Px7//TD/oJJviex b6azptCeg9rx4oYTKCGx277UJmoXaDRsM26ikdZa24plHEH/52A3bprMEHA86Vzf MttqQONn8yZ2397arwgh/L+hz/pLvPGts7eWwAgnqi+Ikjx0j6VG+41pZYTaB3CO E+POdkXw4VZWE8x4vITHoOn7/oqaMleE3sGsJRlPqlgqnHVUo1YsX+X7rhVVpbvl dixPNfr+zRrLYHR45RHb2MY1GhgVbI5bRbZ0YvuxCdCrd/2eIX/9RajzO996BTXY zz8Y4J3orOsrjj/0/TyrGbOXb4z8eVm2ZvIZZZF+TGMgho717jvuxROYVoVs1OY= =6RlY -----END PGP SIGNATURE----- --HGLq0N6WdBstIURoirNdP2goWvV3m9tD8-- From X2Go-ML-1@baur-itcs.de Thu Jan 19 10:10:36 2017 Received: (at 1136) by bugs.x2go.org; 19 Jan 2017 09:10:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.4 required=3.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id C4CD93CDDB for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z5zQe8VHUV-N for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:29 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E1AD83CDDA for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:28 +0100 (CET) Received: from [192.168.0.23] ([78.43.90.159]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.129]) with ESMTPSA (Nemesis) id 0LupVN-1cLa9F0DRZ-0102VN; Thu, 19 Jan 2017 10:10:28 +0100 Subject: Re: [X2Go-Dev] Bug#1136: Bug#1136: Multiple issues with x2gousbmount To: Mike Gabriel , 1136@bugs.x2go.org References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de> From: Stefan Baur Message-ID: <566a0c04-404d-2331-494b-6de277cb824e@baur-itcs.de> Date: Thu, 19 Jan 2017 10:10:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bIhlsGk3vWAspKvsCc50b6I9TdqImbdbh" X-Provags-ID: V03:K0:II9SETcIgl6K3ZyJvu5+zTRcdh04aRELW1Iy/oNd+lY6WCzDGWu LpbAMO8FEOhliO4xfrjzsBhhasGboC919mwywBz+Hb7SnOeRzRm9RShJWELJRtteyZ/NknP hilgFsRdi6otkwtqaeuunAPBrHIRFYNdaHFfMOZ5/sYhwz0DEeKnQh8fkz1LjPd+1LTLGEB TxEH24fe6GwdwWqPDhG6w== X-UI-Out-Filterresults: notjunk:1;V01:K0:78Afeaj6Hr8=:D+tuHmV9ySUBysLfXdXGEO BTlNrVH4gZVcplPvS2LwLuWgP3Cy/Mfnwjrttsvv0NzgnonPbkJWd+d7a5Rwyv7t0cm8Lo3Ny k+ruE6rdmCMDj/vjEEKhoDyR6KRXStxDJmy6dxFo6tSziUuNLFL/5fupVh+W9pV2YQbM2E1BN E5iIni9OvEPvNrLib2T/DJmXfniez6X2F23DWqNu846gaPkvIu3JyFJ9nrQykHsuap1G6zqvD dxQWuKSa2WMCjjCzVbe+ceEFLiBl1xzooAbQz6Wib3BStD32vc2ynPoHzwvCUT0kcuTWI1aQg ZMWKZJYXvYsxA7is4//PPqqIJahKV0KCo3rAAgovd9JThJk9FilSxq0WvKxDlFseakuRVPrq8 L42Skt9SxQWHAB9+jrBEje9BJF1s2IHupgCCzpFmo70fEeW1jbnYYCWEvxGFtKExiIao+uaD5 yWq/bCOUwMbtVE5+9gBKiCviuqcTG+W2iApdfb8Sb42Zdl4Ptbyv+vKXcndiI9orfaVN4md0c t6D1PKdgqzYGDmHjrCLzk4jQUPBpci/6Nt7bej5KLkwm3bLNo/l8ExUgnpAQuh1H9zSCDYVdT 7dbhiIUKBpdT1U1Q9jCqod/hol+GqmjtG0D26M2vmxmr5jRWl47h8AOFRgBDQ/AcgIoMYg/Kd 6jYMAMpeqSj8p6JV7oTdw99HgzNzzSVX3TNvzNtyx/nL7MrBmWDodkJXbU4efITqiXlU= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bIhlsGk3vWAspKvsCc50b6I9TdqImbdbh Content-Type: multipart/mixed; boundary="kpxbdToB65jA6vkjtVes5bJxp6P0p0Vw4"; protected-headers="v1" From: Stefan Baur To: Mike Gabriel , 1136@bugs.x2go.org Message-ID: <566a0c04-404d-2331-494b-6de277cb824e@baur-itcs.de> Subject: Re: [X2Go-Dev] Bug#1136: Bug#1136: Multiple issues with x2gousbmount References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de> In-Reply-To: <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de> --kpxbdToB65jA6vkjtVes5bJxp6P0p0Vw4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 19.01.2017 um 10:02 schrieb Mike Gabriel: >> Because if you *do* call x2goclient [...] --thinclient [...] for that >> minidesktop session, then the new detection in the subroutine >> check_x2gothinclientmode will trigger on that as well, so the "|| ..."= >> part would no longer be needed. >=20 > Not sure what you mean by that. *sigh* ... Old code: Checks for presence of x2gothinclientd (sub check_x2gothinclientd) New code: Checks for presence of x2goclient with --thinclient option (sub check_x2gothinclientmode) Old code: if ( check_x2gothinclientd() || ( -d "/usr/share/doc/x2gothinclient-minidesktop" ) ) -> "Either x2gothinclientd is running or directory /usr/share/doc/x2gothinclient-minidesktop exists" If, on the Minidesktop, x2goclient would be called with --thinclient, that line could be shortened to: if ( check_x2gothinclientmode() ) Pleas pay attention to this: Your statement > Basically, you don't want x2gousbmount > interfere with udisks(2) which is what the MATE session manager uses to= > manage pluggable storage devices. contradicts what the code currently in the X2Go repo (NOT our latest, suggested changes) is doing - in other words, the present code DOES run x2goumount when the minidesktop is detected, so it WILL interfere with udisks/MATE session manager - so either you are wrong, or you have an issue there. -Stefan --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --kpxbdToB65jA6vkjtVes5bJxp6P0p0Vw4-- --bIhlsGk3vWAspKvsCc50b6I9TdqImbdbh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYgIKAAAoJEG7d9BjNvlEZrrMH/jHo4Q0QElCFAHvF5O9bpNcX veE2ohJ/8ftHvEqRNh7WdW0gRBlnfvbwTlPdIFp1z5IFMAaTiNqpAyvXNt6xcbrk mcY8LULAWXett4/vockRGRjIc+rbH8H4hn6IT/uLRCDzHg3AblnqWGs8JHwcB9QE V/dQcY+sMeqkgl4bVFOhF1pL3IqZefR8Yg2lSlyeQB2ueUZA31TsOcCEiZao2HuY 9S5wR7+v9sQoRSykq+2IsbEQ4xQH0VzncvJDO0zo6I2tHkBo1Rz8+eAq3vYK/adH n4bpby7Qv/HNhkwVzNDLbOmsy+Dec0uqdIxqLhbNwVyZXQbpqeOZc798fdO+1Aw= =OMJl -----END PGP SIGNATURE----- --bIhlsGk3vWAspKvsCc50b6I9TdqImbdbh-- From mike.gabriel@das-netzwerkteam.de Thu Jan 19 10:10:49 2017 Received: (at 1136) by bugs.x2go.org; 19 Jan 2017 09:10:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id DC3655DAA7 for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X8y7Cgnd2QMg for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:42 +0100 (CET) X-Greylist: delayed 512 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 19 Jan 2017 10:10:42 CET Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1E4B63CDDA for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:42 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 8A21361122; Thu, 19 Jan 2017 09:02:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D9D75C5516; Thu, 19 Jan 2017 10:02:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iJD6U9VR0+cV; Thu, 19 Jan 2017 10:02:05 +0100 (CET) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 9CB12C53C4; Thu, 19 Jan 2017 10:02:05 +0100 (CET) Received: from p5B3B959F.dip0.t-ipconnect.de (p5B3B959F.dip0.t-ipconnect.de [91.59.149.159]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 19 Jan 2017 09:02:05 +0000 Date: Thu, 19 Jan 2017 09:02:05 +0000 Message-ID: <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de> From: Mike Gabriel To: Stefan Baur , 1136@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#1136: Bug#1136: Multiple issues with x2gousbmount References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de> <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> In-Reply-To: <14d7c98e-fbe9-bdb1-e4ff-b9ecc2f250ac@baur-itcs.de> User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.59.149.159 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Content-Type: multipart/signed; boundary="=_EjzDyrSIJ1hNT3z_rG7h8-6"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_EjzDyrSIJ1hNT3z_rG7h8-6 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mo 16 Jan 2017 16:39:48 CET, Stefan Baur wrote: > Am 16.01.2017 um 16:35 schrieb Mike Gabriel: >> >> The mini desktop is a minimal MATE desktop env running on the thin >> client. With that minimal desktop, x2gothinclientd is not used and the >> role is taken over by MATE's session manager. >> >> Simple as that. > > Does that mean that at the very moment when an USB plug/unplug event is > detected, there is no x2goclient running that has --thinclient set? Exactly. On the Mini-Desktop based TCE variant, X2Go Client runs in=20=20 "normal"=20mode. It is launched via a desktop icon (and in the temp=20=20 user's=20XDG autostart folder). > Because if you *do* call x2goclient [...] --thinclient [...] for that > minidesktop session, then the new detection in the subroutine > check_x2gothinclientmode will trigger on that as well, so the "|| ..." > part would no longer be needed. Not sure what you mean by that. Basically, you don't want x2gousbmount=20= =20 interfere=20with udisks(2) which is what the MATE session manager uses=20= =20 to=20manage pluggable storage devices. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_EjzDyrSIJ1hNT3z_rG7h8-6 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYgICNAAoJEJr0azAldxsxk2gP/30sYI/sne9VVwrqK0JoDiJb mqOs8rPP+Aup575MnkJEXcG5TtFhQC4JYvNZNtl13iLlK+uYHxj7lv67zQylafUQ AoH+bZZBSCN9IQuJFfO1eVxR8qurqFzeBlHVVEuFKgX8GuAbiLsvIrBlhAnhwJ7N FG9U9aDZa4AL0SlmwTeaFF9DRVsfVHIN8suzFpvBCBABcMpdqCJKBhX0lOz9WRPB R2WSflmbB6EYYDm90Sw8sfz7TGUEIWbNbPX1VSGFEmugqBRH/BFse64IWV1UXyWm GreOQ7Sig6OJUwYPBVXBQWEDsICCfZHJdF7ziWtcbyV7EfcwlZsd2TPaeSy60hsU K2ULBGE/TJR7owyeHheCSZ+/G/Hg87sldBZaD4nMsdIsdfYqraG1PCRrEKfYHHin HrHk1pjsqKGZ+w3nxtygs24FK5rCqzk6SDZMYSVZwbpXJYb96KH45AZjurpQfhyp AoBaQn3hdTExITw+xJl0+HlyVDGkgQShlKR1Org1KCwZ3p8+RxYsp95zvSUgAB2Y 8+ExNXOO1uPXCyrDxHeFAa3dt5gOH02eC6GM0/Ooxp1u1V6wH6Nmy1DKKXpqGJwM VKNm0l5MtJvzQzr7KZ48AG3qUBaOpr/2fGw7a7Eoe8UNUhcTHRuipMQ2MsSJFVxc SFUaex/Y1l2UqXE9lea8 =wo09 -----END PGP SIGNATURE----- --=_EjzDyrSIJ1hNT3z_rG7h8-6-- From x2go@ymir.das-netzwerkteam.de Tue Apr 25 22:44:26 2017 Received: (at 1136) by bugs.x2go.org; 25 Apr 2017 20:44:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id E422B5DAD9; Tue, 25 Apr 2017 22:44:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WqBNdL6ZOOfX; Tue, 25 Apr 2017 22:44:18 +0200 (CEST) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id B99D95DACF; Tue, 25 Apr 2017 22:44:18 +0200 (CEST) From: =?utf-8?q?Mihai_Moldovan?= To: 1136-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1136@bugs.x2go.org Subject: X2Go issue (in src:x2gothinclient) has been marked as pending for release Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailer: http://snipr.com/post-receive-tag-pending Message-Id: <20170425204418.B99D95DACF@ymir.das-netzwerkteam.de> Date: Tue, 25 Apr 2017 22:44:18 +0200 (CEST) tag #1136 pending fixed #1136 1.5.0.0 thanks Hello, X2Go issue #1136 (src:x2gothinclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2gothinclient.git;a=commitdiff;h=c500f90 The issue will most likely be fixed in src:x2gothinclient (1.5.0.0). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit c500f9075111a47796f5c5ac8f0846500956d518 Author: Stefan Baur Date: Tue Apr 25 22:41:32 2017 +0200 usbmount/x2gousbmount: fix desktop/thinclient mode detection. Fixes: #1136. diff --git a/debian/changelog b/debian/changelog index 03a6502..2ed8f9c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -86,6 +86,7 @@ x2gothinclient (1.5.0.0-0x2go1) UNRELEASED; urgency=low * usbmount/x2gousbmount: - Make user pseudo-selectible via a variable and fix usage across file. - Try to create file-sharing facilities harder. + - Fix desktop/thinclient mode detection. Fixes: #1136. [ Mark Pedersen-Cook ] * debian/po: From x2go@ymir.das-netzwerkteam.de Sun Dec 2 04:19:54 2018 Received: (at control) by bugs.x2go.org; 2 Dec 2018 03:19:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id D69F75DAF7; Sun, 2 Dec 2018 04:19:17 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1136-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1136@bugs.x2go.org Subject: X2Go issue (in src:x2gothinclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20181202031917.D69F75DAF7@ymir.das-netzwerkteam.de> Date: Sun, 2 Dec 2018 04:19:17 +0100 (CET) close #1136 thanks Hello, we are very hopeful that X2Go issue #1136 reported by you has been resolved in the new release (1.5.0.0) of the X2Go source project »src:x2gothinclient«. You can view the complete changelog entry of src:x2gothinclient (1.5.0.0) below, and you can use the following link to view all the code changes between this and the last release of src:x2gothinclient. http://code.x2go.org/gitweb?p=x2gothinclient.git;a=commitdiff;h=448f3812eca5180f48b57d7988732eecd14b47dd;hp=d1a83c17ca9568f8ef5ec2bb89e754db5e8b7df3 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2gothinclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2gothinclient Version: 1.5.0.0-0x2go1 Status: RELEASE Date: Sun, 02 Dec 2018 04:10:28 +0100 Fixes: 419 718 719 726 840 997 1092 1136 1147 Changes: x2gothinclient (1.5.0.0-0x2go1) RELEASED; urgency=low . [ Mike Gabriel ] * New upstream release (1.5.0.0): - Stop advertising GNOME in default session profile. Switching to MATE. - Use type=auto for automatic keyboard detection as default in example session profiles. - Avoid error message in x2gothinclient_shell if the chroot does not have a file-or-symlink /etc/resolv.conf. - Use resolv.conf file from host system when running x2gothinclient_upgrade. - Add COPYING file. - Run x2gothinclient_shell and x2gothinclient_upgrade with LANG=C. - Don't run x2gothinclient_init inside TCE chroot operations (x2gothinclient_shell or x2gothinclient_upgrade). - Avoid x2gothinclient_init failures, use if..then..fi instead of the test command. - Init scripts: Provide status option. - Use lazy unmounts for unmounting bind-mounted /proc, /sys, /dev/pts after exiting the TCE chroot (x2gothinclient_create, x2gothinclient_shell, x2gothinclient_upgrade, x2gothinclient_cleanup). - Assure that a tmpfs under /root gets mounted and cleanly unmounted (x2gothinclient_shell, x2gothinclient_upgrade). - Use run-parts to initialize the TCE during runtime. (Fixes: #419). - New TCE component: x2gothinclient-minidesktop. Instead of using X2Go Client as login manager, we launch a minimal MATE desktop and connect to X2Go sessions from there. . Add WindowList applet to MATE panel. . On $HOME creation, copy x2gothinclient-minidesktop.desktop into ~/Desktop. . Provide init script for x2gothinclient-minidesktop to handle maintenance tasks if TCE is installed with in minidesktop flavour. . Tweak MATE minidesktop via GScheme overrides. . Launch MATE minidesktop via LightDM autologin feature. . Add XDG autostart .desktop file for the TCE's X2Go Client. . Add VERSION. file for x2gothinclient-minidesktop. . Make X2Go TCE layout / appearance overridable by installing debian-edu-artwork package. . Use default X2Go Client background for x2gothinclient-minidesktop. Provide configurable desktop background instead. Install desktop background as desktop-base alternative. . On minidesktop TCE creation based on wheezy, pull in packages from wheezy-backports (i.e. MATE desktop environment). . MATE Application menu: Move the default X2Go Client .desktop file out of the way (dpkg-divert) and provide the TCE's .desktop file instead. . Make sure that launching x2goclient via a terminal or the run command box in MATE results in the restricted TCE X2Go Client. . Make contrib and non-free software available on minidesktop TCE creation. . Disallow Caja to handle storage media (automounting, opening, etc.). . Enable usbmounts and smartcard rules for minidestop TCE flavour. . Enforce TCE session restart after logout. . Provide Web browser shortcut in the MATE panel. . Enable native-protocol-tcp module in pulseaudio on every X2Go Client launch. Allow access from local host only, require auth cookie. - Adapt management package to TCE flavouring. Add new configuration option in x2gothinclient_settings: TC_FLAVOUR (can be: minidesktop or displaymanager). - Use proper quotations in several X2Go TCE scripts. - Don't choke if /etc/resolv.conf in the TCE chroot is a symbolic link (in x2gothinclient_shell, x2gothinclient_upgrade). - README.i18n: Add file that explains the translation workflow for this package. Thanks to Mark Pedersen-Cook for drafting this file. - For X2Go TCE in display manager mode, set login backgrounds of all screens (if more than one is used) to a blue'ish background color. (Fixes: #718). - TCE in display manager mode: Don't align multiple heads next to one another if a (Wacom) touchscreen is detected in the list of heads. (Fixes: #719). - management/sbin/x2gothinclient_update: Create $TC_CHROOT/etc/x2go/x2gothinclient_init.d/ before copying files into it. - management/sbin/x2gothinclient_update: Consider known_hosts2 FreeRDP host key files, known_hosts was used for FreeRDP v1.x and are in fact deprecated nowadays. - management/sbin/x2gothinclient_create: Stop using deprecated --force-yes. - 010_x2gothinclient-fresh-home: Install FreeRDPv2's known_hosts2 file into ~x2gothinclient user's home dir when creating a fresh home. - x2gothinclient_sessions: Provide RDP-Direct session profile example that utilizes FreeRDPv2 rather than deprecated FreeRDPv1.x. (On Debian stretch, it is recommended to use FreeRDPv2 from Debian stretch-backports). - x2gothinclient-_start: Drop requirement of having symlink /etc/x2go/x2gothinclient_start. Now all code passages that use the _start wrapper, use the x2gothinclient-_start file directly. * debian/control: + Rename bin:package: x2gothinclient -> x2gothinclient-daemon. + Make sure x2gothinclient-minidesktop pulls in X11 and X2Go Client. + New bin:package: x2gothinclient-common. Commonly shared by x2gothinclient-minidesktop and x2gothinclient-displaymanager + Add D (displaymanager flavour, minidesktop flavour): pinentry-x2go. + Add D (x2gothinclient-minidesktop): lightdm. + Add R (x2gothinclient-minidesktop): flashplugin-nonfree. + Add R (x2gothinclient-chroot): ntp. + Move to Pre-D (x2gothinclient-minidesktop): x2goclient, lightdm. Make sure those packages are installed already avoiding dpkg-divert failures. + Allow co-installation of displaymanager and minidesktop bin:pkgs. They have no conflicting files and we should rather make the startup mode configurable through debconf. * debian/copyright: + Use copyright-format 1.0. . [ Stefan Baur ] * New upstream release (1.5.0.0): - Allow Xinerama / XRandR setup via /proc/cmdline. (Fixes: #726). * usbmount/x2gousbmount: - Make user pseudo-selectible via a variable and fix usage across file. - Try to create file-sharing facilities harder. - Fix desktop/thinclient mode detection. Fixes: #1136. - Set default username to x2gothinclient for MATE minidesktop builds, even for X2GO TCE Live builds. - Add support for (V)FAT, NTFS, HFS, HPFS and EXT* (via fuse-ext2) file systems. . [ Mark Pedersen-Cook ] * debian/po: + Add DebConf translation to Danish. . [ Kaan Ozdincer ] * debian/po: + Add DebConf translation to Turkish. . [ Mihai Moldovan ] * New upstream release (1.5.0.0): - Change string "X2go" to "X2Go" where appropriate. - displaymanager/init/x2gothinclient-displaymanager.init: fix unchanged "gdm" string in log message. Fixes: #997. - management/share/etc/x2gothinclient-minidesktop_start: correctly continue commented out command on the next line. Fixes: #1147. - displaymanager/sbin/x2gothinclientd: correctly break long strings over several lines and concatenate them. - management/share/etc/x2gothinclient_init.d/ 950_x2gothinclient-minidesktop: call Xsession in mate-minidesktop builds of X2Go TCE Live. - misc: update copyright notices, but for Mike Gabriel. - README.howto: fix typos. - misc: update http:// to https:// URLs where appropriate. - misc: drop whitespace from hashbangs. - debian/x2gothinclient-common.postrm: newline at EOF change. - misc: update Oleksandr's mail address. - misc manpages: whitespace only. - misc manpages: pre-release version and date updates. - cdmanager/powerej/mb.{cpp,h}: whitespace only. - cdmanager/powerej/powerej.pro: regenerate with Qt5's qmake and merge. - cdmanager/powerej/eject.cpp: use PlastiqueStyle with Qt4 and Fusion with Qt5. - cdmanager/powerej/eject.cpp: include QStyleFactory. - misc manpages: pre-release date update. * usbmount/x2gousbmount: - Fix typo int -> print. Fixes: #840. - Update copyright notice. - Fix left-over check_x2gothinclientd definition (should have been check_x2gothinclientmode). * debian/control: - Whitespace only. - x2gothinclient-cdmanager: drop libqt4-gui Depends. Already handled by libqt4-dev Build-Depends and shlibs and misc Depends. - Maintainer change in package: X2Go Developers . - Uploaders: add myself. Also, force a rebuild due to the changed versioning. - Resurrect x2go{thinclient-management,usbmount,cdmanager,smartcardrules} as dummy packages in the spirit of x2gothinclient for a smooth upgrade path. - mate-media-pulse and mate-settings-daemon-pulse are gone in Stretch. Depend on them lightly. - Replace iceweasel dependency with firefox-esr. All suites provide the newer name. Avoids an ugly outdated menu entry. - Build-depend upon Qt5 instead of Qt4. - Bump DH compat level to 9. * management/share/etc/x2gothinclient-minidesktop_start: - Correctly quote pactl command line arguments, avoids the shell interpreting the embedded semicolon as a command separator. * debian/po: - Minor fixup on author name. - Regenerate templates and files. - Update template with metadata. - fr.po: update metadata. - Update bugs address in template. - Update translation metadata. - da.po: fixup. - de.po: fixup. * debian/copyright: - Remove obsolete and wrong obviouslynice.de address. * debian/rules: - Whitespace only. - Switch to building cdmanager/powerej via Qt5. - Modernize respective build flags. - Add all clause. - Make sure to select Qt5 variant, even though we probably won't use debhelper to build Qt projects. - Call qmake instead of qmake-qt5. * debian/compat: - Bump DH compat level to 9. . [ Oleksandr Shneyder ] * x2gothinclientd: load config file when starting PulseAudio. Fixes: 1092. * upgrade to debian stretch. * set oldsatble to jessie in x2gothinclient_settings. * install linux-image-4.9.0-4-686 instead of dummy-package * add pxelinux in recommends for x2gothinclient-management * fix links in x2gothinclient_preptftpboot * fix link in x2gothinclient_create * install chroot for amd64 * fix x2gothinclient_update to create files needed by x2gothinclientd * let user choose architecture by setting TC_ARCH variable. Default amd64. * improve support for gnupg and dbus. * modify x2gothinclientd to start scripts needed by gpg agent. * install meta-package for linux-image to get most recent version. Thanks to Mike for the hint. * start openbox to make xinerama work. Thanks to Walid Moghrabi for the hint. * fix Xorg checking in x2gothinclientd. * remove nomedeset option from x2go-tce.cfg. This option prevent loading of drm and disabling advanced graphic functions. * add openbox dependency. * do not start openbox any more. Xinerama issue should be fixed in x2goagent. . [ Martti Pitkänen ] * debian/po: + Add DebConf translation to Finnish. . [ Thierry Kauffmann ] * New upstream release (1.5.0.0): - debian/po: add French translation file. From unknown Fri Mar 29 00:36:39 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1136 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2gothinclient) has been marked as closed) Message-ID: References: <20181202031917.D69F75DAF7@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 1136 X-X2go-PR-Package: x2gousbmount X-X2go-PR-Source: x2gothinclient Date: Sun, 02 Dec 2018 03:20:10 +0000 Content-Type: multipart/mixed; boundary="----------=_1543720810-8715-0" This is a multi-part message in MIME format... ------------=_1543720810-8715-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2gousbmount package: #1136: Multiple issues with x2gousbmount It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1543720810-8715-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 2 Dec 2018 03:19:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id D69F75DAF7; Sun, 2 Dec 2018 04:19:17 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1136-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1136@bugs.x2go.org Subject: X2Go issue (in src:x2gothinclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20181202031917.D69F75DAF7@ymir.das-netzwerkteam.de> Date: Sun, 2 Dec 2018 04:19:17 +0100 (CET) close #1136 thanks Hello, we are very hopeful that X2Go issue #1136 reported by you has been resolved in the new release (1.5.0.0) of the X2Go source project »src:x2gothinclient«. You can view the complete changelog entry of src:x2gothinclient (1.5.0.0) below, and you can use the following link to view all the code changes between this and the last release of src:x2gothinclient. http://code.x2go.org/gitweb?p=x2gothinclient.git;a=commitdiff;h=448f3812eca5180f48b57d7988732eecd14b47dd;hp=d1a83c17ca9568f8ef5ec2bb89e754db5e8b7df3 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2gothinclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2gothinclient Version: 1.5.0.0-0x2go1 Status: RELEASE Date: Sun, 02 Dec 2018 04:10:28 +0100 Fixes: 419 718 719 726 840 997 1092 1136 1147 Changes: x2gothinclient (1.5.0.0-0x2go1) RELEASED; urgency=low . [ Mike Gabriel ] * New upstream release (1.5.0.0): - Stop advertising GNOME in default session profile. Switching to MATE. - Use type=auto for automatic keyboard detection as default in example session profiles. - Avoid error message in x2gothinclient_shell if the chroot does not have a file-or-symlink /etc/resolv.conf. - Use resolv.conf file from host system when running x2gothinclient_upgrade. - Add COPYING file. - Run x2gothinclient_shell and x2gothinclient_upgrade with LANG=C. - Don't run x2gothinclient_init inside TCE chroot operations (x2gothinclient_shell or x2gothinclient_upgrade). - Avoid x2gothinclient_init failures, use if..then..fi instead of the test command. - Init scripts: Provide status option. - Use lazy unmounts for unmounting bind-mounted /proc, /sys, /dev/pts after exiting the TCE chroot (x2gothinclient_create, x2gothinclient_shell, x2gothinclient_upgrade, x2gothinclient_cleanup). - Assure that a tmpfs under /root gets mounted and cleanly unmounted (x2gothinclient_shell, x2gothinclient_upgrade). - Use run-parts to initialize the TCE during runtime. (Fixes: #419). - New TCE component: x2gothinclient-minidesktop. Instead of using X2Go Client as login manager, we launch a minimal MATE desktop and connect to X2Go sessions from there. . Add WindowList applet to MATE panel. . On $HOME creation, copy x2gothinclient-minidesktop.desktop into ~/Desktop. . Provide init script for x2gothinclient-minidesktop to handle maintenance tasks if TCE is installed with in minidesktop flavour. . Tweak MATE minidesktop via GScheme overrides. . Launch MATE minidesktop via LightDM autologin feature. . Add XDG autostart .desktop file for the TCE's X2Go Client. . Add VERSION. file for x2gothinclient-minidesktop. . Make X2Go TCE layout / appearance overridable by installing debian-edu-artwork package. . Use default X2Go Client background for x2gothinclient-minidesktop. Provide configurable desktop background instead. Install desktop background as desktop-base alternative. . On minidesktop TCE creation based on wheezy, pull in packages from wheezy-backports (i.e. MATE desktop environment). . MATE Application menu: Move the default X2Go Client .desktop file out of the way (dpkg-divert) and provide the TCE's .desktop file instead. . Make sure that launching x2goclient via a terminal or the run command box in MATE results in the restricted TCE X2Go Client. . Make contrib and non-free software available on minidesktop TCE creation. . Disallow Caja to handle storage media (automounting, opening, etc.). . Enable usbmounts and smartcard rules for minidestop TCE flavour. . Enforce TCE session restart after logout. . Provide Web browser shortcut in the MATE panel. . Enable native-protocol-tcp module in pulseaudio on every X2Go Client launch. Allow access from local host only, require auth cookie. - Adapt management package to TCE flavouring. Add new configuration option in x2gothinclient_settings: TC_FLAVOUR (can be: minidesktop or displaymanager). - Use proper quotations in several X2Go TCE scripts. - Don't choke if /etc/resolv.conf in the TCE chroot is a symbolic link (in x2gothinclient_shell, x2gothinclient_upgrade). - README.i18n: Add file that explains the translation workflow for this package. Thanks to Mark Pedersen-Cook for drafting this file. - For X2Go TCE in display manager mode, set login backgrounds of all screens (if more than one is used) to a blue'ish background color. (Fixes: #718). - TCE in display manager mode: Don't align multiple heads next to one another if a (Wacom) touchscreen is detected in the list of heads. (Fixes: #719). - management/sbin/x2gothinclient_update: Create $TC_CHROOT/etc/x2go/x2gothinclient_init.d/ before copying files into it. - management/sbin/x2gothinclient_update: Consider known_hosts2 FreeRDP host key files, known_hosts was used for FreeRDP v1.x and are in fact deprecated nowadays. - management/sbin/x2gothinclient_create: Stop using deprecated --force-yes. - 010_x2gothinclient-fresh-home: Install FreeRDPv2's known_hosts2 file into ~x2gothinclient user's home dir when creating a fresh home. - x2gothinclient_sessions: Provide RDP-Direct session profile example that utilizes FreeRDPv2 rather than deprecated FreeRDPv1.x. (On Debian stretch, it is recommended to use FreeRDPv2 from Debian stretch-backports). - x2gothinclient-_start: Drop requirement of having symlink /etc/x2go/x2gothinclient_start. Now all code passages that use the _start wrapper, use the x2gothinclient-_start file directly. * debian/control: + Rename bin:package: x2gothinclient -> x2gothinclient-daemon. + Make sure x2gothinclient-minidesktop pulls in X11 and X2Go Client. + New bin:package: x2gothinclient-common. Commonly shared by x2gothinclient-minidesktop and x2gothinclient-displaymanager + Add D (displaymanager flavour, minidesktop flavour): pinentry-x2go. + Add D (x2gothinclient-minidesktop): lightdm. + Add R (x2gothinclient-minidesktop): flashplugin-nonfree. + Add R (x2gothinclient-chroot): ntp. + Move to Pre-D (x2gothinclient-minidesktop): x2goclient, lightdm. Make sure those packages are installed already avoiding dpkg-divert failures. + Allow co-installation of displaymanager and minidesktop bin:pkgs. They have no conflicting files and we should rather make the startup mode configurable through debconf. * debian/copyright: + Use copyright-format 1.0. . [ Stefan Baur ] * New upstream release (1.5.0.0): - Allow Xinerama / XRandR setup via /proc/cmdline. (Fixes: #726). * usbmount/x2gousbmount: - Make user pseudo-selectible via a variable and fix usage across file. - Try to create file-sharing facilities harder. - Fix desktop/thinclient mode detection. Fixes: #1136. - Set default username to x2gothinclient for MATE minidesktop builds, even for X2GO TCE Live builds. - Add support for (V)FAT, NTFS, HFS, HPFS and EXT* (via fuse-ext2) file systems. . [ Mark Pedersen-Cook ] * debian/po: + Add DebConf translation to Danish. . [ Kaan Ozdincer ] * debian/po: + Add DebConf translation to Turkish. . [ Mihai Moldovan ] * New upstream release (1.5.0.0): - Change string "X2go" to "X2Go" where appropriate. - displaymanager/init/x2gothinclient-displaymanager.init: fix unchanged "gdm" string in log message. Fixes: #997. - management/share/etc/x2gothinclient-minidesktop_start: correctly continue commented out command on the next line. Fixes: #1147. - displaymanager/sbin/x2gothinclientd: correctly break long strings over several lines and concatenate them. - management/share/etc/x2gothinclient_init.d/ 950_x2gothinclient-minidesktop: call Xsession in mate-minidesktop builds of X2Go TCE Live. - misc: update copyright notices, but for Mike Gabriel. - README.howto: fix typos. - misc: update http:// to https:// URLs where appropriate. - misc: drop whitespace from hashbangs. - debian/x2gothinclient-common.postrm: newline at EOF change. - misc: update Oleksandr's mail address. - misc manpages: whitespace only. - misc manpages: pre-release version and date updates. - cdmanager/powerej/mb.{cpp,h}: whitespace only. - cdmanager/powerej/powerej.pro: regenerate with Qt5's qmake and merge. - cdmanager/powerej/eject.cpp: use PlastiqueStyle with Qt4 and Fusion with Qt5. - cdmanager/powerej/eject.cpp: include QStyleFactory. - misc manpages: pre-release date update. * usbmount/x2gousbmount: - Fix typo int -> print. Fixes: #840. - Update copyright notice. - Fix left-over check_x2gothinclientd definition (should have been check_x2gothinclientmode). * debian/control: - Whitespace only. - x2gothinclient-cdmanager: drop libqt4-gui Depends. Already handled by libqt4-dev Build-Depends and shlibs and misc Depends. - Maintainer change in package: X2Go Developers . - Uploaders: add myself. Also, force a rebuild due to the changed versioning. - Resurrect x2go{thinclient-management,usbmount,cdmanager,smartcardrules} as dummy packages in the spirit of x2gothinclient for a smooth upgrade path. - mate-media-pulse and mate-settings-daemon-pulse are gone in Stretch. Depend on them lightly. - Replace iceweasel dependency with firefox-esr. All suites provide the newer name. Avoids an ugly outdated menu entry. - Build-depend upon Qt5 instead of Qt4. - Bump DH compat level to 9. * management/share/etc/x2gothinclient-minidesktop_start: - Correctly quote pactl command line arguments, avoids the shell interpreting the embedded semicolon as a command separator. * debian/po: - Minor fixup on author name. - Regenerate templates and files. - Update template with metadata. - fr.po: update metadata. - Update bugs address in template. - Update translation metadata. - da.po: fixup. - de.po: fixup. * debian/copyright: - Remove obsolete and wrong obviouslynice.de address. * debian/rules: - Whitespace only. - Switch to building cdmanager/powerej via Qt5. - Modernize respective build flags. - Add all clause. - Make sure to select Qt5 variant, even though we probably won't use debhelper to build Qt projects. - Call qmake instead of qmake-qt5. * debian/compat: - Bump DH compat level to 9. . [ Oleksandr Shneyder ] * x2gothinclientd: load config file when starting PulseAudio. Fixes: 1092. * upgrade to debian stretch. * set oldsatble to jessie in x2gothinclient_settings. * install linux-image-4.9.0-4-686 instead of dummy-package * add pxelinux in recommends for x2gothinclient-management * fix links in x2gothinclient_preptftpboot * fix link in x2gothinclient_create * install chroot for amd64 * fix x2gothinclient_update to create files needed by x2gothinclientd * let user choose architecture by setting TC_ARCH variable. Default amd64. * improve support for gnupg and dbus. * modify x2gothinclientd to start scripts needed by gpg agent. * install meta-package for linux-image to get most recent version. Thanks to Mike for the hint. * start openbox to make xinerama work. Thanks to Walid Moghrabi for the hint. * fix Xorg checking in x2gothinclientd. * remove nomedeset option from x2go-tce.cfg. This option prevent loading of drm and disabling advanced graphic functions. * add openbox dependency. * do not start openbox any more. Xinerama issue should be fixed in x2goagent. . [ Martti Pitkänen ] * debian/po: + Add DebConf translation to Finnish. . [ Thierry Kauffmann ] * New upstream release (1.5.0.0): - debian/po: add French translation file. ------------=_1543720810-8715-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 14 Jan 2017 12:59:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 787E73CDDE for ; Sat, 14 Jan 2017 13:59:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JXn9T6p4JKxH for ; Sat, 14 Jan 2017 13:59:32 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 784753CDDD for ; Sat, 14 Jan 2017 13:59:32 +0100 (CET) Received: from [192.168.0.23] ([78.43.90.159]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPSA (Nemesis) id 0Lgpjq-1cp51v28NK-00oEIh; Sat, 14 Jan 2017 13:54:29 +0100 To: submit@bugs.x2go.org Cc: Oleksandr Shneyder , Mike Gabriel From: Stefan Baur Subject: Multiple issues with x2gousbmount Message-ID: Date: Sat, 14 Jan 2017 13:54:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx" X-Provags-ID: V03:K0:o2jxPZKN6wDxEUcWz4AKXnAOjV4yQ7Fvr9obSWSqoGEkN5fKXcS 46HAj5kIx0wGAlXuhlQP43uxSCVYcEfLj5xVXEy7W1vffSzGVQvNofG9uKoL4lBpEC1DZUJ uPKJeI3PB2qYPapoRMCw5wUpuNB+RXL/b88z8hjsa+kDE4UD5XHY65nG5ttkhrX5ied8KUt dQn7P5RbHvyuikWO7cgDA== X-UI-Out-Filterresults: notjunk:1;V01:K0:EkxQqP7FTzo=:gqWe6k2/J2/DMX5HnZi75W oNQHidZ/IEWxSJdNPKMt9CVevb5NFPb6AHgekvLoINrqADXbkMqcp3uctDneXa2GKAO7x/Vb4 YTPOZtUy6uMScHbgmA7gDylUNxGdf7nvlRFlpclipjq/o7ukv8FJtsAsgYjpO82f2npVg9oQK rgalOCwcUaCWRhtFf4nVSkNRjYC14w1A15kZ5j9IPffupFM7SpvW4/4ZBAN1t2/vIdXdbz8KP s2KFd/dEV8wHY9JgqZMalZOFWd8d57ftJFhkNmsLKOeW7ioWQTYBCsOa1f/UfIGAMShSDWIE+ yIwv5+xHO0dLKs7Xgw3ea5jZbeZmrYj2mi+CeMPTYX2k3QQqYBcK0ZA20nI5o3GQE+jtqq3RN oeqLZoY3l2BTTonFUpIr+JdYECfFLRpNcxeXxWBe6gAxE6WnOeOhGgqXbTxDe2wdbaEvh/MYS 30OAPG3ts03+x1DbtJnPz+cc0Z3FbwibV/bchHCUUAFgIWRIcXIE2A8S0hquOBGeOg0tQrNpM qv/El8kE91EDPY2RezUagQQpgkpwzYThlyZyz1XCbF53r3LeUM144GvIibToWZi3RsLh+XPCx gaZnFKYvc3ZZFu0d43Pf1eBWrJoQXAkulbQ12HChWJ4ujkc2T5pi1j0LjvfLZJS+sei/4mN7t UEWXBYEdK+4eMesvVesGeFRUWG6qDlG4Zns4TdUMTrPYohUyMa2osE0acVROKkozDmLA= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx Content-Type: multipart/mixed; boundary="F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC"; protected-headers="v1" From: Stefan Baur To: submit@bugs.x2go.org Cc: Oleksandr Shneyder , Mike Gabriel Message-ID: Subject: Multiple issues with x2gousbmount --F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable package: x2gousbmount Hi $LIST, hi Alex, hi Mike#1, due to a recent bug report on X2Go-User, I needed to take a closer look at the x2gousbmount package, and the script /usr/lib/x2go/tce/x2gousbmount in it. I'll be referencing http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dblob;f=3Dusbmount/= x2gousbmount;h=3D4da1fbd90b14dda1beb230ea4b08441a77d9e4eb;hb=3D75211b6e72= 4bd896d85d915c754703cabcf37187 for line numbers below, even though that version is more advanced as the one in the stable x2gousbmount package. I'm hoping that Alex or someone else that has a clue wrt/ Perl and this script can shed some light on these issues. Mike#1, you're in CC due to issue #3, which seems to have been introduced in your commit. Feel free to suggest I should turn every issue into a separate bug report - I'm not filing them separately at the moment because the issues seem all more or less interconnected, so I figured I should start with one bug report for "the big picture". Issue #1: Lines 88 and 138 contain a call ... expand_filename("~x2gothinclient ... Now, I understand that this is an attempt to determine the path to the home directory of the user named "x2gothinclient". Which, in the classic X2Go-TCE, is "/var/lib/x2gothinclient". So far, so good. But: Lines 107 and 148 contain what looks to me like a subtle typo: ... expand_filename("~/x2gothinclient ... Which means, instead of selecting the home directory of the user x2gothinclient, it would go to the home directory of the user under which the script is being executed, and a subdirectory "x2gothinclient" there, so most likely /root/x2gothinclient (which doesn't exist) So the script will probably fail whenever it encounters encrypted volumes= =2E (I can't test this myself, I don't have a setup with encrypted USB media.= ) Issue #2: The user name "x2gothinclient" is hardcoded in several places inside the script. This calls at least for a "my $user=3D'x2gothinclient';" at the beginning= of the script, and the replacement of every occurrence of "x2gothinclient" with "$user". The reason being that TCE-Live uses a different user name, namely "user" (and a different home directory, /home/user), so we need to be able to swap out the name in one central location. There are two ways of determining that we're running in TCE-Live, I am not sure which one would be the preferable one: 1) Checking /proc/cmdline for the appearance of (in regex syntax) "\W*live\W*" or "\W*boot=3Dlive\W*" (in case your mail software turns asterisks into bold type, there's an asterisk after each capital W). 2) Checking if the directory /lib/live or /lib/live/config exists. If any of these match, then $user should be set to 'user' instead of 'x2gothinclient'. Issue #3: Comparing the master branch in git with the version in stable, line 37 is different. There now is an additional check for the existence of a directory "/usr/share/doc/x2gothinclient-minidesktop". Which script/package creates this directory and why is it equivalent to detecting a running x2gothinclientd? Looks like http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 introduced that change, see http://code.x2go.org/gitweb?p=3Dx2gothinclient.git;a=3Dcommit;h=3Da458a1e= d666eb12b5d856812396ecd31fba01585 but there's no meaningful commit message. Mike#1? Issue #4: I am unhappy with the subroutine check_x2gothinclientd. Indeed, grepping for substrings so you don't trigger on the parameters of your own grep command in the output of ps is a neat hack, but a hack remains a hack. The clean way of handling this, IMO, would be to change the subroutine as follows: sub check_x2gothinclientmode { # check if X2GoClient is running in thinclient mode # old code would check if x2gothinclientd was running, # which fails on X2Go-TCE-live my $x=3D`ps u -C x2goclient`; if ( $x=3D~m/\W*--thinclient\W*/ ) { return 1; } return 0; } This will no longer detect if x2gothinclientd is running, but if x2goclient has been called with parameter --thinclient. Which should be the case in both TCE-Classic and TCE-Live. Due to the name change of the subroutine, line 37 needs to be changed to use check_x2gothinclientmode instead of check_x2gothinclientd. Maybe the changed check means the || - part in line 37 is no longer needed as well? Issue #5: Lines 88 and 138 silently assume that there is a subdirectory "export". I can't see it being created anywhere, though. Same goes for lines 107 and 148 and the subdirectory "logins". Issue #6: Why do we need two separate subdirectories "export" and "logins", anyways= ? Issue #7: Somewhere around line 48, I'm missing a comment that explains what this part of the code is for. I would suggest adding: # mntdir is not the directory where the mountpoint will be rooted, # but where tracking of mount states takes place Issue #8: Why do we have to track these mountpoints manually, anyways? Is the information in /proc/mounts insufficient? -Stefan --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --F7KNbDfmHBh83UBg91I6IMhJmsAk3fLDC-- --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYeh97AAoJEG7d9BjNvlEZNE4IAKzB5ZKpxZObcz3u8f4a8gBp ZpE/kQTGCtltYjcDHt7Embg1KQU7F+lTWO1MiaykNLsQguuAagtV+X5bwT+hC2Mt lBJKRXW2dBzNnYqldkGsvyp3+SopqMNMCV6rEKaBpFANxj2pnz72aW7aZwMPtHRq X7VxQUvWcDxvpaBOE9aTzkKqhijk4lHk7OpQj503iLYYSNRFXE14zl2mix1e/WfO s/ie8/Z3s8vvqB94/yjXI2M482Sv+3JvtbmedCd22Ee88nxvoT0TBa5tJWKeLcCF /DqEN4psm2J+l+/Oqh4/Z5HM1sWSy5IvKqFVCYatnbBVzy5i7t35O3s2R09pEO0= =M4U2 -----END PGP SIGNATURE----- --OjDTj6WW8ueV7Ix66iUOrHcvnX5Bn4bmx-- ------------=_1543720810-8715-0-- From unknown Fri Mar 29 00:36:39 2024 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@bugs.x2go.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Bug archived. Date: Sun, 30 Dec 2018 06:24:02 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # Bug archived. thanks # This fakemail brought to you by your local debbugs # administrator