From unknown Wed Apr 15 05:27:07 2026
MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#993 closed by X2Go Release Manager <git-admin@x2go.org> (X2Go
 issue (in src:x2godesktopsharing) has been marked as closed)
Message-ID: <handler.993.c.14652629034577.notifdone@bugs.x2go.org>
References: <20160607012808.F34DE5DB80@ymir.das-netzwerkteam.de>
X-X2go-PR-Keywords: pending
X-X2go-PR-Message: they-closed 993
X-X2go-PR-Package: x2godesktopsharing
Date: Tue, 07 Jun 2016 01:30:09 +0000
Content-Type: multipart/mixed; boundary="----------=_1465263009-5535-0"

This is a multi-part message in MIME format...

------------=_1465263009-5535-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

This is an automatic notification regarding your Bug report
which was filed against the x2godesktopsharing package:

#993: gcc 6 compile error

It has been closed by X2Go Release Manager <git-admin@x2go.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact X2Go Release Manager <=
git-admin@x2go.org> by
replying to this email.


--=20
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

------------=_1465263009-5535-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at control) by bugs.x2go.org; 7 Jun 2016 01:28:23 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 86DE95DA93;
	Tue,  7 Jun 2016 03:28:21 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id upg+CqDfYP9V; Tue,  7 Jun 2016 03:28:15 +0200 (CEST)
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id F34DE5DB80; Tue,  7 Jun 2016 03:28:08 +0200 (CEST)
From: X2Go Release Manager <git-admin@x2go.org>
To: 993-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 993@bugs.x2go.org
Subject: X2Go issue (in src:x2godesktopsharing) has been marked as closed
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Message-Id: <20160607012808.F34DE5DB80@ymir.das-netzwerkteam.de>
Date: Tue,  7 Jun 2016 03:28:08 +0200 (CEST)

close #993
thanks

Hello,

we are very hopeful that X2Go issue #993 reported by you
has been resolved in the new release (3.1.1.3) of the
X2Go source project »src:x2godesktopsharing«.

You can view the complete changelog entry of src:x2godesktopsharing (3.1.1.3)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2godesktopsharing.

    http://code.x2go.org/gitweb?p=x2godesktopsharing.git;a=commitdiff;h=c1a5867c31f12a44a6dbbf9317ef44272399fa53;hp=3921c42b13af6a2bef5850c53b9baa420ba46351

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2godesktopsharing.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2godesktopsharing
Version: 3.1.1.3-0x2go1
Status: RELEASE
Date: Tue, 07 Jun 2016 03:12:53 +0200
Fixes: 905 936 993
Changes: 
 x2godesktopsharing (3.1.1.3-0x2go1) RELEASED; urgency=low
 .
   [ Mihai Moldovan ]
   * New upstream version (3.1.1.3):
     - x2godesktopsharing_zh_tw: rename to x2godesktopsharing_zh_tw.ts. Oops.
     - x2godesktopsharing.pro: also rename x2godesktopsharing_zh_tw in project
       file.
     - misc: fix X2GO => X2Go and add "Desktop" where missing. Fixes: #936.
     - sharetray.cpp: fix type issues while calculating time difference. Fixes:
       #993.
     - sharetray.cpp: post-fixup: include stdint.h to get (u)intXX_t types.
       Won't work on Windows, but the desktop sharing application isn't
       supposed to run on Windows anyway...
   * debian/control:
     - Drop libqt4-gui Depends. Already handled by shlibs and misc Depends.
       Fixes: #905.


------------=_1465263009-5535-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.x2go.org; 6 Feb 2016 21:01:14 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=3.0 tests=BAYES_40,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id B0A823BC4B
	for <submit@bugs.x2go.org>; Sat,  6 Feb 2016 22:01:11 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lMuhx0ifWdtc for <submit@bugs.x2go.org>;
	Sat,  6 Feb 2016 22:01:11 +0100 (CET)
Received: from mail.nwra.com (mail.nwra.com [72.52.192.72])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 37B833BC4A
	for <submit@bugs.x2go.org>; Sat,  6 Feb 2016 22:01:11 +0100 (CET)
Received: from gandalf.local (c-73-229-183-36.hsd1.co.comcast.net [73.229.183.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by mail.nwra.com (Postfix) with ESMTPSA id 27E44340523
	for <submit@bugs.x2go.org>; Sat,  6 Feb 2016 13:01:09 -0800 (PST)
To: submit@bugs.x2go.org
From: Orion Poplawski <orion@cora.nwra.com>
Subject: gcc 6 compile error
Message-ID: <56B65F14.6070407@cora.nwra.com>
Date: Sat, 6 Feb 2016 14:01:08 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------010703040700060707090306"

This is a multi-part message in MIME format.
--------------010703040700060707090306
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

Package: x2godesktopsharing
Version: 3.1.1.2

x2godesktopsharing fails to compile with gcc 6 with:

sharetray.cpp: In constructor 'ShareTray::ShareTray()':
sharetray.cpp:97:46: error: call of overloaded 'abs(uint)' is ambiguous
       QDateTime::currentDateTime().toTime_t() ) <5 )
                                               ^
In file included from /usr/include/c++/6.0.0/cstdlib:75:0,
                  from /usr/include/c++/6.0.0/bits/stl_algo.h:59,
                  from /usr/include/c++/6.0.0/algorithm:62,
                  from /usr/include/QtCore/qglobal.h:68,
                  from /usr/include/QtCore/qnamespace.h:45,
                  from /usr/include/QtCore/qobjectdefs.h:45,
                  from /usr/include/QtGui/qwindowdefs.h:45,
                  from /usr/include/QtGui/qwidget.h:46,
                  from /usr/include/QtGui/qmainwindow.h:45,
                  from /usr/include/QtGui/QMainWindow:1,
                  from sharetray.h:14,
                  from sharetray.cpp:12:
/usr/include/stdlib.h:774:12: note: candidate: int abs(int)
  extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
             ^~~
In file included from /usr/include/c++/6.0.0/bits/stl_algo.h:59:0,
                  from /usr/include/c++/6.0.0/algorithm:62,
                  from /usr/include/QtCore/qglobal.h:68,
                  from /usr/include/QtCore/qnamespace.h:45,
                  from /usr/include/QtCore/qobjectdefs.h:45,
                  from /usr/include/QtGui/qwindowdefs.h:45,
                  from /usr/include/QtGui/qwidget.h:46,
                  from /usr/include/QtGui/qmainwindow.h:45,
                  from /usr/include/QtGui/QMainWindow:1,
                  from sharetray.h:14,
                  from sharetray.cpp:12:
/usr/include/c++/6.0.0/cstdlib:180:3: note: candidate: long long int 
std::abs(long long int)
    abs(long long __x) { return __builtin_llabs (__x); }
    ^~~
/usr/include/c++/6.0.0/cstdlib:172:3: note: candidate: long int 
std::abs(long int)
    abs(long __i) { return __builtin_labs(__i); }
    ^~~

The attached patch casts the result to an int.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

--------------010703040700060707090306
Content-Type: text/x-patch;
 name="x2godesktopsharing-time.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="x2godesktopsharing-time.patch"

diff -up x2godesktopsharing-3.1.1.2/sharetray.cpp.time x2godesktopsharing-3.1.1.2/sharetray.cpp
--- x2godesktopsharing-3.1.1.2/sharetray.cpp.time	2015-03-05 21:11:16.000000000 -0700
+++ x2godesktopsharing-3.1.1.2/sharetray.cpp	2016-02-06 13:57:28.437811687 -0700
@@ -93,8 +93,8 @@ ShareTray::ShareTray()
 			{
 				QString line = in.readLine();
 				file.close();
-				if ( abs ( line.toUInt() -
-					QDateTime::currentDateTime().toTime_t() ) <5 )
+				if ( abs ( int ( line.toUInt() -
+					QDateTime::currentDateTime().toTime_t() ) ) <5 )
 					{
 
 					QString message=QString (

--------------010703040700060707090306--

------------=_1465263009-5535-0--
