From b.orkun@gmail.com Wed Jan 27 23:26:56 2016 Received: (at 987) by bugs.x2go.org; 27 Jan 2016 22:26:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 868E85DA90 for <987@bugs.x2go.org>; Wed, 27 Jan 2016 23:26:56 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tSqJ7Jb1jIKu for <987@bugs.x2go.org>; Wed, 27 Jan 2016 23:26:56 +0100 (CET) Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 35ABD5DA8E for <987@bugs.x2go.org>; Wed, 27 Jan 2016 23:26:56 +0100 (CET) Received: by mail-lf0-f54.google.com with SMTP id c192so15661238lfe.2 for <987@bugs.x2go.org>; Wed, 27 Jan 2016 14:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Cjjyw08Qd7XN/MKZH+kLRovL/WGI+vQMe5NuWpvGg+g=; b=gncLkOmKUT6e8TZoP5iksMGTp4OK0vQKq9WVBo/d3+PNqW3dU5JgwbXyCYpIMmhL1h uQbyBeme9UnbQe34rQv0tVejsK40ku7W4hzh6JAuccYJ0vJR+DpZbuLrS1M2HhWOPzaR zjGHFuWSYLfyN5qqfvdIlp2cBO1JXTOA5dMCOPSTLKXTqPxI8jixTPczbH0A3NPTMSZ8 SFugNYrB9j14izr+Q94bO7Afqg+a2PfJ2bbG8zVlaeoBwfJRhy1HMShYF8fOVoaic268 c69oh6gwiXk7fC7vSLHopB6PCS+d4RRGhVUg6RCH3hS/8YH6xb2de8gJGAUhRzW12SqQ TMcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Cjjyw08Qd7XN/MKZH+kLRovL/WGI+vQMe5NuWpvGg+g=; b=E0UA2hgNTV0w8ZDH8eN7CKm/VuxqVknHWx2WHo2GtIy3pvdPzLc8QoKlquY/MZQ1++ FLwMjhBF/WqKa33XRBxFcHhw9T4zR1f0E2eGLKHB1+ZcCfash7fvDrnOo626SfpBLJQK NBpEB78KkPRXGabp4zJ3LPZBMHpSSzMq3XTtCd1Fjs3PVkXRfFle1bG6GPgpUJAGXkjw eaLBvYnhrCcXGzroK+qXSIdnYjutZuzc+mBK0kRirNPQOvqybS2j6eIGvjEz0ryuoVxb l0TCOUSzv+kbWIBDI0+bL8greRbpOUSk8yO5UPRoQMkqbOcrB02cYkP1SlZkLToj1BeP Hvvg== X-Gm-Message-State: AG10YOTyyivMMZ+xV9dXFBZnqFbCCpn2fxkvqzWz3EconMxr+7WtEchoZxwczNxNESx89ITcvNl/4Pk9fHMKlA== MIME-Version: 1.0 X-Received: by 10.25.154.207 with SMTP id c198mr12327471lfe.32.1453933615712; Wed, 27 Jan 2016 14:26:55 -0800 (PST) Received: by 10.25.77.18 with HTTP; Wed, 27 Jan 2016 14:26:55 -0800 (PST) In-Reply-To: <56A8D7DD.5040202@ionic.de> References: <56A8D7DD.5040202@ionic.de> Date: Thu, 28 Jan 2016 00:26:55 +0200 Message-ID: Subject: Re: [X2Go-Dev] Bug#987: .ts Files Name Mismatch Problem From: Orkun BALCI To: Mihai Moldovan Cc: 987@bugs.x2go.org Content-Type: multipart/alternative; boundary=001a11401628b112cb052a584c05 --001a11401628b112cb052a584c05 Content-Type: text/plain; charset=UTF-8 Thank you Mihai, In the code and in the error it exactly seeks for x2goclient_tr_tr (or x2goclient_tr_TR depending on version) file. However, when I read the link you sent, I got that there can be another wrong character in the name. In this link it says x2goclient.tr_TR or x2goclient.tr are the correct front names of it. So, there can be an underscore or dot character problem. Well, I have forked the code to my github repository today, and I will have a look at it when I find some free time. So, I will inform you back about the further work. Best Regards, Orkun BALCI On Wed, Jan 27, 2016 at 4:44 PM, Mihai Moldovan wrote: > On 27.01.2016 09:03 AM, Orkun BALCI wrote: > > Package: x2goclient (Debian) Version: 4.0.5.0-1 > > > > In Qt Resources, translation files (.ts) filenames ends with a > > preceeding underscore and two character (like _tr, _en, etc.) > > However, locale names are in the form tr_TR or en_US. Because > > x2goclient reads from :/i18n/[filename] Qt Resource file, it cannot > > find a file named x2goclient_tr_TR, x2goclient_en_US, qt_tr_TR, or > > qt_en_US. .ts file names should be changed from trailing two > > character to four character full locale name. > > I disagree, let me explain why. > > We're using QTranslator::load(), which, according to the documentation, > should try to load stripped file names, too, c.f.: > https://doc.qt.io/qt-4.8/qtranslator.html#load > > The important part is the fallback list for fr_ca. Eventually, it should > be able to load :/i18n/x2goclient_tr.qm (and thus also :/i18n/qt_tr.qm.) > > Are you seeing different, wrong behavior? > > > > Mihai > > --001a11401628b112cb052a584c05 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thank you Mihai,

In the code and in the= error it exactly seeks for x2goclient_tr_tr (or x2goclient_tr_TR depending= on version) file. However, when I read the link you sent, I got that there= can be another wrong character in the name. In this link it says x2goclien= t.tr_TR or x2goclient.tr are the corre= ct front names of it. So, there can be an underscore or dot character probl= em.

Well, I have forked the code to my github repo= sitory today, and I will have a look at it when I find some free time. So, = I will inform you back about the further work.

Bes= t Regards,
Orkun BALCI


On Wed, Jan 27, 2016 at 4:44 PM, = Mihai Moldovan <ionic@ionic.de> wrote:
On 27.01.2016 09:03 AM, O= rkun BALCI wrote:
> Package: x2goclient (Debian) Version: 4.0.5.0-1
>
> In Qt Resources, translation files (.ts) filenames ends with a
> preceeding underscore and two character (like _tr, _en, etc.)
> However, locale names are in the form tr_TR or en_US. Because
> x2goclient reads from :/i18n/[filename] Qt Resource file, it cannot > find a file named x2goclient_tr_TR, x2goclient_en_US, qt_tr_TR, or
> qt_en_US. .ts file names should be changed from trailing two
> character to four character full locale name.

I disagree, let me explain why.

We're using QTranslator::load(), which, according to the documentation,= should try to load stripped file names, too, c.f.: ht= tps://doc.qt.io/qt-4.8/qtranslator.html#load

The important part is the fallback list for fr_ca. Eventually, it should be= able to load :/i18n/x2goclient_tr.qm (and thus also :/i18n/qt_tr.qm.)

Are you seeing different, wrong behavior?



Mihai


--001a11401628b112cb052a584c05--