X2Go Bug report logs - #949
Shell variable name conflict

version graph

Packages: x2goserver_4.0.1.19-0~1064~ubuntu14.04.1, server, ubuntu; Maintainer for x2goserver_4.0.1.19-0~1064~ubuntu14.04.1 is (unknown); Maintainer for server is (unknown); Maintainer for ubuntu is (unknown);

Reported by: Michael <ayuanx@gmail.com>

Date: Fri, 25 Sep 2015 03:40:01 UTC

Severity: normal

Tags: not-a-bug

Found in version 4.0.1.19-0~1064

Done: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 949@bugs.x2go.org (full text, mbox, reply):

Received: (at 949) by bugs.x2go.org; 28 Sep 2015 06:26:17 +0000
From mike.gabriel@das-netzwerkteam.de  Mon Sep 28 08:26:14 2015
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A54ED5DA93
	for <949@bugs.x2go.org>; Mon, 28 Sep 2015 08:26:14 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 528ED435F;
	Mon, 28 Sep 2015 08:26:14 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id EF5723BBFB;
	Mon, 28 Sep 2015 08:26:13 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 5SFjmP9CojkC; Mon, 28 Sep 2015 08:26:13 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 5C3BF3B9C0;
	Mon, 28 Sep 2015 08:26:13 +0200 (CEST)
Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de
 [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Mon, 28 Sep 2015 06:26:13 +0000
Date: Mon, 28 Sep 2015 06:26:13 +0000
Message-ID: <20150928062613.Horde.HtUkQaPEtERl-dHIu15rsA2@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Michael <ayuanx@gmail.com>, 949@bugs.x2go.org
Subject: Re: [X2Go-Dev] Bug#949: Shell variable name conflict
In-Reply-To: <CAPuhghWxw_fbjpx3QK_gaz9DDMxY4Lg+UHkbiPPbW9sgAjaC4w@mail.gmail.com>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 178.62.101.154
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_B7bRw0VtWGRe_WW6KpLVWQ1";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Control: close -1
Control: tags -1 not-a-bug

Dear Michael,

On  Fr 25 Sep 2015 05:38:07 CEST, Michael wrote:

> Package: (Ubuntu server) x2goserver_4.0.1.19-0~1064~ubuntu14.04.1
> Version: 4.0.1.19-0~1064
>
> The name of shell variable ${STARTUP} defined by x2goserver is too common.
>> $ echo $STARTUP
>> /usr/bin/dbus-launch --exit-with-session /usr/bin/im-launch  
>> /usr/bin/env  
>> LD_LIBRARY_PATH=/usr/lib/nx/X11/Xinerama:/usr/lib/nx/X11  
>> xfce4-session
>
> It would easily cause conflicts with other things. (Took me a week  
> to debug :()
>
> Could you please consider changing it to some more specific name like
> "X2GO_STARTUP"?
>
> Thanks!

The $STARTUP env variable will be set for every Xsession based X11  
session on a Ubuntu or Debian (and alike).

Please do a grep on /etc/X11 and see its output (grep -r STARTUP /etc/X11).

In case you want to use $STARTUP in your own scripts, please know that  
it is not a good idea to use that var name on Debian nor Ubuntu systems.

Using X2GO_STARTUP or any other variable name will not work with  
existing scripts in /etc/X11/Xsessions.d. Thus, closing this issue and  
tagging as "not-a-bug".

Greets,
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Sun Nov 24 11:19:43 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.