From unknown Wed Apr 29 13:07:03 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#945: [X2Go-Dev] Bug#945: Fwd: [Bug 1264609] New: [abrt] x2goclient: publickey_to_string(): x2goclient killed by SIGSEGV Reply-To: Orion Poplawski , 945@bugs.x2go.org Resent-From: Orion Poplawski Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 22 Sep 2015 03:50:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 945 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 945-submit@bugs.x2go.org id=B945.14428936011956 (code B ref 945); Tue, 22 Sep 2015 03:50:01 +0000 Received: (at 945) by bugs.x2go.org; 22 Sep 2015 03:46:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail.nwra.com (mail.nwra.com [72.52.192.72]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id AEF205DA7F for <945@bugs.x2go.org>; Tue, 22 Sep 2015 05:46:37 +0200 (CEST) Received: from pacas.cora.nwra.com (c-71-237-72-91.hsd1.co.comcast.net [71.237.72.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.nwra.com (Postfix) with ESMTPSA id 1F2F93404A5 for <945@bugs.x2go.org>; Mon, 21 Sep 2015 20:46:33 -0700 (PDT) References: <55FDB5C3.5050408@cora.nwra.com> To: 945@bugs.x2go.org From: Orion Poplawski Message-ID: <5600CF17.1010406@cora.nwra.com> Date: Mon, 21 Sep 2015 21:46:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55FDB5C3.5050408@cora.nwra.com> Content-Type: multipart/mixed; boundary="------------050008020009080508040706" This is a multi-part message in MIME format. --------------050008020009080508040706 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Tags: patch The attached patch should fix the segfault. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA/CoRA Division FAX: 303-415-9702 3380 Mitchell Lane orion@cora.nwra.com Boulder, CO 80301 http://www.cora.nwra.com --------------050008020009080508040706 Content-Type: text/x-patch; name="x2goclient-pubkey.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="x2goclient-pubkey.patch" diff -up x2goclient-4.0.5.0/src/sshmasterconnection.cpp.pubkey x2goclient-4.0.5.0/src/sshmasterconnection.cpp --- x2goclient-4.0.5.0/src/sshmasterconnection.cpp.pubkey 2015-07-27 20:50:35.000000000 -0600 +++ x2goclient-4.0.5.0/src/sshmasterconnection.cpp 2015-09-21 21:38:43.318974144 -0600 @@ -1091,7 +1091,7 @@ bool SshMasterConnection::userAuthWithKe return false; } ssh_public_key pubkey=publickey_from_privatekey(prkey); - if (!prkey) + if (!pubkey) { #ifdef DEBUG x2goDebug<<"Failed to get public key from private key."<