From unknown Wed Apr 08 12:25:59 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: git-admin@x2go.org From: git-admin@x2go.org (X2Go Bug Tracking System) Subject: Bug#91 closed by Mike Gabriel (Patch idea applied to python-x2go, pyhoca-gui, pyhoca-cli, x2gobroker) Message-ID: References: <20121220092403.18395549dj0l4y77@mail.das-netzwerkteam.de> X-X2go-PR-Keywords: patch X-X2go-PR-Message: they-closed 91 X-X2go-PR-Package: pyhoca-gui Date: Thu, 20 Dec 2012 08:33:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1355992382-25014-0" This is a multi-part message in MIME format... ------------=_1355992382-25014-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the pyhoca-gui package: #91: Don't import pyhoca.wxgui just for the version in setup.py It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 X2Go Bug Tracking System Contact git-admin@x2go.org with problems ------------=_1355992382-25014-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 20 Dec 2012 08:24:04 +0000 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 792BD5DA6C; Thu, 20 Dec 2012 09:24:04 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 4B8DABB4; Thu, 20 Dec 2012 09:24:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 3D7593BBF1; Thu, 20 Dec 2012 09:24:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xSTOSR4bMrGS; Thu, 20 Dec 2012 09:24:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 1DF363BC02; Thu, 20 Dec 2012 09:24:04 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 012033BBF1; Thu, 20 Dec 2012 09:24:03 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on grimnir.das-netzwerkteam.de X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 running as userid= X-Spam-Level: X-Spam-Bayes-Score: 0.0000 Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33) id B26733BC02; Thu, 20 Dec 2012 09:24:03 +0100 (CET) Received: from nocatv2.tng.de (nocatv2.tng.de [213.178.75.58]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 20 Dec 2012 09:24:03 +0100 Message-ID: <20121220092403.18395549dj0l4y77@mail.das-netzwerkteam.de> X-Priority: 3 (Normal) Date: Thu, 20 Dec 2012 09:24:03 +0100 From: Mike Gabriel To: 91@bugs.x2go.org Cc: control@bugs.x2go.org Subject: Patch idea applied to python-x2go, pyhoca-gui, pyhoca-cli, x2gobroker MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_5298wmkdz0o3"; protocol="application/pgp-signature"; micalg="pgp-sha1" Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.3.4) This message is in MIME format and has been PGP signed. --=_5298wmkdz0o3 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit close #91 thanks Hi Orion, the idea behind the patch you provided has been applied to all Python based X2Go projects: http://code.x2go.org/gitweb?p=pyhoca-cli.git;a=commitdiff;h=a13a51e90ea824cf730c66e5c3b4fe24ece82b5b http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=04f5e0f727bb0886dd28c868419ea4dfdbd491f0 http://code.x2go.org/gitweb?p=python-x2go.git;a=commitdiff;h=6618320451923230d75f1e9190dbff9502052b6a http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=b518fc866f0a3554e45d12902b1a8b21596f8e4e I have just tested the builds of pyhoca-gui and pyhoca-cli with most of the python packages removed from build-deps. Building in chroot is much faster now due to a smaller set of build-deps... Thanks a lot (again) for this one!!! Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb --=_5298wmkdz0o3 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Unterschrift Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAABAgAGBQJQ0ssjAAoJEJr0azAldxsxUE8P/3+kYtTJyASyreEikDm4+iN7 9C6mnHcpDNJV9q6oL0da2mvKCi4icPFTAzSN+djEh5qIRkfYavWvC35uHZXdCqHc DKy6iHJHf7vNaPDTcw+vjm8GZq2+KbgBxKImb9DiQpcXIyVbuMJnEgZyH+SwJL92 RnZl6vCxqNtTDGUImgcMPvdJYduYMIq/Kk4dkub6/eUmfXsctt4mu+MaPOOWBmsQ f8nlFTU9+XDkKX6Iv09El/LWjhtcCblWWEd06lBJ8++RQzRfNKLRHhDfKSLyfzmR pw0AT83qEPbF/WcVvn5kDL2IUt+UzgKUFY3GQFxWW5M9ytF/jYQR+nnD7gRFYJoQ mO1F+olJRCswIP9vUI1JCg0Iaq8BJ4SHMP1xKxBCdbWo1FvDXBt75M1qYudhBky5 wtoOLXcECqXjsLEQgdI67M+ekV//3/MeqBdf6GRuAF7t8vCmtZeEKL1qjJjrcbDu 2CLoFz+Io2G09Xgj42qeyXdjBl3gb2uogyKIC6bU75mqhwM8ouO7rXlcIeMJ8ui4 yG6D5rBUdmyqznMKTYDxhIFIhT6RYwCcDiYhEDUL/1Ew5OvBL9PycGuNQtA/dZuu st4zN8CqxkqaVxkq3ex3S+1iE7I6Wr+Uf+TxZN/iS3tXtn6P2T4ubXadBn3Rq0IQ OhkExUDzzHeB6v0F8fwi =ehqh -----END PGP SIGNATURE----- --=_5298wmkdz0o3-- ------------=_1355992382-25014-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 18 Dec 2012 17:00:51 +0000 Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165]) by ymir (Postfix) with ESMTPS id 56E625DA6C for ; Tue, 18 Dec 2012 18:00:51 +0100 (CET) Received: from barry.cora.nwra.com (barry.cora.nwra.com [10.10.20.7]) (authenticated bits=0) by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id qBIH0n0A001977 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 18 Dec 2012 10:00:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com; s=default; t=1355850049; bh=/pvXvDJqMHsLY8j6dykVr+pccWc93IO+LKgHS1PTlGY=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=souf+6VLUS3xZRZKrggOxbO7siCbvumeviRYPfN9l9C8lakX4JuDiUUaxph9GpQbM a7oLsfvvfXeKtGJN7cSy7y5J9Bj2IU7M0ay+Qp4up4YRzef6+svl8vPEKWXOeOvr5M 2xgV+tLfnIJGBvSXGf7Z/ez2ReOiVy+GAtlw+C4M= Message-ID: <50D0A141.4090902@cora.nwra.com> Date: Tue, 18 Dec 2012 10:00:49 -0700 From: Orion Poplawski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Don't import pyhoca.wxgui just for the version in setup.py Content-Type: multipart/mixed; boundary="------------020209040504070505030008" This is a multi-part message in MIME format. --------------020209040504070505030008 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Package: pyhoca-gui Version: 0.2.1.1 Tags: patch Importing all of pyhoca.wxgui in setup.py causes rpmbuild problems due to DISPLAY not being set. It is overkill as well, causing extra dependencies to be installed at build time. The attached patch fixes. Something similar can be done for the other python packages as well. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 http://www.nwra.com --------------020209040504070505030008 Content-Type: text/x-patch; name="pyhoca-gui-version.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="pyhoca-gui-version.patch" diff -up pyhoca-gui-0.2.1.1/setup.py.version pyhoca-gui-0.2.1.1/setup.py --- pyhoca-gui-0.2.1.1/setup.py.version 2012-12-18 05:02:18.000000000 -0700 +++ pyhoca-gui-0.2.1.1/setup.py 2012-12-18 09:56:38.711286882 -0700 @@ -21,11 +21,13 @@ # import the PyHoca-GUI import sys import os -import pyhoca.wxgui PROGRAM_NAME = 'PyHoca-GUI' PROGRAM_DESC = '%s is a cross-platform (Windows, MacOS X, Linux) graphical X2Go client.' % PROGRAM_NAME -PROGRAM_VERSION = pyhoca.wxgui.__VERSION__ +for line in file(os.path.join('pyhoca', 'wxgui', '__init__.py')).readlines(): + if (line.startswith('__VERSION__')): + exec(line.strip()) +PROGRAM_VERSION = __VERSION__ PROGRAM_ICON = "pixmaps/pyhoca_x2go-logo-ubuntu.ico" LICENSE = 'AGPLv3+' AUTHOR = 'Mike Gabriel, Dick Kniep' --------------020209040504070505030008-- ------------=_1355992382-25014-0--