Subject: Bug#91 closed by Mike Gabriel <[email-masked]> (Patch idea applied to python-x2go, pyhoca-gui, pyhoca-cli, x2gobroker)

From: [email-masked] (X2Go Bug Tracking System)
Date: Thu, 20 Dec 2012 08:33:02 +0000

This is an automatic notification regarding your Bug report
which was filed against the pyhoca-gui package:

#91: Don't import pyhoca.wxgui just for the version in setup.py

It has been closed by Mike Gabriel <[email-masked]>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <[email-masked]> by
replying to this email.

-- 
X2Go Bug Tracking System
Contact [email-masked] with problems

Subject: Patch idea applied to python-x2go, pyhoca-gui, pyhoca-cli, x2gobroker
From: Mike Gabriel <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Thu, 20 Dec 2012 09:24:03 +0100

close #91
thanks

Hi Orion,

the idea behind the patch you provided has been applied to all Python  
based X2Go projects:

http://code.x2go.org/gitweb?p=pyhoca-cli.git;a=commitdiff;h=a13a51e90ea824cf730c66e5c3b4fe24ece82b5b
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=04f5e0f727bb0886dd28c868419ea4dfdbd491f0
http://code.x2go.org/gitweb?p=python-x2go.git;a=commitdiff;h=6618320451923230d75f1e9190dbff9502052b6a
http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=b518fc866f0a3554e45d12902b1a8b21596f8e4e

I have just tested the builds of pyhoca-gui and pyhoca-cli with most  
of the python packages removed from build-deps. Building in chroot is  
much faster now due to a smaller set of build-deps...

Thanks a lot (again) for this one!!!

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: [email-masked], http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Subject: Don't import pyhoca.wxgui just for the version in setup.py
From: Orion Poplawski <[email-masked]>
To: [email-masked]
Date: Tue, 18 Dec 2012 10:00:49 -0700

Package: pyhoca-gui
Version: 0.2.1.1
Tags: patch

Importing all of pyhoca.wxgui in setup.py causes rpmbuild problems due to 
DISPLAY not being set.  It is overkill as well, causing extra dependencies to 
be installed at build time.  The attached patch fixes.

Something similar can be done for the other python packages as well.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       [email-masked]
Boulder, CO 80301                   http://www.nwra.com
diff -up pyhoca-gui-0.2.1.1/setup.py.version pyhoca-gui-0.2.1.1/setup.py
--- pyhoca-gui-0.2.1.1/setup.py.version	2012-12-18 05:02:18.000000000 -0700
+++ pyhoca-gui-0.2.1.1/setup.py	2012-12-18 09:56:38.711286882 -0700
@@ -21,11 +21,13 @@
 # import the PyHoca-GUI
 import sys
 import os
-import pyhoca.wxgui
 
 PROGRAM_NAME = 'PyHoca-GUI'
 PROGRAM_DESC = '%s is a cross-platform (Windows, MacOS X, Linux) graphical X2Go client.' % PROGRAM_NAME
-PROGRAM_VERSION = pyhoca.wxgui.__VERSION__
+for line in file(os.path.join('pyhoca', 'wxgui', '__init__.py')).readlines():
+    if (line.startswith('__VERSION__')):
+        exec(line.strip())
+PROGRAM_VERSION = __VERSION__
 PROGRAM_ICON = "pixmaps/pyhoca_x2go-logo-ubuntu.ico"
 LICENSE = 'AGPLv3+'
 AUTHOR = 'Mike Gabriel, Dick Kniep'