X2Go Bug report logs - #887
cups-x2go

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.502 (Entity 5.502)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#887 closed by X2Go Release Manager <git-admin@x2go.org> (X2Go
 issue (in src:cups-x2go) has been marked as closed)
Message-ID: <handler.887.c.14347478849636.notifdone@bugs.x2go.org>
References: <20150619210441.785D55DA8B@ymir.das-netzwerkteam.de>
X-X2go-PR-Keywords: pending
X-X2go-PR-Message: they-closed 887
X-X2go-PR-Package: cups-x2go
Date: Fri, 19 Jun 2015 21:05:03 +0000
Content-Type: multipart/mixed; boundary="----------=_1434747903-9820-0"

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your Bug report
which was filed against the cups-x2go package:

#887: cups-x2go

It has been closed by X2Go Release Manager <git-admin@x2go.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact X2Go Release Manager <git-admin@x2go.org> by
replying to this email.


-- 
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

[Message part 2 (message/rfc822, inline)]

From: X2Go Release Manager <git-admin@x2go.org>

To: 887-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 887@bugs.x2go.org

Subject: X2Go issue (in src:cups-x2go) has been marked as closed

Date: Fri, 19 Jun 2015 23:04:41 +0200 (CEST)

close #887
thanks

Hello,

we are very hopeful that X2Go issue #887 reported by you
has been resolved in the new release (3.0.1.3) of the
X2Go source project »src:cups-x2go«.

You can view the complete changelog entry of src:cups-x2go (3.0.1.3)
below, and you can use the following link to view all the code changes
between this and the last release of src:cups-x2go.

    http://code.x2go.org/gitweb?p=cups-x2go.git;a=commitdiff;h=954a91687dc61bde64f1958ff05af1dc9c69dedd;hp=439db8b1b7ced6c90781c818428621f289dd1d06

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:cups-x2go.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:cups-x2go
Version: 3.0.1.3-0x2go1
Status: RELEASE
Date: Fri, 19 Jun 2015 23:02:53 +0200
Fixes: 887
Changes: 
 cups-x2go (3.0.1.3-0x2go1) RELEASED; urgency=low
 .
   [ Mihai Moldovan ]
   * New upstream version (3.0.1.3):
     - cups-x2go: import tempfile() function from File::Temp module.
     - cups-x2go: only repeat the last X, not the whole ".pdfX" string (or the
       like.)
     - cups-x2go: actually print "real" executed command instead of the
       "original" one with placeholders.
     - cups-x2go: read output from ghostscript, don't write a filehandle to the
       temporary file. Fixes a hanging ghostscript call and... well... random
       junk, instead of a "real" PDF file.
     - cups-x2go: use parentheses around function arguments.
     - cups-x2go: fix binmode() call, :raw layer is implicit.
     - cups-x2go: fix print call... Does not allow to separate parameters with
       a comma.
     - cups-x2go: add correct :raw layer to binmode calls.
     - cups-x2go: fix tiny typo.
     - cups-x2go: read data from GS and STDIN in chunks of 8 kbytes, instead of
       everything at once. Handles large print jobs gracefully.
     - cups-x2go: add parentheses to close() calls.
     - cups-x2go: delete PDF and title temporary files automatically.
     - cups-x2go: unlink PS temporary file on-demand in END block. Also move
       closelog to END block, because we want to print diagnosis messages in
       the END block.
     - cups-x2go: don't use unlink() explicitly. Trust File::Temp and our END
       block to clean up correctly.
     - cups-x2go: there is no continue in perl for stepping forward a loop.
       Still not. I keep forgetting that. Use next. (Partly) Fixes: #887.
     - cups-x2go: use the same temp file template for PS, PDF and title files.
       Use appropriate suffixes if necessary when generating PDF and title temp
       files. (Fully) Fixes: #887.
   * debian/control:
     - Add dependencies on perl-modules for core modules and ${perl:Depends}
       for perl itself.
     - Do not depend on perl-modules directly. ${perl:Depends} is already doing
       that implicitly. It depends on perl, which depends on perl-modules.
   * cups-x2go.spec:
     - Add proper dependencies on perl and File::Temp module. Hopefully pulls
       in perl-base with the core modules or the like...

[Message part 3 (message/rfc822, inline)]

From: "Feustel, Thomas" <tf@ksh.com>

To: "submit@bugs.x2go.org" <submit@bugs.x2go.org>

Subject: cups-x2go

Date: Wed, 17 Jun 2015 22:25:31 +0000

[Message part 4 (text/plain, inline)]

Package: cups-x2go
Version: 3.0.1.2 GIT

The name of the pdf-file that a create with the Ghostscript has no ".pdf" file extension and can not open on the windows client on a pdf reader.
The perl command "tempfile" ha a option to set a file extension for the tempfile. (SUFFIX => '.pdf')
Maybe with this option it is enough to have on template for the tempfiles.

The second bug is the continue command and the perl script at line 227 and 275, this is not functional and the if block an bee empty or you working with negation on the if.

Best regards

Thomas Feustel

[Message part 5 (text/html, inline)]

Send a report that this bug log contains spam.