From ionic@ionic.de Wed Jun 24 04:04:48 2015 Received: (at 883) by bugs.x2go.org; 24 Jun 2015 02:04:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A563D5DA85 for <883@bugs.x2go.org>; Wed, 24 Jun 2015 04:04:48 +0200 (CEST) Received: from nopileos.local (home.ionic.de [217.92.117.31]) by mail.ionic.de (Postfix) with ESMTPSA id 2B16C4F04FA9; Wed, 24 Jun 2015 04:04:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1435111488; bh=DRxHwFMZNHqLcB4suR04QjCC3Tp0XDBRJ72rlIinuv0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=WlgGrZPH7d27fWSHOlAmb7MdG/2eduMwb44/l0YibLismYw+8E2+cxSj472UUP2q5 mu47Dc1tzrihcVOdCY3QmpBMet1m0o906sys6fvvIpSzOPKAUgv6NmbnE3wPqXcqEy oQQ7P/sx0GbMHvxeAzuCje3z1Kdiuy23vFlKzE9Y= Subject: Re: [X2Go-Dev] Bug#883: Bug#883: Can be fixed by reverting winmultiwindow.patch To: Oleksandr Shneyder , 883@bugs.x2go.org References: <20150623105115.Horde.cJ1xTsfQZTDIgaforyinLQ1@mail.das-netzwerkteam.de> <5589B201.2070208@phoca-gmbh.de> From: Mihai Moldovan X-Enigmail-Draft-Status: N1110 Message-ID: <558A103B.1030709@ionic.de> Date: Wed, 24 Jun 2015 04:04:43 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <5589B201.2070208@phoca-gmbh.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76J1jwR1XHM22GV7OVxNmCuSVo80Tu3BW" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --76J1jwR1XHM22GV7OVxNmCuSVo80Tu3BW Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 23.06.2015 09:22 PM, Oleksandr Shneyder wrote: > I'll look on it on Thursday-Monday, I've had a look myself and played around with it, assisted by Mike#2. I don't see any benefit in applying this patch and suggest dropping it. As far as I've gathered, it's supposed to create a "fake" fullscreen wind= ow by removing the borders and title bar IFF the window extents are greater or = equal the monitor's size, with "monitor" being the monitor that holds most of t= he window's contents. It doesn't make sense to do something like this in multiwindow mode. It *= does* make sense to do something like this in fullscreen mode, but the patch ta= rgets multiwindow mode. For this mode, it's plain wrong and only causing trouble. You can't fix i= t either, because you're missing a crucial bit of information: when *do* yo= u want to have a "fake" fullscreen window? Why did you write the original patch exactly? What was the use case that = this patch fixed? Mihai --76J1jwR1XHM22GV7OVxNmCuSVo80Tu3BW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJVihA+AAoJEB/WLtluJTqHvl0QAJBj3/vi7GE9iA/GtJDpXBqq /Ql1PYMqDZzmBQAnry6cV7VK52sxQXHikr66AsbbZmN99YdGyrcx2B9kF0wJFMt3 vWJiIi6WpJj14xXttDfzv9OJHtxSQwc/nm2ZrtTDftB3hw2CP0A1sTN6+ONoSdWp JqkLkEtl5Bx4+31SDDz5fs41E8apJnB3wXWAZ/tfDGUfdr4qdD+nOusmaecmStD7 aiwzbreQ0yHtKpUI3mvHf3Epgy8hiRRp4EbXpkag3+X1xnk79sTzJxqw+hQpjrgC s+N3fWrADtrmz9wLv0Tj9265VbjxFjhtRIJdPoLvx3lF/5czEwwMkJbhfMTkwt/H YU28Ug60QrgH0pHcU54Yq+mW3pUSu6hcmgeX+i9KDOTI2Iqs/YqluSHJjGgXwzQ3 jpz7S+N2qeNwSW8+DyQmZ6lu/5jjLZhFsZsWr7G6UFbTrWth7lSvXAu1YYTMgozy +QogE2Lqu3mLKWva0+GEOTNeABlQXpVBVcFq8aNW5zeowjkJr5BNYWS49usp8mIg QRlVgUMJKUqUaVEfnYOZBKgoCftWzhRFpmHdmxqN9EkwGUo1qY4y1OMN85653QP2 sF9ty6Wc5MSxVF8G0DwcpAoGYY4U2pDo0KQjIPfu4x2cfaAbQoNYS5l4FIYICF0F 2X8N5cJtzNjTBqo98UoG =hP3a -----END PGP SIGNATURE----- --76J1jwR1XHM22GV7OVxNmCuSVo80Tu3BW--