X2Go Bug report logs - #866
Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support)

version graph

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Nito Martinez <Nito@Qindel.ES>

Date: Thu, 7 May 2015 22:45:03 UTC

Severity: normal

Tags: fixed-upstream, patch

Found in version 3.5.0.28

Fixed in version 3.5.99.0

Done: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/ArcticaProject/nx-libs/pull/26

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#866: [X2Go-Dev] Bug#866: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support)
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 866@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Fri, 08 May 2015 10:05:02 +0000
Resent-Message-ID: <handler.866.B866.143107939625484@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 866
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by 866-submit@bugs.x2go.org id=B866.143107939625484
          (code B ref 866); Fri, 08 May 2015 10:05:02 +0000
Received: (at 866) by bugs.x2go.org; 8 May 2015 10:03:16 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EEFE75DA80
	for <866@bugs.x2go.org>; Fri,  8 May 2015 12:03:13 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 6D080AAD;
	Fri,  8 May 2015 12:03:13 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C66E83BAC4;
	Fri,  8 May 2015 12:03:12 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id PDEPpt6DKMFj; Fri,  8 May 2015 12:03:12 +0200 (CEST)
Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 682493B99B;
	Fri,  8 May 2015 12:03:12 +0200 (CEST)
Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de
 [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Fri, 08 May 2015 10:03:12 +0000
Date: Fri, 08 May 2015 10:03:12 +0000
Message-ID: <20150508100312.Horde.Iab2cuAyMS--SO_aEOyiaw6@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: Nito Martinez <Nito@qindel.es>, 866@bugs.x2go.org
In-Reply-To: <554BE89D.2030304@Qindel.ES>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.2)
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 134.245.254.97
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101
 Firefox/32.0 Iceweasel/32.0
Content-Type: multipart/signed; boundary="=_pzw2ixTOF-YPllhCnON4tA2";
 protocol="application/pgp-signature"; micalg=pgp-sha1
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Hi Nito,

On  Fr 08 Mai 2015 00:35:09 CEST, Nito Martinez wrote:

> Package: nx-libs
> Version: 3.5.0.28
>
> Description:
>
> The attached patch fixes some compilation errors when the following  
> macros are enabled: (TEST/DEBUG/DUMP). See the lines:
>
> #undef TEST
> #undef DEBUG
> ...
>
> and the conditinal ifdefs
>
> #ifdef TEST
> #ifdef DEBUG
> ...
>
> which are normally not compiled.
>
> During debugging and testing when these macros gets activated, there  
> are some compilation errors, which need to be manually fixed each  
> time the Macros are enabled. This patch tries to leverage that error.
>
> The patch does not affect code outside of those ifdef, and only  
> provides developer support.
>
> Regards,
>
> Nito

We (people from X2Go and Arctica) changed the nx-libs development  
workflow a bit, recently:

Now, we normally file pull requests (even internally in our team,  
except for small fixes) against the nx-libs 3.6.x branch on Github.  
All greater code changes happen for nx-libs 3.6.x first and then get  
backported to 3.5.0.x later (or not at all). All major commits/change  
shall reveive a code review and approval of another dev on the team.

So, the initial bug tracking / pull request tracking for nx-libs has  
been relocated to Github. Bugs for nx-libs on the X2Go bug tracker are  
for marking PRs or commits worth of being backported to the 3.5.0.x  
branch (which is handled by the X2Go devs, mainly Mihai Moldovan at  
the time being).

Basic splitup of workload: Arctica Project context maintains nx-libs  
3.6.x, X2Go context maintains nx-libs 3.5.0.x.

Also, Mihai fixed several TEST/DEBUG/DUMP issues on both branches  
(3.5.0.x and 3.6.x). It may well be that the fixes you provide here  
already exist on 3.5.0.x/HEAD (haven't checked that)?

Thus, could you do these following steps:

  o rebase your patch against nx-libs 3.6.x branch
  o clone https://github.com/ArcticaProject/nx-libs
  o create a pr/<describe-what-your-code-does> branch on your account
  o file a PR against ArcticaProject/nx-libs 3.6.x branch
  o wait for Ionic or me to review

In the future, I'd be happy to welcome you as another potential pull  
request reviewer, so we can distribute the workload even better. Once  
I see your PR, I will grant you write/commit access to nx-libs on  
github.com/ArcticaProject.

Greets,
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:41:56 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.