From unknown Thu Apr 16 19:38:07 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#866 closed by Stefan Baur (Closing/Archiving) Message-ID: References: <55179376-aa6c-4385-91a3-c5e411551930@baur-itcs.de> X-X2go-PR-Keywords: fixed-upstream patch X-X2go-PR-Message: they-closed 866 X-X2go-PR-Package: nx-libs Date: Tue, 30 Jan 2024 22:00:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1706652006-20753-0" This is a multi-part message in MIME format... ------------=_1706652006-20753-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the nx-libs package: #866: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/...= are defined (developer support) It has been closed by Stefan Baur . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Stefan Baur by replying to this email. --=20 866: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D866 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1706652006-20753-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 866-quiet) by bugs.x2go.org; 30 Jan 2024 21:57:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F3DD05DA21 for <866-quiet@bugs.x2go.org>; Tue, 30 Jan 2024 22:57:43 +0100 (CET) Received: from [192.168.0.25] ([178.202.75.45]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MWhxY-1rX1Z90z28-00X0xc for <866-quiet@bugs.x2go.org>; Tue, 30 Jan 2024 22:57:43 +0100 Message-ID: <55179376-aa6c-4385-91a3-c5e411551930@baur-itcs.de> Date: Tue, 30 Jan 2024 22:57:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Stefan Baur Content-Language: en-US To: 866-quiet@bugs.x2go.org Subject: Closing/Archiving Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:X4pnBWr7Ps3ddU2IdMqFqmMPa/TMQ4mvEcQybYIsws0Jnv1gAQz AyqCPXMJ3DwDaM1Eok31XQRDKK2BhxsKYcHZ7LDehJhQrb5BeY1GPL789P2/cFcwFG91CtG nr3jegUD9PK5on0xvAvDvZbpfieYcEgzH4oUcyy125fQqhiDRMDKpGtilWtVmad/6JJAsjE ppTiUHuWS+64+Ui3bvMSA== UI-OutboundReport: notjunk:1;M01:P0:LvL1iV4ouYc=;QXYiSl/mLGa6wFoZjbmGVubXtWL fWLwdwdRlQ++UlIAjVb28k6VvAsCnAKgj6XmyDRNRvZlyw66uYwaT/WFvFUpBxT75aVzYHoE4 eO8DvhClQjcxndRY6ARmOgbkEdZrYwKKuK8/Lq8i6uJPxD5yzSsIVD4irzIXmbHE2dYHlJa9S DNNu4QSn3sp+93azpk3SfS9Slvh3oUcDUTaigMn/ukmo7huqh1FeafRaaijEfeaP50FAM2Km0 /8E3+RUF8U35+kdrnWG2IFtjuAd84lmPmsHizxl0xhtEH2xdTDnO01KK+x4FuWJFzpX9B6DdC fjAAwTbqgF8+ih8AkfYxd9mSYJcwlPWTxhH5dE51j4beuVHh9+5x82jJmHUW8fS6s5i8Ce1b/ a5+ROVg7gSJc+WJQq3Au4V9tiUHDdQ03fE7hvfHMBIRiFUrGH8gR3hIZUEzD/Jb0ALMIk3rqi Um0epbs2C7sAFygBd1eHfiqpGb5JOLMqvL7XGUhUT4ZO309Zi2HkeQ8opMkpEokd4lLF3yxpj wWY9kZA/uOguQKZuVW/OjrEhpTqWqA72iK98HxJTllJXHDQfVdvXGxAGkUk4eTHoXDX2B4LYN xg0Ne4TCGp4eds+uKtEWlVq/MYFMoQ05JEXRWwRs15CNn8CpmFGSZoOzrF//AJ6cQ4ri6PZx+ 8kRAn8eeEva/rt7pnSpKWrrOUUzaP1ppzI/tr420F0EFgSqamJlhNS/TKGzG0UJ2zQXykNfA/ MVKAvPUoXe0t58gypEmmKCJK1/OyaRt/gjqaO4YMerGHX/pVH5Pe3SrOhmiBEtR/30E+alVPZ cmPxg/tWXauURyh7WOFjblkfn/es/YggcZldtlBpEwruYE4KuSJKsJ6Thrvap4jt2xrLHli55 1991qIMoTiM1aTA== Control: close -1 Control: archive -1 This bug has long since been moved to the Arctica Project Github issue tracker. Kind Regards, Stefan Baur -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 ------------=_1706652006-20753-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 7 May 2015 22:43:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,HTML_MESSAGE autolearn=ham version=3.3.2 Received: from thor.qindel.com (smtp.qindel.com [89.140.90.34]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3DCBC5DA80 for ; Fri, 8 May 2015 00:43:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by thor.qindel.com (Postfix) with ESMTP id 9AF6F6020B for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) Received: from thor.qindel.com ([127.0.0.1]) by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hco9KOVYgj1I for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by thor.qindel.com (Postfix) with ESMTP id 24A8D6020D for ; Fri, 8 May 2015 00:35:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at thor.qindel.com Received: from thor.qindel.com ([127.0.0.1]) by localhost (thor.qindel.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3QukMzDm-Hvr for ; Fri, 8 May 2015 00:35:09 +0200 (CEST) Received: from [10.1.0.254] (qvd-254.int.qindel.com [172.26.11.254]) by thor.qindel.com (Postfix) with ESMTPSA id E99E06020B for ; Fri, 8 May 2015 00:35:09 +0200 (CEST) Message-ID: <554BE89D.2030304@Qindel.ES> Date: Fri, 08 May 2015 00:35:09 +0200 From: Nito Martinez User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) Content-Type: multipart/mixed; boundary="------------080608060800020002070205" This is a multi-part message in MIME format. --------------080608060800020002070205 Content-Type: multipart/alternative; boundary="------------090100070408080602080009" --------------090100070408080602080009 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Package: nx-libs Version: 3.5.0.28 Description: The attached patch fixes some compilation errors when the following macros are enabled: (TEST/DEBUG/DUMP). See the lines: #undef TEST #undef DEBUG ... and the conditinal ifdefs #ifdef TEST #ifdef DEBUG ... which are normally not compiled. During debugging and testing when these macros gets activated, there are some compilation errors, which need to be manually fixed each time the Macros are enabled. This patch tries to leverage that error. The patch does not affect code outside of those ifdef, and only provides developer support. Regards, Nito --------------090100070408080602080009 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Package: nx-libs
Version: 3.5.0.28

Description:

The attached patch fixes some compilation errors when the following macros are enabled: (TEST/DEBUG/DUMP). See the lines:

#undef TEST
#undef DEBUG
...

and the conditinal ifdefs

#ifdef TEST
#ifdef DEBUG
...

which are normally not compiled.

During debugging and testing when these macros gets activated, there are some compilation errors, which need to be manually fixed each time the Macros are enabled. This patch tries to leverage that error.

The patch does not affect code outside of those ifdef, and only provides developer support.

Regards,

Nito

 --------------090100070408080602080009-- --------------080608060800020002070205 Content-Type: text/x-diff; name="macro_debugging.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="macro_debugging.patch" diff --git a/nxcomp/Agent.h b/nxcomp/Agent.h index fac5acd..1a59412 100644 --- a/nxcomp/Agent.h +++ b/nxcomp/Agent.h @@ -205,7 +205,7 @@ class Agent { #if defined(TEST) || defined(INFO) *logofs << "Agent: proxyCanRead() is " - << ((int) FD_ISSET(proxy -> getFd(), readSet) + << ((int) FD_ISSET(proxy -> getFd(), readSet)) << ".\n" << logofs_flush; #endif diff --git a/nxcomp/ClearArea.cpp b/nxcomp/ClearArea.cpp index 7b693c7..81beb1e 100644 --- a/nxcomp/ClearArea.cpp +++ b/nxcomp/ClearArea.cpp @@ -92,7 +92,7 @@ void ClearAreaStore::dumpIdentity(const Message *message) const ClearAreaMessage *clearArea = (ClearAreaMessage *) message; - *logofs << name() << ": Identity exposures " << clearArea -> (unsigned int) exposures + *logofs << name() << ": Identity exposures " << (unsigned int) clearArea -> exposures << ", window " << clearArea -> window << ", x " << clearArea -> x << ", y " << clearArea -> y << ", width " << clearArea -> width << ", height " << clearArea -> height << ", size " << clearArea -> size_ diff --git a/nxcomp/Proxy.cpp b/nxcomp/Proxy.cpp index 7258fcf..b4b23a9 100644 --- a/nxcomp/Proxy.cpp +++ b/nxcomp/Proxy.cpp @@ -5169,7 +5169,7 @@ char *Proxy::handleSaveAllStores(const char *savePath) const *(cacheDumpName + DEFAULT_STRING_LENGTH - 1) = '\0'; - mode_t fileMode = umask(0077); + fileMode = umask(0077); cacheDump = new ofstream(cacheDumpName, ios::out); diff --git a/nxcomp/ServerChannel.cpp b/nxcomp/ServerChannel.cpp index 52551e7..7f3ef07 100644 --- a/nxcomp/ServerChannel.cpp +++ b/nxcomp/ServerChannel.cpp @@ -5475,7 +5475,7 @@ int ServerChannel::handleColormap(unsigned char &opcode, unsigned char *&buffer, *logofs << "handleColormap: Dumping colormap entries:\n" << logofs_flush; - const unsigned char *p = unpackState_[resource] -> colormap -> data; + const unsigned int *p = unpackState_[resource] -> colormap -> data; for (unsigned int i = 0; i < unpackState_[resource] -> colormap -> entries; i++) --------------080608060800020002070205-- ------------=_1706652006-20753-0--