From mike.gabriel@das-netzwerkteam.de Fri May 8 12:03:14 2015 Received: (at 866) by bugs.x2go.org; 8 May 2015 10:03:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EEFE75DA80 for <866@bugs.x2go.org>; Fri, 8 May 2015 12:03:13 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 6D080AAD; Fri, 8 May 2015 12:03:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C66E83BAC4; Fri, 8 May 2015 12:03:12 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PDEPpt6DKMFj; Fri, 8 May 2015 12:03:12 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 682493B99B; Fri, 8 May 2015 12:03:12 +0200 (CEST) Received: from m-097.informatik.uni-kiel.de (m-097.informatik.uni-kiel.de [134.245.254.97]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 08 May 2015 10:03:12 +0000 Date: Fri, 08 May 2015 10:03:12 +0000 Message-ID: <20150508100312.Horde.Iab2cuAyMS--SO_aEOyiaw6@mail.das-netzwerkteam.de> From: Mike Gabriel To: Nito Martinez , 866@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#866: Fix compilation errors in nxcomp (nx-libs) when macros TEST/DEBUG/... are defined (developer support) In-Reply-To: <554BE89D.2030304@Qindel.ES> User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.254.97 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_pzw2ixTOF-YPllhCnON4tA2"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_pzw2ixTOF-YPllhCnON4tA2 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nito, On Fr 08 Mai 2015 00:35:09 CEST, Nito Martinez wrote: > Package: nx-libs > Version: 3.5.0.28 > > Description: > > The attached patch fixes some compilation errors when the following=20=20 >=20macros are enabled: (TEST/DEBUG/DUMP). See the lines: > > #undef TEST > #undef DEBUG > ... > > and the conditinal ifdefs > > #ifdef TEST > #ifdef DEBUG > ... > > which are normally not compiled. > > During debugging and testing when these macros gets activated, there=20= =20 >=20are some compilation errors, which need to be manually fixed each=20=20 >=20time the Macros are enabled. This patch tries to leverage that error. > > The patch does not affect code outside of those ifdef, and only=20=20 >=20provides developer support. > > Regards, > > Nito We (people from X2Go and Arctica) changed the nx-libs development=20=20 workflow=20a bit, recently: Now, we normally file pull requests (even internally in our team,=20=20 except=20for small fixes) against the nx-libs 3.6.x branch on Github.=20=20 All=20greater code changes happen for nx-libs 3.6.x first and then get=20= =20 backported=20to 3.5.0.x later (or not at all). All major commits/change=20= =20 shall=20reveive a code review and approval of another dev on the team. So, the initial bug tracking / pull request tracking for nx-libs has=20=20 been=20relocated to Github. Bugs for nx-libs on the X2Go bug tracker are=20= =20 for=20marking PRs or commits worth of being backported to the 3.5.0.x=20=20 branch=20(which is handled by the X2Go devs, mainly Mihai Moldovan at=20=20 the=20time being). Basic splitup of workload: Arctica Project context maintains nx-libs=20=20 3.6.x,=20X2Go context maintains nx-libs 3.5.0.x. Also, Mihai fixed several TEST/DEBUG/DUMP issues on both branches=20=20 (3.5.0.x=20and 3.6.x). It may well be that the fixes you provide here=20=20 already=20exist on 3.5.0.x/HEAD (haven't checked that)? Thus, could you do these following steps: o rebase your patch against nx-libs 3.6.x branch o clone https://github.com/ArcticaProject/nx-libs o create a pr/ branch on your account o file a PR against ArcticaProject/nx-libs 3.6.x branch o wait for Ionic or me to review In the future, I'd be happy to welcome you as another potential pull=20=20 request=20reviewer, so we can distribute the workload even better. Once=20= =20 I=20see your PR, I will grant you write/commit access to nx-libs on=20=20 github.com/ArcticaProject. Greets, Mike --=20 DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_pzw2ixTOF-YPllhCnON4tA2 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJVTIngAAoJEJr0azAldxsxFp0QAKu28HqGMmRhJOkji9ePgvTT 70iTH/dTeLWjgIDf3MCHJF68L1WHrJNU5y4VrLuqyYBp/RFdYUcWJXIuXwv0HvHU XXy2Rt04e/G5Uuya0EgwJ169O4Mu52/Y/Iu3PaWHfPCt+FpMr/v6audUYSqL+Mvf +CxtPyvjw4vZTv9h20usPpr8+T49H4uG5FDZecp2vvkmnTWYdjIKb/xuWM+k4nb8 5W2eZuYeR+cWgSpNJoX5aH6qDCfmgJXZZF11HOpE9fEsAaaGleGgEvPPbYc/1n7P xH08jeAmTg5GBRCcTSnRdEXGSQFpMCBxymvTVzcZVqS7k7tcoH9ejEAV4kmBdMs+ q5Bo0pu68YgBDwoY4Qu1u4wT4yZAcxQAF+2Sjf1ZMlvzhLHFwa+uz7ycIa9qjCWd q6r8hGhdSRMMLoZMysC21sFa3ML2NMwNu3ON5usv6pbhfyi74LK5U/ELTBifqMic +xQSfQxT+B8KQY0ZP4a8E/BGTIT9sQaFkVUhYOO/bzi+uqovkvHG39ZX/bqbG511 MdshB+5nQ+0Lc7B1Ymu2U3zZw3VHN704nSuJG2apc22ke/5XOVtoUncPmpQNKGwN Xe+ZBnKSKXTUwIWATxKrS6zkhfg07Vijval0taSmTDZxp6hWLBW5FnlDX//c1NK1 zRy4O9gThjcQOqtl+MVI =dXQj -----END PGP SIGNATURE----- --=_pzw2ixTOF-YPllhCnON4tA2--