X2Go Bug report logs - #84
DESTDIR and OPTFLAGS patches for nx-libs

Package: nx-libs; Maintainer for nx-libs is X2Go Developers <x2go-dev@lists.x2go.org>;

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Wed, 12 Dec 2012 12:03:38 UTC

Severity: normal

Done: Juri Grabowski <x2go@jugra.de>

Bug is archived. No further changes may be made.

Forwarded to https://github.com/ArcticaProject/nx-libs/issues/141

Full log

🔗 View this message in rfc822 format

X-Loop: git-admin@x2go.org
Subject: Bug#84: Hardcoded -O3 in CFLAGS
Reply-To: Jan Engelhardt <jengelh@inai.de>, 84@bugs.x2go.org
Resent-From: Jan Engelhardt <jengelh@inai.de>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: git-admin@x2go.org
Resent-Date: Wed, 09 Jan 2013 14:18:02 +0000
Resent-Message-ID: <handler.84.B84.135774096530868@bugs.x2go.org>
Resent-Sender: git-admin@x2go.org
X-X2Go-PR-Message: followup 84
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by 84-submit@bugs.x2go.org id=B84.135774096530868
          (code B ref 84); Wed, 09 Jan 2013 14:18:02 +0000
Received: (at 84) by bugs.x2go.org; 9 Jan 2013 14:16:05 +0000
Received: from ares07.inai.de (ares07.inai.de [5.9.24.206])
	by ymir (Postfix) with ESMTPS id B55D15DB0A
	for <84@bugs.x2go.org>; Wed,  9 Jan 2013 15:16:05 +0100 (CET)
Received: by ares07.inai.de (Postfix, from userid 25121)
	id 9BC5F96A06B1; Wed,  9 Jan 2013 15:16:05 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by ares07.inai.de (Postfix) with ESMTP id 5BA7E96A068E;
	Wed,  9 Jan 2013 15:16:05 +0100 (CET)
Date: Wed, 9 Jan 2013 15:16:05 +0100 (CET)
From: Jan Engelhardt <jengelh@inai.de>
To: Bernard Cafarelli <voyageur@gentoo.org>, 84@bugs.x2go.org, 
    x2go-dev@lists.berlios.de
In-Reply-To: <20130109010011.4f92023b@enterprise.cafarelli.fr>
Message-ID: <alpine.LNX.2.01.1301091514470.30600@nerf07.vanv.qr>
References: <ef1f449976cebc4b8ddb052befd9c231@cafarelli.fr> <alpine.LNX.2.01.1301081706500.14229@nerf07.vanv.qr> <20130109010011.4f92023b@enterprise.cafarelli.fr>
User-Agent: Alpine 2.01 (LNX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Wednesday 2013-01-09 01:00, Bernard Cafarelli wrote:

>Le Tue, 8 Jan 2013 17:07:12 +0100 (CET)
>Jan Engelhardt <jengelh@inai.de> a écrit:
>> Why would autoreconf be rerun if you use ./configure CFLAGS=-O2 
>> CXXFLAGS=-O2?
>
>I meant, without first removing the "-O3" from configure.in (before
>autoreconf)
>
>With current configure.in, setting CXXFLAGS to "-O2" will give this:
>nxcomp $ autoreconf && ./configure && make
>[...]
>g++ -c -O2 -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include
>-Wmissing-declarations -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"
>-DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
>-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -Wall
>-Wpointer-arith   EncodeBuffer.cpp

I tried the following, but it's not taking any effect. Must be some 
!@#$%^& going on.

<<<<

Give user-specified CXXFLAGS/CFLAGS/LDFLAGS/LIBS higher precedence.

---
 nxcomp/Makefile.in     |    6 ++----
 nxcompext/Makefile.in  |   14 +++++++-------
 nxcompshad/Makefile.in |    5 ++---
 nxproxy/Makefile.in    |    4 ++--
 4 files changed, 13 insertions(+), 16 deletions(-)

Index: nx-libs-3.5.0.17/nxcomp/Makefile.in
===================================================================
--- nx-libs-3.5.0.17.orig/nxcomp/Makefile.in
+++ nx-libs-3.5.0.17/nxcomp/Makefile.in
@@ -36,8 +36,7 @@ LIBVERSION=@LIBVERSION@
 #
 
 CXX         = @CXX@
-CXXFLAGS    = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
-              -Wall -Wpointer-arith
+CXXFLAGS    = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CXXFLAGS@
 CXXINCLUDES =
 CXXDEFINES  =
 
@@ -46,8 +45,7 @@ CXXDEFINES  =
 # 
 
 CC          = @CC@
-CCFLAGS     = @CFLAGS@ @X_CFLAGS@ @DEFS@ \
-              -Wall -Wpointer-arith
+CCFLAGS     = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CFLAGS@
 CCINCLUDES  =
 CCDEFINES   =
 
Index: nx-libs-3.5.0.17/nxcompext/Makefile.in
===================================================================
--- nx-libs-3.5.0.17.orig/nxcompext/Makefile.in
+++ nx-libs-3.5.0.17/nxcompext/Makefile.in
@@ -28,26 +28,26 @@ LIBVERSION=@LIBVERSION@
 #
 
 CXX         = @CXX@
-CXXFLAGS    = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
+CXXFLAGS    = @X_CFLAGS@ @DEFS@ \
               -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes \
-              -Wmissing-declarations -Wnested-externs
+              -Wmissing-declarations -Wnested-externs @CXXFLAGS@
 CXXINCLUDES = -I. -I../nxcomp
 CXXDEFINES  =
 
 CC          = @CC@
-CCFLAGS     = @CFLAGS@ @X_CFLAGS@ @DEFS@ \
+CCFLAGS     = @X_CFLAGS@ @DEFS@ \
               -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes \
-              -Wmissing-declarations -Wnested-externs
+              -Wmissing-declarations -Wnested-externs @CFLAGS@
 CCINCLUDES  = -I. -I../nxcomp
 CCDEFINES   =
 
-LDFLAGS     = @LDFLAGS@ -L../nxcomp
-LIBS        = @LIBS@ -lz -lNX_X11 -lXcomp
+LDFLAGS     = -L../nxcomp @LDFLAGS@
+LIBS        = -lz -lNX_X11 -lXcomp @LIBS@
 
 #
 # Only if THREADS is defined
 #
-# LIBS = @LIBS@ -lz -ljpeg -lpthread -lNX_X11 -lXcomp
+# LIBS = -lz -ljpeg -lpthread -lNX_X11 -lXcomp @LIBS@
 #
 
 srcdir      = @srcdir@
Index: nx-libs-3.5.0.17/nxcompshad/Makefile.in
===================================================================
--- nx-libs-3.5.0.17.orig/nxcompshad/Makefile.in
+++ nx-libs-3.5.0.17/nxcompshad/Makefile.in
@@ -31,8 +31,7 @@ LIBVERSION=@LIBVERSION@
 #
 
 CXX         = @CXX@
-CXXFLAGS    = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
-              -Wall -Wpointer-arith
+CXXFLAGS    = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CXXFLAGS@
 CXXINCLUDES =
 CXXDEFINES  =
 
@@ -48,7 +47,7 @@ CCINCLUDES  =
 CCDEFINES   =
 
 LDFLAGS     = @LDFLAGS@
-LIBS        = @LIBS@ -lNX_X11
+LIBS        = -lNX_X11 @LIBS@
 
 #
 # Only if THREADS is defined.
Index: nx-libs-3.5.0.17/nxproxy/Makefile.in
===================================================================
--- nx-libs-3.5.0.17.orig/nxproxy/Makefile.in
+++ nx-libs-3.5.0.17/nxproxy/Makefile.in
@@ -11,9 +11,9 @@ LIBVERSION=@LIBVERSION@
 # -Wredundant-decls
 #
 CXX      = @CXX@
-CXXFLAGS = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \
+CXXFLAGS = @X_CFLAGS@ @DEFS@ \
            -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes \
-           -Wmissing-declarations -Wnested-externs
+           -Wmissing-declarations -Wnested-externs @CXXFLAGS@
 
 CXXINCLUDES = -I. -I../nxcomp

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 21 14:52:07 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.