From unknown Mon Apr 27 19:02:39 2026 X-Loop: git-admin@x2go.org Subject: Bug#84: Hardcoded -O3 in CFLAGS Reply-To: Mike Gabriel , 84@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: git-admin@x2go.org Resent-Date: Wed, 09 Jan 2013 15:18:02 +0000 Resent-Message-ID: Resent-Sender: git-admin@x2go.org X-X2Go-PR-Message: followup 84 X-X2Go-PR-Package: nx-libs X-X2Go-PR-Keywords: Received: via spool by 84-submit@bugs.x2go.org id=B84.135774424411317 (code B ref 84); Wed, 09 Jan 2013 15:18:02 +0000 Received: (at 84) by bugs.x2go.org; 9 Jan 2013 15:10:44 +0000 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 54B655DB0A for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:44 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 2A407D8D for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 1B42D3BA3B for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:44 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nzi4nvrEAGrI for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id EFC1F3BA36 for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C49AF3BA24 for <84@bugs.x2go.org>; Wed, 9 Jan 2013 16:10:43 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on grimnir.das-netzwerkteam.de X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 running as userid= X-Spam-Level: X-Spam-Bayes-Score: 0.0000 Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33) id 6CA313BA34; Wed, 9 Jan 2013 16:10:41 +0100 (CET) Received: from 79-175-142-46.pool.kielnet.net (79-175-142-46.pool.kielnet.net [46.142.175.79]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Wed, 09 Jan 2013 16:10:41 +0100 Message-ID: <20130109161041.118432fsrumy2jch@mail.das-netzwerkteam.de> X-Priority: 3 (Normal) Date: Wed, 09 Jan 2013 16:10:41 +0100 From: Mike Gabriel To: Jan Engelhardt , 84@bugs.x2go.org Cc: Reinhard Tartler , Bernard Cafarelli References: <20130109010011.4f92023b@enterprise.cafarelli.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_2zvymlzm2o35"; protocol="application/pgp-signature"; micalg="pgp-sha1" Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.3.4) This message is in MIME format and has been PGP signed. --=_2zvymlzm2o35 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit Hi Jan, On Mi 09 Jan 2013 15:26:06 CET Jan Engelhardt wrote: > > On Wednesday 2013-01-09 15:21, Reinhard Tartler wrote: >>> +++ nx-libs-3.5.0.17/nxcomp/Makefile.in >>> @@ -36,8 +36,7 @@ LIBVERSION=@LIBVERSION@ >>> # >>> >>> CXX = @CXX@ >>> -CXXFLAGS = @CXXFLAGS@ @X_CFLAGS@ @DEFS@ \ >>> - -Wall -Wpointer-arith >>> +CXXFLAGS = @X_CFLAGS@ @DEFS@ -Wall -Wpointer-arith @CXXFLAGS@ >>> CXXINCLUDES = >>> CXXDEFINES = >>> >> AFAIUI, this is not a fix. Instead of replacing the hardcoded values, >> this patch ensures that all options end behind the hardcoded values. >> This makes it impossible to drop compiler flags that are specified >> within. >> >> This may be fair when your goal is to only change the optimization >> level, but may be insufficient when the goal is a hardened build. > > I don't care about the "hardened" because that is just another case > of "user wants to specify his own CFLAGS". > I had hoped that @CXXFLAGS@ would be those user-specific ones, > but alas, no. > *Total dismay at Makefile authors who still squat on CXXFLAGS* All kind of flags are hard-coded in linux.cf in nx-X11/cf/ (I think). You may know imake better then I do. If you could take another look at it, that would be awesome. Note: LDFLAGS appear to be named LDOPTIONS in nx-X11. Note, that nxcomp, nxcompshad and nxcompext are configured and built from within nx-X11/programs/Xserver/Makefile.in (IIRC, might be the Makfile.in one level up). So the nx* builds are prepared by imake. I guess the only way to address it is to teach imake to let through *FLAGS. The nx-X11 build process is a bummer..., I agree with that. Any help and improvement is really appreciated. Greets + HELP!!! + Arggghhh..., Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb --=_2zvymlzm2o35 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Unterschrift Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAABAgAGBQJQ7YhxAAoJEJr0azAldxsxf+IP+wYD2g5qgEF6C7TXMYBKk7Bz 4RwZJeK2/+AxXb+MGQJxvyiNTLkXDmdL7TfSbMAFFaCqj0oDe8GUOPzUMciCkxyz QIwyl47PCrCamUAyDTeYm9Ozu+u+YImmw5qsVPnLAuyFbTab+C+WrL1yjn71auWd ceORODzjPCc5hX2aBUc/vnZlMmIJeqA8ZEkRPGhWfZSP/9sMls97oS4iE+i+sTXw NHP5u/91n35+/7Lyu6nupI2l3pVDgfUvmJEHzXykB9ABGlceDrXehFi6Ab2pHtMy RqzIyyBhT0mFzX3Yni0oHpaWE1CqoeTK/OKb28DqCX2Jbk4zwO9fHZFDHt/QTx7W b93ZaPYYL90ZPgJc075t+oslX2E4mmyA2vZyMa4y4M+JuMs6v1s55tpcNzK9qmae OPWfft1yoEuFuSrjaWLePRqraTuOjgsR8dHdx++23Kwf9uv2vo7s1P++oKu4PP8w NfuTNmShSU8lGTMuwH+MpyjMKlL9lbQBVUMlp4ehJ3BMHcXlV5xja/WWo7Iw4pBC eAZYfW/0OAQw3iZHgEwjj/VhABoeUcpZKCFXlDNJD8sPq1JI6r4QA7oUcg4647q0 XSBcH72YnglNsAw1SbCns+w5+iaqWdte9xHfkv8J+VXGHoIaZYQhmeAx9TO1P+/v 5tfluAopfhFk8IlJM8HB =H+B3 -----END PGP SIGNATURE----- --=_2zvymlzm2o35--