From mike.gabriel@das-netzwerkteam.de Mon Apr 6 22:35:29 2015 Received: (at 836) by bugs.x2go.org; 6 Apr 2015 20:35:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id AACFF5DAD6 for <836@bugs.x2go.org>; Mon, 6 Apr 2015 22:35:28 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 5355FB88; Mon, 6 Apr 2015 22:35:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id C385B3BC0D; Mon, 6 Apr 2015 22:35:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adKBPvU35iF5; Mon, 6 Apr 2015 22:35:27 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 639193BAED; Mon, 6 Apr 2015 22:35:27 +0200 (CEST) Received: from p5B3BA9FD.dip0.t-ipconnect.de (p5B3BA9FD.dip0.t-ipconnect.de [91.59.169.253]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 06 Apr 2015 20:35:27 +0000 Date: Mon, 06 Apr 2015 20:35:27 +0000 Message-ID: <20150406203527.Horde.hmGer9Igu5FvYHv8MHGCFw1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Jason Alavaliant , 836@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#836: defaults.py X2GOBROKER_SESSIONPROFILE_DEFAULTS height/width/fullscreen values prevents client from setting initial geometry on startup In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.59.169.253 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_l8_rAF5t77ecxBJv6g2V1A7"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_l8_rAF5t77ecxBJv6g2V1A7 Content-Type: text/plain; charset=us-ascii; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Jason, thanks for your feedback on the broker. On Sa 04 Apr 2015 11:01:27 CEST, Jason Alavaliant wrote: > Package: python-x2gobroker > Version: 0.0.3.0 > > In the same vein as the dpi issue noted in bug #834 the presence of=20=20 >=20default values for height, width and fullscreen in the=20=20 >=20/usr/lib/python2.7/dist-packages/x2gobroker/defaults.py file under=20= =20 >=20theX2GOBROKER_SESSIONPROFILE_DEFAULTS section prevent the=20=20 >=20x2goclient --geometry option being used to set what default geometry=20= =20 >=20size (or if to use fullscreen) to be set by the client even if the=20= =20 >=20admin of the x2gobroker setup hasn't defined those values in the=20=20 >=20x2gobroker-sessionprofiles.conf file. > > I'd suggest updating the=20=20 >=20/usr/lib/python2.7/dist-packages/x2gobroker/defaults.py file to=20=20 >=20remove the lines > "u'height': 600," > "u'fullscreen': False," > "u'width': 800," > from the X2GOBROKER_SESSIONPROFILE_DEFAULTS section. > > In my testing with those default value gone; > > * If a height/width/fullscreen values are set in=20=20 >=20x2gobroker-sessionprofiles.conf (which is the default provided in=20=20 >=20the sample config file), then those values are used by the session=20= =20 >=20overriding whatever the client has set as it's geometry option. > * If the values aren't set in x2gobroker-sessionprofiles.conf and a=20= =20 >=20--geometry command line argument ISN'T provided to the client then=20= =20 >=20the x2goclient defaults of height=3D600, width=3D800, fullscreen=3DFals= e=20=20 >=20are used resulting in the same behaviour as if the defaults=20=20 >=20previously defined in defaults.py were still present. > * If the values aren't set in x2gobroker-sessionprofiles.conf and=20=20 >=20a --geometry command line argument IS provided to the client it is=20= =20 >=20then used and the user running the x2goclient can pick their own=20=20 >=20initial geometry to start with. > > So in default cases having that default value removed shouldn't=20=20 >=20change behavior and it would allow people to configure their=20=20 >=20starting geometry if the x2gobroker admin has permitted it by not=20=20 >=20providing overriding values in the x2gobroker-sessionprofiles.conf=20= =20 >=20file. The issue goes deeper, I guess. When fixing #834 [1] I did not take into account, that the session=20=20 profile=20default values defined in defaults.py also have another=20=20 context.=20The X2GOBROKER_SESSIONPROFILE_DEFAULTS dict also implicitly=20= =20 provides=20information about the type for each value (int, str, bool). So simply commenting them out is not a solution. Furthermore, my idea is to provide a special value in=20=20 x2gobroker-sessionprofiles.conf,=20i.e., fullscreen=3Dnot-set dpi=3Dnot-set etc. If the admin uses those option for configuration, the broker will=20=20 simply=20hide those session profile options when handing the session=20=20 profile=20over to the client. What do you think of that alternative approach? Mike [1] http://bugs.x2go.org/834 --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_l8_rAF5t77ecxBJv6g2V1A7 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJVIu4OAAoJEJr0azAldxsxDIkP/1SoKMXaE2e9upJjHvaA3KqT sDHzHaZvfsTweQHcnEeS2uUnTu0xYwL+Mk2fcORv8+Mmug/OiDOD/hpjQv+ru1J9 th7pjQUMBYeZuc8ih9r4W4ObLNQd5j+e9kjfzqtFCHQODL3HmqhZoG/HSFH2s9dQ Z29t9VPV61E5nW4Dunt4oEWgNxt8KNVYV4SJJK4zr5XJmb7ZyueqkXgrFnvMAtOm yxrhuKKWVT0A+3MJlcePmu1xva2q03ND9McHhK04S5tWYmlLMCL5CbVVJUeTI0Ui O9/qqRCoA4LO5XZ42V/yjNdAhlOcEfzVBXmiJZcntcn2hjK594tkQMd+bjbO+RCr vvtc708Z/AFpxjR6hwvMKdeIPfOtU7oXYD4ZymcD56Yj49BFuEb2UrUXyPRw4FN2 PtiknJrGgIcMc6yEC1uKPIRdhtX02tEA5SFcOR1WIUcjcYee5JwVKFvkghfg2ihQ tE91P3XVeKIAkWmUHZ08j72k2nhVXkRR/LvShokUh1GN+44O7jf8/cWJH2Cx3o9n Fc+aKMFv63/hsRbRAWIHmGFhtwVfvQPPcTyhJuwo71Y2awG64NzkJCDho4hWu9tm Bd/zVr2u5QLloJ6DWZyKRAHKy0vydSg3VSygfM2dZmfJMxoIlj2GsQPbK/P+ApXB iMkbjWEMYMfv2WZ82nDJ =b+b1 -----END PGP SIGNATURE----- --=_l8_rAF5t77ecxBJv6g2V1A7--