From ionic@ionic.de Sat Mar 28 17:42:42 2015 Received: (at 830) by bugs.x2go.org; 28 Mar 2015 16:42:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A9FBD5DAC0 for <830@bugs.x2go.org>; Sat, 28 Mar 2015 17:42:42 +0100 (CET) Received: from nopileos.local (home.ionic.de [217.92.117.31]) by mail.ionic.de (Postfix) with ESMTPSA id 1210E4F08B71; Sat, 28 Mar 2015 17:42:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1427560962; bh=kO3VLhgU3iyiEOQnqgZU9cIhAo9I8cJR6KQmpwv5Kjc=; h=Date:From:To:Subject:References:In-Reply-To:From; b=LbYY4+g7FyOZkPUUURu6WJmZycjdvKTCUWiufGv9fdZBwsPjpqOb+8sLNvYm4dXM5 3225VnvlU57GKPTCXd7L9LPgbF85Ds8msi3Sf+UEs//RMQEdlFrApScjcM4lEJNP/v G40oqFf0ifL+aogy36OXA85nsoeVD2+BVkF/w3ko= Message-ID: <5516D9FC.8090401@ionic.de> Date: Sat, 28 Mar 2015 17:42:36 +0100 From: Mihai Moldovan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Mike Gabriel , 830@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#830: QAction::eventFilter: Ambiguous shortcut overload: Ctrl+Q References: <20150326130241.Horde.zP8cvvmZUzhJt_T3rxQL1A1@mail.das-netzwerkteam.de> <5514272C.2080601@ionic.de> <20150328131022.Horde.v19J8YW9WmIEEunn5xx1dg5@mail.das-netzwerkteam.de> In-Reply-To: <20150328131022.Horde.v19J8YW9WmIEEunn5xx1dg5@mail.das-netzwerkteam.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MedxvxDxxjqw9sF35Vb7CgvaeJhKrv51A" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MedxvxDxxjqw9sF35Vb7CgvaeJhKrv51A Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 28.03.2015 02:10 PM, Mike Gabriel wrote: > On Do 26 M=E4r 2015 16:35:08 CET, Mihai Moldovan wrote: >> You do, and you should! This is why I fixed this in >> http://code.x2go.org/gitweb?p=3Dx2goclient.git;a=3Dcommitdiff;h=3D5204= 0031502662dfff00f4b0fbbccebf66367f6a >> >> >> Tagging as pending. > > it is good to mark the bug as fixed in the changelog file in a case > like this. > > I have just done that. I haven't because I try to view debian/changelog as read-only history and - whenever possible - make no changes or only cosmetic changes. Especially when a bug is reported after a fix has been published, I would have manually tagged the bug report as pending. Once the new version of the specific component is released, I would also have manually closed the affected bug number. But I guess "rewriting a bit of history" is fine in this case, especially since it makes sure the closure is not forgotten. Mihai --MedxvxDxxjqw9sF35Vb7CgvaeJhKrv51A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJVFtoAAAoJEB/WLtluJTqH0jAP/iBU7Jh1upTe8oieeQ/CYf4c pom8ayiUHx5/U81hbKfNIXNyFr/EJfxQLuNA5WMzqwh8MlqKywP0i4ZI0Y6n/Kqu E//DZS4EkY5gQMmaLZpLTWNZYY7Vy88LgZihgHU/rSJTgwH9XQWkBf1+iPv+LPta eHke9AcxMp61tzV2sZUMhDsmATiz/1IUV8WKrcukRR7P3y82ncV0kAbMEiycY0z5 giH0WMVMuzcjLgG+OWkT4VyD0VdMjcSlkQjg2YyjONC5+sMGLk+yEfqbXpwKZXyf W9wubZJKxsOEPAsKdhuHAxOk7ZkbXRWQiIeQh3EYvh9kV9x8oAuXM7arwjcU+ksu cbWAz/KQfs/YWdI9EmYpPq0tObL8u3RYbyeswnaHAbIHV0giK4f/BGKxjf3cyZDY xZTLU7yviyIbnSuGomvMV4fTEgXNbfq+aBisax7lDqVylw05O3FoQyEZjYNafL9R mKvywrdDTAObnBUtDpZEvto7D3LiGiAIvxtYcj8P7HyBe56gNpwJl5Y28Myopgye oXxf2Ne62yLNAZtGGkMU9Cb/KB7XyhERTowQRz/meFRprjGjE/tV3OU38NHCH/6d lr+02WbFJrcn/pQwkayIgCzNp6/9PlTMxFFsWjjKMyw+fchuxtfpxwaOoe4LqWCh JyyunCEdzPSPVys2eiON =dngi -----END PGP SIGNATURE----- --MedxvxDxxjqw9sF35Vb7CgvaeJhKrv51A--