From unknown Tue Apr 28 11:06:04 2026
X-Loop: owner@bugs.x2go.org
Subject: Bug#820: [X2Go-Dev] Bug#820: Fwd: Patch: x2goserver: x2goruncommand - set IMEXIT="true" for gnome-terminal
Reply-To: Mihai Moldovan <ionic@ionic.de>, 820@bugs.x2go.org, 820@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 17 Mar 2015 06:05:01 +0000
Resent-Message-ID: <handler.820.B820.142657216316013@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 820
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 820-submit@bugs.x2go.org id=B820.142657216316013
          (code B ref 820); Tue, 17 Mar 2015 06:05:01 +0000
Received: (at 820) by bugs.x2go.org; 17 Mar 2015 06:02:43 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 30FAA5DAA2
	for <820@bugs.x2go.org>; Tue, 17 Mar 2015 07:02:41 +0100 (CET)
Received: from nopileos.local (home.ionic.de [217.92.117.31])
	by mail.ionic.de (Postfix) with ESMTPSA id C7F9E4F088F3;
	Tue, 17 Mar 2015 07:02:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1426572161; bh=hzzqtrY+JxB4J3Qxvw/BpsUgu1ZUiHFE+xuGMkUFpT0=;
	h=Date:From:Reply-To:To:Subject:References:In-Reply-To:From;
	b=TpDnyMTlUUYL50wRGkGLF4+dDD4bJamnOFDIGs2AnCOHPUwaF9lJzDvldzRMF9aIy
	 MrzuyLhGL5u0XvB3J3b5xVMrHCaJCm5lLfKMPJ4nwgfOjgp0+w+Ze/gp1JyOHcqRmb
	 vqz57fvdCUefELM2Amx3Klw5A5r4s61A+hxbYeik=
Message-ID: <5507C377.4060008@ionic.de>
Date: Tue, 17 Mar 2015 07:02:31 +0100
From: Mihai Moldovan <ionic@ionic.de>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rok Mandeljc <rok.mandeljc@gmail.com>, 820@bugs.x2go.org
References: <550752A1.1070807@gmail.com> <5507BE76.1060309@ionic.de>
In-Reply-To: <5507BE76.1060309@ionic.de>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="FieORnvG8aSojMjsjOE454FFtFWuXsoB2"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--FieORnvG8aSojMjsjOE454FFtFWuXsoB2
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Control: submitter -1 Rok Mandeljc <rok.mandeljc@gmail.com>
Thanks


On 17.03.2015 06:41 AM, Mihai Moldovan wrote:
> I have been trying to set up x2goserver on my Fedora 21 boxes, and
> gnome-terminal seems to be failing with symptoms similar to those
> described in #268.
>
> It seems that x2goruncommand has been reworked a bit since that patch,
> and now attempts to force the forking programs to stay in the foregroun=
d
> by capturing their output to STDOUT. Unfortunately, this does not seem
> to work for gnome-terminal; the terminal window appears on the client
> for a second, then closes and the session is proclaimed to be finished.=

> This can be fixed by explicitly setting IMEXIT=3D"true" if called binar=
y
> is gnome-terminal, which is done by the attached patch.

This looked weird at first glance, because you've previously (two years
ago) sent a patch to explicitly disable IMEXIT for GNOME Terminal.

However, Mike#1 changed the IMEXIT behavior with commit
c3afe1c154dfeb0ba052f7506f0cadc5f6c62871 and that's also why it's now
failing for GNOME Terminal.

I'll be adding IMEXIT=3D"true" and your comment where gnome-terminal is
defined, if that's OK with you?

Will craft and commit a patch tomorrow.

Thanks for contributing!



Mihai


N.B.: shouldn't this be also required for KDE4's konsole? Looks like it,
but I'm not a KDE user, so... input welcome.


--FieORnvG8aSojMjsjOE454FFtFWuXsoB2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJVB8N+AAoJEB/WLtluJTqH/a0QAIybIoz2USE0a6RG9zJc576N
Wuuy/pY7de8q3iqFe1GhPXtkgNOJnWv4iOYOC2O7IyCB61N3nGcetC8GAVy/ajh0
jiTUggPG3Itn87xraifk65Jd4qHpMCywAGcpVIG8MyqKgXucHoaoXEGSRXgMLEXV
/VlymBo53USXV+zMNV7OzXyJkRzFbY6z4uOYwVocOyWVsQgE9HgqqRe6kZUp8NN5
rI3bnkZLj8tAQXl84ytcQdOFJ9PtOszyKuaBHa76FmCojemzepONSGSVYpVqCn1Y
3px6ECvTMp5HZsjkD3W1N3hnGOKd68uPhzKKEXxbrtPbwuGyletq0TPH/wGG3jiI
yTMG190bz6yekBmWXXa2EJWjMNOe+Tn+TrMLzkcusW34SGFVFvA/i3W8of018lgX
7ta7WT9yssseaK3/iCQN25p88cLSwrSxy2t38oiMbwXMoXf6VRAzQmR2bNGFSVf4
1yRRa24DlLrIIEJEFHMWY93eBeZn2YcgZ/yczVXFYn1IFTXiNpFX2M873MGD/mb8
i+dNnRuCzd+gL/5e8NTXqWJaUdIESCqESFXQLFesEu0gUtrdip6cXsfywbpFYsxb
5Pg0W9Bhu3EbrV06Gf9TPuE++S91x5CNXKNiLPxlPcl81gvsS2KS2mCpPytDX0R4
fEAbJx+pJ3UIYfRhWnXh
=P22z
-----END PGP SIGNATURE-----

--FieORnvG8aSojMjsjOE454FFtFWuXsoB2--
