From siretart@gmail.com Thu Dec 6 14:44:05 2012 Received: (at submit) by bugs.x2go.org; 6 Dec 2012 13:44:05 +0000 Received: from mail-ob0-f179.google.com (mail-ob0-f179.google.com [209.85.214.179]) by ymir (Postfix) with ESMTPS id D0BC23BC43 for ; Thu, 6 Dec 2012 14:44:04 +0100 (CET) Received: by mail-ob0-f179.google.com with SMTP id x4so5883798obh.24 for ; Thu, 06 Dec 2012 05:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=IOSqIR8jD+bpxUxaxu4/fe6fYgmTeXY+MTyKUt+9y/s=; b=N1JdoUTf0z4Gzi82J/jqwAexYLr8KNIL48GSKYAAfe1Y7eiT6Q9WgWXWtf0oRu1W2d aKoPb/OnOumWnRau9mwXTbMz0z7PQd1dfIKzNrptHb4sipL9lyFME0Skds6Wpf1/EPQK 0znALTQvDgnl/0wji5Ov1zwapq/3O15TS9AdU1k7INw07Rw40kzz0F+VjAAG1HEKehXx CdGkR+6RbHt0WVhxI02IV2wAmbceiUF9xdHZDyznb98ZKRSR64iOOg5sO2R+HYNsmTLk jmNTjAOievj2PfTL6nkrMRSkoQjVItPWnK1dy3G6nWMBmSGNtavrqdenVWvKXxIRdXBk pCBA== MIME-Version: 1.0 Received: by 10.182.92.70 with SMTP id ck6mr835817obb.46.1354801443113; Thu, 06 Dec 2012 05:44:03 -0800 (PST) Received: by 10.60.25.71 with HTTP; Thu, 6 Dec 2012 05:44:03 -0800 (PST) Date: Thu, 6 Dec 2012 14:44:03 +0100 Message-ID: Subject: x2goruncommand is not "user friendly" From: Reinhard Tartler To: submit@bugs.x2go.org Content-Type: text/plain; charset=ISO-8859-1 Package: x2goserver It seems that x2goruncommand is not supposed to be called directly by the user. Calling it without parameters yields to: >> x2goruncommand /usr/bin/x2goruncommand: Zeile 46: /home/inf4/tartler/.x2go/C-/cmdoutput: Datei oder Verzeichnis nicht gefunden /usr/bin/x2goruncommand: Zeile 262: /home/inf4/tartler/.x2go/C-/cmdoutput: Datei oder Verzeichnis nicht gefunden kill: Gebrauch: kill [-s Signalname | -n Signalnummer | -Signalname] [pid | job] ... oder kill -l [Signalname] Died at /usr/lib/x2go/x2gochangestatus line 35. argument "session_id" missed at /usr/lib/x2go/x2godbwrapper.pm line 575. The fact that it is installed by default into /usr/bin makes it appear in the tab-completion of modern shells such as bash and implies that users are supposed to call it directly. I would suggest to either: a) make it robust against wrong calling usage, b) place it in /usr/lib/x2go/x2goruncommand instead, or c) both. -- regards, Reinhard From mike.gabriel@das-netzwerkteam.de Thu Dec 6 15:17:24 2012 Received: (at 79) by bugs.x2go.org; 6 Dec 2012 14:17:24 +0000 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id 0C1053BC43; Thu, 6 Dec 2012 15:17:24 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id A94DB36F; Thu, 6 Dec 2012 15:17:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 96D313C03A; Thu, 6 Dec 2012 15:17:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJfGdAKiC5qg; Thu, 6 Dec 2012 15:17:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 6C5BA3BFE1; Thu, 6 Dec 2012 15:17:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 4D51B3BBEA; Thu, 6 Dec 2012 15:17:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on grimnir.das-netzwerkteam.de X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 running as userid= X-Spam-Level: X-Spam-Bayes-Score: 0.0000 Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33) id E5F073BBF1; Thu, 6 Dec 2012 15:17:22 +0100 (CET) Received: from nocatv2.tng.de (nocatv2.tng.de [213.178.75.58]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 06 Dec 2012 15:17:22 +0100 Message-ID: <20121206151722.14666sqe3o3u6eia@mail.das-netzwerkteam.de> X-Priority: 3 (Normal) Date: Thu, 06 Dec 2012 15:17:22 +0100 From: Mike Gabriel To: Reinhard Tartler , 79@bugs.x2go.org, x2go-dev@lists.berlios.de Cc: control@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#79: x2goruncommand is not "user friendly" References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_6n1wtc0e8836"; protocol="application/pgp-signature"; micalg="pgp-sha1" Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.3.4) This message is in MIME format and has been PGP signed. --=_6n1wtc0e8836 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit severity #79 wishlist thanks Hi Reinhard, On Do 06 Dez 2012 14:44:03 CET Reinhard Tartler wrote: > Package: x2goserver > > It seems that x2goruncommand is not supposed to be called directly by > the user. Calling it without parameters yields to: > >>> x2goruncommand > /usr/bin/x2goruncommand: Zeile 46: > /home/inf4/tartler/.x2go/C-/cmdoutput: Datei oder Verzeichnis nicht > gefunden > /usr/bin/x2goruncommand: Zeile 262: > /home/inf4/tartler/.x2go/C-/cmdoutput: Datei oder Verzeichnis nicht > gefunden > kill: Gebrauch: kill [-s Signalname | -n Signalnummer | -Signalname] > [pid | job] ... oder kill -l [Signalname] > Died at /usr/lib/x2go/x2gochangestatus line 35. > argument "session_id" missed at /usr/lib/x2go/x2godbwrapper.pm line 575. > > > The fact that it is installed by default into /usr/bin makes it appear > in the tab-completion of modern shells such as bash and implies that > users are supposed to call it directly. Agreed! So with many other X2Go commands in /usr/bin. The reason is that the client implementations currently expect to find the x2go* commands in $PATH. > I would suggest to either: a) make it robust against wrong calling > usage, b) place it in /usr/lib/x2go/x2goruncommand instead, or c) > both. a) is the way to go... Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb --=_6n1wtc0e8836 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Unterschrift Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAABAgAGBQJQwKjyAAoJEJr0azAldxsxEBUP/1LLyxZUTF36poM4tCm6sJVy zS00Yaqxdx26dBriCCsPYBghyu/4x2Zq88tUzuFh0Y7QyyoYVAWxU2+n6bwIW3hV talbz0VM4WqxAN0I3e51YbIgZRA39uTNKTAw/bJTo0CJ/4t5vT+cDmbqmLMxepmc +laN1ctaRHIEPGyzQ0f3LdGIBblhYgldcLtPiStFvmK1VHmUJtw4YbrA+/sP3PzG LEvzNXLts2XZ9KfxWcM219dkK7VA4xx0a67CJdpMlhZ0OVyQEJwXlZa0KgV17jM1 HoeDa1ql/dGiDdZuTOU6+tx4TU3rRNnMSIbkETbGrsxPvRWNpzqdqytd/g93dflE QqnRKbLvqHBNGGUmql3bQg45GVgZqRl97jIyVm2M3KBJxaaLJl7up9njs+9RKl9z xCZ5sQKpzgfUk1r9QAi7n+LHT44cZc7k29i2vpU5gYq7NX/CXpMdG0RG7ZtEP9DE t8qAIOqCqi9hnNFozzWqyeF84xoHUe6RTlUO6YQ+ss/arw6XFttclumsDNMIM97k vXCXgO4rv6Qx/itE1gWOlXgwtJqkLfgY2gGQOJh3hLmLR7CABohuiR9aPJBkSSED OfQIcpXew3Cp9xRz/UuWozl6HIEEX6XZqFxCG+uvrxzgtA9Wn8S8dWx/mHflVFYs dcZiMblYj0fh+BUDzVmt =Tmis -----END PGP SIGNATURE----- --=_6n1wtc0e8836--