From unknown Thu Apr 30 08:10:04 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#797: xinamera extension is broken after update Reply-To: Fernando Pedemonte , 797@bugs.x2go.org Resent-From: Fernando Pedemonte Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 12 Mar 2015 21:55:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 797 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 797-submit@bugs.x2go.org id=B797.142619700510492 (code B ref 797); Thu, 12 Mar 2015 21:55:01 +0000 Received: (at 797) by bugs.x2go.org; 12 Mar 2015 21:50:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 X-Greylist: delayed 469 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 12 Mar 2015 22:50:01 CET Received: from correo.sintys.gob.ar (correo.sintys.gob.ar [200.63.169.120]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EFCEC5E15D for <797@bugs.x2go.org>; Thu, 12 Mar 2015 22:50:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by correo.sintys.gob.ar (Postfix) with ESMTP id 1515228EC9EC for <797@bugs.x2go.org>; Thu, 12 Mar 2015 18:42:08 -0300 (ART) Received: from correo.sintys.gob.ar ([127.0.0.1]) by localhost (correo.sintys.gob.ar [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Q3V6a40uPdR2; Thu, 12 Mar 2015 18:42:07 -0300 (ART) Received: from localhost (localhost [127.0.0.1]) by correo.sintys.gob.ar (Postfix) with ESMTP id 5308328EC977; Thu, 12 Mar 2015 18:42:07 -0300 (ART) DKIM-Filter: OpenDKIM Filter v2.9.2 correo.sintys.gob.ar 5308328EC977 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sintys.gob.ar; s=315F4B1A-5F92-11E4-BD51-6BB7E358756B; t=1426196527; bh=hl5cg/S9fzbHhB+MUZC+whRVaZIVc/gLC6JFKASo2vM=; h=Date:From:To:Message-ID:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding; b=DsVN0I3nu452sxNDS+StoETwaoa130iW0/9x2/TzPNAb9japcMhMXqKw0Rzp4mAcH MuZSD7lZgdgHGuDxMLh8DqkHcK2DOVT3aAnfav+aPVvDRC9QTIjdOyOjocLNsDcUDB OfKWP9FCiezLb0l2RXNBiYsv3AOIli0lEehD2xjc= X-Amavis-Modified: Mail body modified (using disclaimer) - correo.sintys.gob.ar X-Virus-Scanned: amavisd-new at sintys.gob.ar Received: from correo.sintys.gob.ar ([127.0.0.1]) by localhost (correo.sintys.gob.ar [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id k7tkhreKeJCl; Thu, 12 Mar 2015 18:42:07 -0300 (ART) Received: from correo.sintys.gob.ar (correo.sintys.gob.ar [172.18.88.14]) by correo.sintys.gob.ar (Postfix) with ESMTP id 31CE328EC9E2; Thu, 12 Mar 2015 18:42:07 -0300 (ART) Date: Thu, 12 Mar 2015 18:42:07 -0300 (ART) From: Fernando Pedemonte To: 797@bugs.x2go.org Cc: cbourlot Message-ID: <283125071.535282.1426196527170.JavaMail.zimbra@sintys.gob.ar> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.42.88.153] X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - GC41 (Linux)/8.6.0_GA_1153) Thread-Topic: xinamera extension is broken after update Thread-Index: So8gu2LLxq53lV82g+MHyaLg8rDQMg== Hi all, I was having this problem also, and after some debugging I was able to trac= e the problem to a function in the file onmainwindow.cpp at the x2goclient = package. Enabling the debug on the client I saw at the step of creating the xinerama= .conf file inside $HOME/.x2go/xxxxxx/ directory the following: x2go-DEBUG-../sshmasterconnection.cpp:1469> executing remote: "sh -c 'echo = X2GODATABEGIN:38317d7e-972d-417f-9745-ef9cb09d7e35; PATH=3D/usr/local/bin:/= usr/bin:/bin export DISPLAY=3D:50;printf '1600 0 1600 900\\n0 0 1600 900' >= $HOME/.x2go/C-fpedemonte-50-1426195616_stDXFCE_dp24/xinerama.conf; echo X= 2GODATAEND:38317d7e-972d-417f-9745-ef9cb09d7e35;'" As you can see, the "\n" is not escaped correctly. What I did was to modify= the following line of code inside onmainwindow.cpp line 10212 QString cmd=3D"export DISPLAY=3D:"+resumingSession.display+";printf= '"+screens.join("\\\\n")+"' > $HOME/.x2go/C-"+ resumingSession.sessionId+"/xinerama.conf"; To: QString cmd=3D"export DISPLAY=3D:"+resumingSession.display+";printf= \""+screens.join("\\n")+"\" > $HOME/.x2go/C-"+ resumingSession.sessionId+"/xinerama.conf"; After this modification, xinerama is working again. Take note that I also replaced the single quote by double quote and escaped= them. Without this modification the printf command was failing to create t= he xinerama.conf file. Thanks for this excelent piece of software Best Regards Fernando D. Pedemonte Seguridad Inform=C3=A1tica SINTyS Sistema de Identificaci=C3=B3n Nacional Tributario y Social Consejo Nacional de Coordinaci=C3=B3n de Pol=C3=ADticas Sociales Presidencia de la Naci=C3=B3n Julio A. Roca 782- Piso 5 Ciudad Aut=C3=B3noma de Bs. As. Tel: (54 11) 43708778 int.8788 fpedemonte@sintys.gov.ar ----------- NOTA DE RESPONSABILIDAD: ----------------------------------- Este mensaje proviene de Internet, tome los recaudos necesarios en su manejo. El contenido del presente mensaje y sus adjuntos es privado, estrictamente confidencial y exclusivo para su destinatario, pudiendo contener informaci=C3=B3n protegida por normas legales y de secreto profesional. Bajo ninguna circunstancia su contenido puede ser transmitido o revelado a terceros ni divulgado en forma alguna. En consecuencia de haberlo recibido por error, solicitamos contactar al remitente y eliminarlo de su sistema. ------------------------------------------------------------------------