Subject: Re: [X2Go-Dev] Bug#777: nx-libs: incorrect usage of scanf

From: Mike Gabriel <[email-masked]>
Date: Sat, 31 Jan 2015 15:04:21 +0000

Hi Heinrich,

On  Fr 30 Jan 2015 20:35:53 CET, Heinrich Schuchardt wrote:

> package: nx-libs
> version: head
>
> In different parts of the nx-libs library you can find usages of scanf like
>
>    /* check for MESA_GAMMA environment variable */
>    gamma = _mesa_getenv("MESA_GAMMA");
>    if (gamma) {
>       v->RedGamma = v->GreenGamma = v->BlueGamma = 0.0;
>       sscanf( gamma, "%f %f %f", &v->RedGamma, &v->GreenGamma,
> &v->BlueGamma );
>
> According to cppcheck:
>
> scanf without field width limits can crash with huge input data on libc
> versions older than 2.13-25. Add a field width specifier to fix this
> problem:
>     %i => %3i

Any chance you could also provide a patch for this?

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: [email-masked], http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb