From unknown Sat May 16 21:00:28 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#776 closed by Mike Gabriel (fix for #776 reverted) Message-ID: References: <20150210042052.Horde.5w69O56G84gsf9wlj0YaNw3@mail.das-netzwerkteam.de> X-X2go-PR-Keywords: not-a-bug pending X-X2go-PR-Message: they-closed 776 X-X2go-PR-Package: nx-libs Date: Tue, 10 Feb 2015 04:25:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1423542302-25442-0" This is a multi-part message in MIME format... ------------=_1423542302-25442-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the nx-libs package: #776: nx-X11: Size of pointer 'server_support' used instead of size of its = data It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 776: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D776 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1423542302-25442-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 776) by bugs.x2go.org; 10 Feb 2015 04:21:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 4DEC43BE64; Tue, 10 Feb 2015 05:20:53 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 01415AD7; Tue, 10 Feb 2015 05:20:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D90023C20D; Tue, 10 Feb 2015 05:20:52 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BVU16Ul0EKEA; Tue, 10 Feb 2015 05:20:52 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id A19553C1DD; Tue, 10 Feb 2015 05:20:52 +0100 (CET) Received: from p5B3B85C5.dip0.t-ipconnect.de (p5B3B85C5.dip0.t-ipconnect.de [91.59.133.197]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Tue, 10 Feb 2015 04:20:52 +0000 Date: Tue, 10 Feb 2015 04:20:52 +0000 Message-ID: <20150210042052.Horde.5w69O56G84gsf9wlj0YaNw3@mail.das-netzwerkteam.de> From: Mike Gabriel To: 776@bugs.x2go.org Cc: 776-submitter@bugs.x2go.org Subject: fix for #776 reverted User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.59.133.197 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_A3Zumpkxl9yoNnrysqfUWw1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_A3Zumpkxl9yoNnrysqfUWw1 Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tag -1 not-a-bug Control: close -1 Hi Heinrich, yesterday, I reverted the fix for #776 because while applying all the=20=20 NX=20patches in preparation of the 3.6.x branch of nx-libs [1], I=20=20 realized=20that the file in question (glxextensions.c) never gets used=20= =20 at=20build time. Greets, Mike [1] https://github.com/ArcticaProject/nx-libs --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_A3Zumpkxl9yoNnrysqfUWw1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJU2YckAAoJEJr0azAldxsxVt4P/2JNBhf1JRjdjpavFCCi+MKR jqEsqR0wzZEHzwNrHc86HdOrh689/Rilo6zvXGLeyO3NfICDTL4/qFc7Us9M2MPC UhzWerrjAr2RkciO8uLl3IyOIl8J4nOnNoXnlRBLda4ETOAW/nlmrFzw4zCMQEXd lXDS9ctwHrCsbLofWmsC+/7yub6QBHGkeL8SB6Pw+WWO80WwDf6qMRSiOQvmb0mX iUZWm3CaGkkzI00LENP53mqq91gA35vzw2OoQSy2p43vF1JiDtTNuSTj8L4a1PZq RmBi+wc6h0LYoDwmCBnFqTQZw06GfkMTh0RXkVgT4RMBmRq7HbRacu8gfEJI4Tni cYUz7aILLaH5QEKKpda6ds4F4C1AxKjrBmqa28ZzQw9K2hx/jp8ezizKr+zA57jA Qq7KuKSdXALK6ckhlwZBVdvhjxfP8NN+zqQFMMXB7qPbOtDU+UydbW8048ggm5bc mnTCx7a+yuLdFuwbUBVU3ubNxCFEOhe5Qmy6YS95FXzzqiA1ZzuEL4Rh07nUS7eO wiUUzzhXPgOQj+BFO+fUINJLZGXcc0PzWo44o34EXxkvgrJ3JCvU6s7zBFeRBFJy TLdS70nJVbElBlhDmDJOtVTCRDgLW0z3aukeOKGJaTiciGYu1LisGD1kgUXz5Vm3 Wq3p68oKFdS79UMhmsmU =WTpe -----END PGP SIGNATURE----- --=_A3Zumpkxl9yoNnrysqfUWw1-- ------------=_1423542302-25442-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 30 Jan 2015 19:34:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=ham version=3.3.2 X-Greylist: delayed 301 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Fri, 30 Jan 2015 20:34:57 CET Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 495563BC8A for ; Fri, 30 Jan 2015 20:34:57 +0100 (CET) Received: from [192.168.123.39] ([178.201.93.16]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MCOdh-1YPppt1VNR-009Cbb for ; Fri, 30 Jan 2015 20:29:56 +0100 Message-ID: <54CBDBAF.7010309@gmx.de> Date: Fri, 30 Jan 2015 20:29:51 +0100 From: Heinrich Schuchardt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: submit@bugs.x2go.org Subject: nx-X11: Size of pointer 'server_support' used instead of size of its data Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:yhDRaxxCGblO+pgNWRwKv9uwoFH1UYM8vaNSdYpMMxXzZfSg9YW hFfSdMMJmQabIOYHWjxztzpYAIIuh8BBmIoioHImwix0U3NI9VSlfuro5SoEltsM9+rPkvx 89Oz+Xg/gtyywYNRCT5b2LxAJUPYxPmq2e3U7c+/uWXXueL97ATtcyG9rI0Kk0ltitJGgJL 3v2rT7h5+FHMx7TTOzZGQ== X-UI-Out-Filterresults: notjunk:1; package: nx-libs version: head In nx-libs/nx-X11/extras/Mesa/src/glx/x11/glxextensions.c the length of the zeroed memory is the length of the pointer (4 bytes in case of a 32bit system) not the length of the data the pointer points to (8 byte). static void __glXProcessServerString( const struct extension_info * ext, const char * server_string, unsigned char * server_support ) { unsigned base; unsigned len; (void) memset( server_support, 0, sizeof( server_support ) ); Furthermore the length of the memory area pointed to by server_support is defined in varying ways in the coding: #define __GL_EXT_BYTES ((__NUM_GL_EXTS + 7) / 8) unsigned char server_support[ __GL_EXT_BYTES ]; unsigned char server_support[8]; Currently __NUM_GL_EXTS = 123, so __GL_EXT_BYTES = 8. What is expected to happen if __GL_EXT_BYTES > 8 after defining six more values in the unamed (sic!) enum with the different bits? This questionable code was identified with cppcheck. http://cppcheck.sourceforge.net/ Best regards Heinrich Schuchardt ------------=_1423542302-25442-0--