From unknown Thu Mar 28 16:56:44 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#759: [X2Go-Dev] x2goclient 4.0.5.0 (and 4.0.5.1 preview) frequent ssh commands don't free resources Reply-To: Mat Martineau , 759@bugs.x2go.org Resent-From: Mat Martineau Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 16 Nov 2017 16:50:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 759 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 759-submit@bugs.x2go.org id=B759.15108508816736 (code B ref 759); Thu, 16 Nov 2017 16:50:02 +0000 Received: (at 759) by bugs.x2go.org; 16 Nov 2017 16:48:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=3.0 tests=BAYES_40 autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 134025DAD0 for <759@bugs.x2go.org>; Thu, 16 Nov 2017 17:48:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qqmrTSaeGFYH for <759@bugs.x2go.org>; Thu, 16 Nov 2017 17:47:55 +0100 (CET) X-Greylist: delayed 608 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Thu, 16 Nov 2017 17:47:54 CET Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id CF5F85DA2B for <759@bugs.x2go.org>; Thu, 16 Nov 2017 17:47:54 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2017 08:37:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,404,1505804400"; d="scan'208";a="2390357" Received: from mlaffert-mobl1.amr.corp.intel.com (HELO tomotinu-mobl.amr.corp.intel.com) ([10.254.127.152]) by fmsmga004.fm.intel.com with ESMTP; 16 Nov 2017 08:37:43 -0800 Date: Thu, 16 Nov 2017 08:37:43 -0800 (PST) From: Mat Martineau X-X-Sender: mjmartin@tomotinu-mobl.amr.corp.intel.com To: Mihai Moldovan cc: 759@bugs.x2go.org, x2go-dev@lists.x2go.org In-Reply-To: <18ef7344-053a-dda7-beac-480507c12993@ionic.de> Message-ID: References: <18ef7344-053a-dda7-beac-480507c12993@ionic.de> User-Agent: Alpine 2.21 (OSX 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Wed, 15 Nov 2017, Mihai Moldovan wrote: > On 03/14/2016 05:47 PM, Mat Martineau wrote: >> Given that the Mac client is leaking 6 SshProcess objects per minute, is >> there a chance bug 759 will get a look before 4.0.5.1? > > Obviously not, but something definitely sounds fishy there. ... > The second issue - ssh processes stacking up, is NOT intentional and must be fixed. > > > Can you reproduce this with current versions? Running with x2goserver 4.0.1.20 (Fedora 26) and x2goclient 4.1.1.0 (MacOS 10.12.6), I still see the cleanup at exit: """ x2go-DEBUG-../src/sshmasterconnection.cpp:1985> All channels closed and session disconnected. Quitting session loop. x2go-DEBUG-../src/sshmasterconnection.cpp:797> SshMasterConnection, instance SshMasterConnection(0x7fc54fdf1b40) thread finished. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshprocess.cpp:52> SshProcess destructor called. x2go-DEBUG-../src/sshmasterconnection.cpp:804> SshMasterConnection, instance SshMasterConnection(0x7fc54fdf1b40) finished destructor. x2go-DEBUG-../src/onmainwindow.cpp:6532> Setting focus. """ -- Mat Martineau Intel OTC