From unknown Tue Apr 28 06:30:15 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#744: [X2Go-Dev] Bug#744: user-local keystrokes.cfg does not work Reply-To: Mihai Moldovan , 744@bugs.x2go.org Resent-From: Mihai Moldovan Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Fri, 16 Jan 2015 14:30:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 744 X-X2Go-PR-Package: x2goagent X-X2Go-PR-Keywords: patch Received: via spool by 744-submit@bugs.x2go.org id=B744.1421418447697 (code B ref 744); Fri, 16 Jan 2015 14:30:01 +0000 Received: (at 744) by bugs.x2go.org; 16 Jan 2015 14:27:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id E15F65DEA3 for <744@bugs.x2go.org>; Fri, 16 Jan 2015 15:27:25 +0100 (CET) Received: from nopileos.local (home.ionic.de [217.92.117.31]) by mail.ionic.de (Postfix) with ESMTPSA id 249D94F003D1; Fri, 16 Jan 2015 15:27:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1421418445; bh=PoHYVEznxkJjsPWaSBxipXX3gcEEHJbz2BysqMbHBNo=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=iCU1VKdQ3Q9nDjYASR+CV/tb/x8z8gxhdxBqKHVlQm77d3H4cv91R42jSOSlpx+NL A6qZaU15WSb5EM4l9jadRoiYc3+iqzJnS7KZCd8PV4RVtbUWOFrrh7IN/f9EnWXTZS MBLuIzDSRD97SYZYAH1t9brLPqEJ4/3h5fbLbn7g= Message-ID: <54B91FC5.6040704@ionic.de> Date: Fri, 16 Jan 2015 15:27:17 +0100 From: Mihai Moldovan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mike Gabriel , Horst Schirmeier CC: 744@bugs.x2go.org References: <20150115151045.GI22378@quickstop.soohrt.org> <54B829B7.4030902@ionic.de> <20150115225649.Horde.HcPP3grdrOF4uhHQn4l8_w4@mail.das-netzwerkteam.de> In-Reply-To: <20150115225649.Horde.HcPP3grdrOF4uhHQn4l8_w4@mail.das-netzwerkteam.de> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ovLFdTV2uW2ATNLJUckSCaQOmNgbtbbEI" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ovLFdTV2uW2ATNLJUckSCaQOmNgbtbbEI Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 15.01.2015 11:56 PM, Mike Gabriel wrote: > Thanks for your patch, Horst. I totally forgot about that. Thanks. >> Do we actually WANT to make ~/.nx/foo override /etc/x2go/foo *for > > First: We want to allow users to override system-wide settings by > user settings. Yes, my point was explicitly about ~/.nx vs. /etc/x2go. ~/.x2go overriding /etc/x2go is naturally OK. >> x2goagent*? Or do we rather want to get rid of ~/.nx and >> /etc/nxagent entirely within x2go components (which, really, would >> make some sort of sense, especially if $SOMETHING created >> ~/.nx/config/keystrokes.cfg and users wonder why >> /etc/x2go/keystrokes.cfg does not take any effect.) > > This indeed is a bit of a drama, I agree. > > 1. We want to provide NX-X11 to people who still use NX (e.g. > FreeNX). > > To provide this, we have to think generically here. Paths like ~/.nx > or /etc/nxagent/ are hard-coded in NX-X11 and nxagent and I think > that is ok. All X2Go'ish paths should be overridden via env vars or > otherwise. And that's fine. nxagent (itself) should rely on ~/.nx and /etc/nxagent. I'm just saying that for x2goagent, it would be smarter to ignore ~/.nx and /etc/nxagent, thus only taking ~/.x2go and /etc/x2go into considerati= on. > In nxagent, there is some code that checks ARGV[0] (=3D=3D nxagent? =3D= =3D > x2goagent?) and triggers the branding of start-up screens of desktop > sessions (the gray X2GO logo). Well, if we have that anyway, we can expand on that. Horst's new patch sounds great by making use of exactly that. > Maybe for setting paths (esp. ~/.x2go/keystrokes.cfg), some similar > mechanism should be used? Wait... there's ~/.x2go/config/keystrokes.cfg and ~/.x2go/keystrokes.cfg? What's the difference between those? >> Actually, I see another problem there. Wouldn't it be smarter to >> consider both ~/.x2go/foo and /etc/x2go/keystrokes.cfg (if >> existent), with values in ~/.x2go/foo overriding those of the >> global configuration file? A priority-based merge would really be >> the thing we're looking for. I've got something like that lying >> around. > > It would be smarter, indeed. But one step at a time. On 15.01.2015 10:27 PM, Horst Schirmeier wrote: > For example, IMHO it'd require introducing a way to completely > remove/disable /etc/x2go/keystrokes.cfg definitions via directives in > user-local files, instead of only overriding key definitions. I'm not so sure anymore. As pointed out, merging means that you cannot (easily) delete keys in the global config file. I didn't think of that on= e. Mihai --ovLFdTV2uW2ATNLJUckSCaQOmNgbtbbEI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJUuR/LAAoJEB/WLtluJTqHd6QP/1BlHG/1sMIi6ae1+nMBM6xg OpZYdDrgG1zHYwyj3ysITmEyb+jS7ZVetoGjSPTUMpSNp8UO3muAHPhH2orrcnpK h2EV8jLNARisONGQ3Kfr6DFfMxzNID4cwSNAwD2clcLjbxfclzQJrHDLvi5jqV7t 5KGfZrJaWoeIPs92H0tV4LalUZgD04c/ev1zKXiERF0mBq9Ki8ojZLUT/j+91t0e IXe5WVNhCbxA6LXgKvCNr+0ZTtt52pAET982Axtpt8rXJrDcx0gj5kWFScsBzSPG tAhIQKHpuaXofKsS1EG5j8WlI7pY31Mi5AAW3QT5T6SlNLY72s2KACxae2HyTFOW 4AjdMuaEd9yiqUqIWGtOxqu6Fs/oolWyg6rRA/6cCWHUyspE6YrM0vWH3O1LzQMx r37S20ojhfGC11mnaaJwtzuEJzElqMf/Sa3m9lTN6/G4NqEM2WguqgTrNZ3iGaoY xNGZLQZ4gdNzK5l/PgMFixnRUHPl87onrxuVvRXSHKjwVR+C587IvHyIzQSPR8Zc tNUgKpy7tIdgdq7OlBY3S5KZcYdvxB7u70kfmkQeRdZHR4/h1yBgF/zvEgy+B+TG qhq9cuAKdgS/ZOVY7wldR/Fznt2cIsKHAHORJj0j6JkoYTaOGmTUQ6aI/c1jPxaF gOFLpOjV7yvAQRzh75tq =r7l+ -----END PGP SIGNATURE----- --ovLFdTV2uW2ATNLJUckSCaQOmNgbtbbEI--