From unknown Tue Apr 28 07:58:43 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#744: [X2Go-Dev] Bug#744: Bug#744: user-local keystrokes.cfg does not work Reply-To: Mike Gabriel , 744@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 15 Jan 2015 23:00:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 744 X-X2Go-PR-Package: x2goagent X-X2Go-PR-Keywords: Received: via spool by 744-submit@bugs.x2go.org id=B744.142136261321492 (code B ref 744); Thu, 15 Jan 2015 23:00:01 +0000 Received: (at 744) by bugs.x2go.org; 15 Jan 2015 22:56:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id B073C5DA53 for <744@bugs.x2go.org>; Thu, 15 Jan 2015 23:56:50 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E0FE2C94; Thu, 15 Jan 2015 23:56:49 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id CACE53C844; Thu, 15 Jan 2015 23:56:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GAdrm67fVzcU; Thu, 15 Jan 2015 23:56:49 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 8BE493C1DD; Thu, 15 Jan 2015 23:56:49 +0100 (CET) Received: from p5B3B9553.dip0.t-ipconnect.de (p5B3B9553.dip0.t-ipconnect.de [91.59.149.83]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 15 Jan 2015 22:56:49 +0000 Date: Thu, 15 Jan 2015 22:56:49 +0000 Message-ID: <20150115225649.Horde.HcPP3grdrOF4uhHQn4l8_w4@mail.das-netzwerkteam.de> From: Mike Gabriel To: Mihai Moldovan , 744@bugs.x2go.org, Horst Schirmeier References: <20150115151045.GI22378@quickstop.soohrt.org> <54B829B7.4030902@ionic.de> In-Reply-To: <54B829B7.4030902@ionic.de> User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.59.149.83 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_O4UPIabXEXD54652pppocQ1"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_O4UPIabXEXD54652pppocQ1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tag -1 patch Hi Horst, hi Mihai, On Do 15 Jan 2015 21:57:27 CET, Mihai Moldovan wrote: > On 15.01.2015 04:10 PM, Horst Schirmeier wrote: >> debian/wrappers/x2goagent | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/debian/wrappers/x2goagent b/debian/wrappers/x2goagent >> index 129c7ca..750c651 100644 >> --- a/debian/wrappers/x2goagent >> +++ b/debian/wrappers/x2goagent >> @@ -29,7 +29,15 @@ test -x $NX_LIBS/../x2go/bin/$NXAPP && export=20=20 >>=20NX_LIBS=3D$NX_LIBS >> >> export LD_LIBRARY_PATH >> >> -NXAGENT_KEYSTROKEFILE=3D/etc/x2go/keystrokes.cfg >> -export NXAGENT_KEYSTROKEFILE >> +for CONFIG in ~/.x2go/config/keystrokes.cfg ~/.nx/config/keystrokes.cfg= \ >> + /etc/x2go/keystrokes.cfg /etc/nxagent/keystrokes.cfg Thanks for your patch, Horst. > Do we actually WANT to make ~/.nx/foo override /etc/x2go/foo *for First: We want to allow users to override system-wide settings by user=20= =20 settings. >=20x2goagent*? Or do we rather want to get rid of ~/.nx and /etc/nxagent > entirely within x2go components (which, really, would make some sort of > sense, especially if $SOMETHING created ~/.nx/config/keystrokes.cfg and > users wonder why /etc/x2go/keystrokes.cfg does not take any effect.) This indeed is a bit of a drama, I agree. 1. We want to provide NX-X11 to people who still use NX (e.g. FreeNX). To provide this, we have to think generically here. Paths like ~/.nx=20=20 or=20/etc/nxagent/ are hard-coded in NX-X11 and nxagent and I think that=20= =20 is=20ok. All X2Go'ish paths should be overridden via env vars or=20=20 otherwise. In=20nxagent, there is some code that checks ARGV[0] (=3D=3D nxagent? =3D= =3D=20=20 x2goagent?)=20and triggers the branding of start-up screens of desktop=20= =20 sessions=20(the gray X2GO logo). Maybe for setting paths (esp. ~/.x2go/keystrokes.cfg), some similar=20=20 mechanism=20should be used? > Actually, I see another problem there. Wouldn't it be smarter to > consider both ~/.x2go/foo and /etc/x2go/keystrokes.cfg (if existent), > with values in ~/.x2go/foo overriding those of the global configuration > file? A priority-based merge would really be the thing we're looking > for. I've got something like that lying around. It would be smarter, indeed. But one step at a time. Let's get this issue solved first cleanly (it obviously is a namespace=20= =20 issue=20for NX configuration files). Once that is sorted out, you should=20= =20 bring=20your merging code into the game. I'd suggest you file it as a=20=20 wishlist=20bug + patch (or without patch) for now... > It's not exactly small, though. And would benefit from being shared > code, as it could (and also would) be used in both x2goagent and x2goserv= er. Ok.... So we would bring another dependency into the game that no=20=20 already=20existing library or whatsoever could already cover in=20=20 functionality?=20(Mike is scared of to many upstream projects having to=20= =20 be=20maintained inside X2Go). Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_O4UPIabXEXD54652pppocQ1 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUuEWxAAoJEJr0azAldxsxWcAP/3jZ7YH89Jb01HWO5lOoZGKE mg6ntlKyl2xJ1ojsfXEgsvZSb/Fif5xY9qvkQHvHu5QIhXhkL6TjGjUM0w/vi3cL FQmv36Td/yOBzNB+tMxh4/TGl69P4POdVCKnfejDuAjwWK3z+26+vl73EIyxdoeU af1/0OCEFk80OUjBn9uh6ncr090Hi7dJJFBLWq2tD6l1XPpnnFv/iLCofWCMLluK MT4yYIhH+IT2cULEnvncqsAH0wtL0oZh0+PidW16YcMCrUsTfuh5o5L5gZpCqJkD OJ/N7oPG/iSdJtXaUW1BChPlzr5bnIRrrymLlbdWfjVLqZbOhCMWZR0I9Vwgw8ZS 6pCJK7AQOA2WaagncY66LJSVchf8I6rWPfY+WsPTJ7EMghnj0VaWejYUXeDJmcIk a0qlZy29bWTi3YezA5DyALTyCspXJMc+IBVN6VaxsF0JBSMuWfwvTW9DZPwKI704 D+XAT9keSDBv7kvTLNarpzOg46jt8QhiISgXvUlidESEf6FgwaYd309GvORH3aW3 euD7wOlex9qv5tLBYXLDikD2quczdYPTK3M4XStz+UV/l97Uo0J9YHLdmPnG8wl4 0J6gsXxN9/Y2RZsepXoP9Ftk6TUS6sI1B6/22gEgxukWXE0IEGKy6Kpu+M/qIOKu vlS0JG9TWPCBMXCkSFko =Lp6R -----END PGP SIGNATURE----- --=_O4UPIabXEXD54652pppocQ1--