From mikedep333@gmail.com Sun Jan 25 01:11:48 2015 Received: (at 742) by bugs.x2go.org; 25 Jan 2015 00:11:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A71463BC6A for <742@bugs.x2go.org>; Sun, 25 Jan 2015 01:11:48 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id r20so3728203wiv.0 for <742@bugs.x2go.org>; Sat, 24 Jan 2015 16:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=aiGI2LKO+YB/0NCpRyfGD8iYybw0e1bHSA1TfqCaQ5c=; b=zEjz3mGzAr/7LSzmyNtwP19maud/V74qLeiYKqSF3wzxChCarP7wRCUHTTS75K2g+6 JC7EYz8HFxK4gkW+w+Lh7hZUpnhieRi3IMj0Yxyk36ocoTFdyGVpIkr6/A4ZvPJN5ZLi 3qmFTp5ed7A45oNOL0TfGLnEbMtd2Nz8A1KlmzfZjtCefQKwF4e2HE4HOO4eCdOl7TQj Mr283tyBCqbkyrNUun0lO7MXKHcEr9yWfE7uMXvT2C50M/zOtOfnjDooaXlZSAbQPhC6 +LlTNjGsM3Do8dfnejA2Pj9IB8o/EY95ql0iP9wHMV66kcYJq9uBbXIWQoCuY8ryFp0T I1fw== MIME-Version: 1.0 X-Received: by 10.194.23.6 with SMTP id i6mr28294598wjf.26.1422144708329; Sat, 24 Jan 2015 16:11:48 -0800 (PST) Received: by 10.180.86.132 with HTTP; Sat, 24 Jan 2015 16:11:48 -0800 (PST) Date: Sat, 24 Jan 2015 19:11:48 -0500 Message-ID: Subject: Re: [X2Go-Dev] Bug#742: Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 From: Michael DePaulo To: 742@bugs.x2go.org, George Trakatelis Content-Type: text/plain; charset=UTF-8 Control: close -1 4.0.3.2 On Sat, Jan 24, 2015 at 6:30 PM, Michael DePaulo wrote: [...] >> On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote: >> >>>[...] >>> >>> The attached patch saves x2goclient from calling slotStartParec() >>> once per second unnecessarily. >> thanks for providing this patch, George. > > Thanks! > > I'll test the patch for regressions. If there are none, I will commit it. > (I will however delete that 1 line rather than comment it out.) I tested it successfully on XP 32-bit and on Windows 8.1 64-bit. So I applied it (after deleting that one commented out line.) Also, I did not bother to update the changelog because I feel this is a very minor change, and I do not want to bombard users with too many details in the changelog. I will confirm on x2go-project that doing so is OK. Thanks, -Mike#2