From unknown Thu Mar 28 14:55:07 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 Reply-To: "George Trakatelis" , 742@bugs.x2go.org Resent-From: "George Trakatelis" Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 14 Jan 2015 19:10:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 742 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.142126235223078 (code B); Wed, 14 Jan 2015 19:10:02 +0000 Received: (at submit) by bugs.x2go.org; 14 Jan 2015 19:05:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 885263BC67 for ; Wed, 14 Jan 2015 20:05:50 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id l18so10771545wgh.0 for ; Wed, 14 Jan 2015 11:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uom.edu.gr; s=google; h=from:to:cc:subject:date:message-id:mime-version:content-type :thread-index:content-language; bh=hhQv8yw2OQQcej/ZaULA/ZjBOCcZVimSYbo6OT9NwJ4=; b=S9I73SuJkczGmWiC+a05uWAqDlih56kyGEnXIVeRUH6uqM5uzV3DdQIKlrOrlAopdE LKL7SCyRvcDWb5RmVscza241H+WSn9tdlyHfdn+glLElyEpPu3trc4iWIEancZ5FfZy6 yJnTui9UoVxecE3ymFy9TX1QPKXYjTw4MJkHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:thread-index:content-language; bh=hhQv8yw2OQQcej/ZaULA/ZjBOCcZVimSYbo6OT9NwJ4=; b=PPkYOOcgK/CXB1MG2Iy8+2RzmlDUYkVy4Cstrxv6jshHG06jXGS6GXZoPYwqaBtZx9 to9y9yvWtcSFSLG99rH0dFxJGs+60n3YpA+MSepWpX2YzmXf+FUH5v757MA1FXWe/IiZ CQZeLd7cN450Ybnfg6tKJCT7X8g9SXHX4t7y6d98oeQUJBgNJq+dIFIh5dnBln2zOtuM KFCsoB3PdJViM3KlGAPJ+ATgDzJGgYVU2Bb/LpkISjQ/zjeJ2JPpixDGAoJ3YWZRQ1l/ FxKAsP5yZToeKCECUT0em+Qs8BLOf2Bq0MNCEplDCOMdF+NS0oHxeHGZVwebOQeCfZtU o3nQ== X-Gm-Message-State: ALoCoQklcJRDJdnFD1eBYGnV0v1l36/RGhT+4NLt/THdvcouZGlBZhU9nifG8ucG6Bnt0xnpM+dv X-Received: by 10.180.36.162 with SMTP id r2mr19744990wij.75.1421262350056; Wed, 14 Jan 2015 11:05:50 -0800 (PST) Received: from HomePC (46-198-127-233.adsl.cyta.gr. [46.198.127.233]) by mx.google.com with ESMTPSA id fc6sm19813277wib.12.2015.01.14.11.05.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Jan 2015 11:05:49 -0800 (PST) From: "George Trakatelis" To: Cc: "'Michael DePaulo'" Date: Wed, 14 Jan 2015 21:05:46 +0200 Message-ID: <000001d0302d$1bc018a0$534049e0$@edu.gr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0001_01D0303D.DF48E8A0" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdAwLRn27zdagHBEQwylGDCQksl76w== Content-Language: el This is a multi-part message in MIME format. ------=_NextPart_000_0001_01D0303D.DF48E8A0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.3.0 When trying to figure out why I get 'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' in the debugging output of X2Go Client for Windows 4.0.3.0, I bumped onto a common error: Argument mismatch between function call and function definition. That prevents slotSndTunOk() from ever executing. slotStartParec() depends on slotSndTunOk() to execute parec. Executing parec was needed due to a PulseAudio's bug as explained in http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec One peculiar thing is that after fixing that mismatch, which enabled parec to execute, x2goclient became extremely sluggish. The only way to revert things back to normal was to prevent parec from ever executing. It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0. The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily. Dept. of Applied Informatics, University of Macedonia George Trakatelis ------=_NextPart_000_0001_01D0303D.DF48E8A0 Content-Type: application/octet-stream; name="disable-calling-parec.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="disable-calling-parec.patch" diff --git a/onmainwindow.cpp b/onmainwindow.cpp=0A= index 8e2e11a..829f27c 100644=0A= --- a/onmainwindow.cpp=0A= +++ b/onmainwindow.cpp=0A= @@ -5124,7 +5124,7 @@ void ONMainWindow::slotRetResumeSess ( bool result,=0A= if ( sndSystem=3D=3DPULSE )=0A= {=0A= parecTunnelOk=3Dfalse;=0A= - okSlot=3DSLOT ( slotSndTunOk(int) );=0A= + okSlot=3DSLOT ( slotSndTunOk() );=0A= }=0A= #endif=0A= sndTunnel=3DsshConnection->startTunnel (=0A= @@ -11411,7 +11411,7 @@ void ONMainWindow::slotStartParec ()=0A= "/.pulse-client.conf "+=0A= "parec 1> /dev/null & sleep 1 && kill %1";=0A= =0A= - sshConnection->executeCommand ( scmd );=0A= +// sshConnection->executeCommand ( scmd );=0A= }=0A= #endif=0A= =0A= ------=_NextPart_000_0001_01D0303D.DF48E8A0--