Subject: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0

From: "George Trakatelis" <[email-masked]>
Date: Wed, 14 Jan 2015 21:05:46 +0200

Package: x2goclient
Version: 4.0.3.0

When trying to figure out why I get 
'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' 
in the debugging output of X2Go Client for Windows 4.0.3.0, 
I bumped onto a common error: 
Argument mismatch between function call and function definition. 
That prevents slotSndTunOk() from ever executing. 

slotStartParec() depends on slotSndTunOk() to execute parec. 
Executing parec was needed due to a PulseAudio's bug as explained in 
http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec

One peculiar thing is that after fixing that mismatch, 
which enabled parec to execute, 
x2goclient became extremely sluggish. 
The only way to revert things back to normal 
was to prevent parec from ever executing. 
It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0.

The attached patch saves x2goclient from calling slotStartParec() 
once per second unnecessarily. 

Dept. of Applied Informatics, University of Macedonia
George Trakatelis