From unknown Thu Apr 16 01:22:46 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#742 closed by Michael DePaulo (Re: [X2Go-Dev] Bug#742: Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0) Message-ID: References: X-X2go-PR-Keywords: patch X-X2go-PR-Message: they-closed 742 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Sun, 25 Jan 2015 00:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1422144902-4961-0" This is a multi-part message in MIME format... ------------=_1422144902-4961-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #742: Executing parec seems unnecessary now that X2Go Client for Windows 4.= 0.3.0 uses PulseAudio 5.0 It has been closed by Michael DePaulo . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Michael DePaulo by replying to this email. --=20 742: http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D742 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1422144902-4961-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 742) by bugs.x2go.org; 25 Jan 2015 00:11:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham version=3.3.2 Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id A71463BC6A for <742@bugs.x2go.org>; Sun, 25 Jan 2015 01:11:48 +0100 (CET) Received: by mail-wi0-f173.google.com with SMTP id r20so3728203wiv.0 for <742@bugs.x2go.org>; Sat, 24 Jan 2015 16:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=aiGI2LKO+YB/0NCpRyfGD8iYybw0e1bHSA1TfqCaQ5c=; b=zEjz3mGzAr/7LSzmyNtwP19maud/V74qLeiYKqSF3wzxChCarP7wRCUHTTS75K2g+6 JC7EYz8HFxK4gkW+w+Lh7hZUpnhieRi3IMj0Yxyk36ocoTFdyGVpIkr6/A4ZvPJN5ZLi 3qmFTp5ed7A45oNOL0TfGLnEbMtd2Nz8A1KlmzfZjtCefQKwF4e2HE4HOO4eCdOl7TQj Mr283tyBCqbkyrNUun0lO7MXKHcEr9yWfE7uMXvT2C50M/zOtOfnjDooaXlZSAbQPhC6 +LlTNjGsM3Do8dfnejA2Pj9IB8o/EY95ql0iP9wHMV66kcYJq9uBbXIWQoCuY8ryFp0T I1fw== MIME-Version: 1.0 X-Received: by 10.194.23.6 with SMTP id i6mr28294598wjf.26.1422144708329; Sat, 24 Jan 2015 16:11:48 -0800 (PST) Received: by 10.180.86.132 with HTTP; Sat, 24 Jan 2015 16:11:48 -0800 (PST) Date: Sat, 24 Jan 2015 19:11:48 -0500 Message-ID: Subject: Re: [X2Go-Dev] Bug#742: Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 From: Michael DePaulo To: 742@bugs.x2go.org, George Trakatelis Content-Type: text/plain; charset=UTF-8 Control: close -1 4.0.3.2 On Sat, Jan 24, 2015 at 6:30 PM, Michael DePaulo wrote: [...] >> On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote: >> >>>[...] >>> >>> The attached patch saves x2goclient from calling slotStartParec() >>> once per second unnecessarily. >> thanks for providing this patch, George. > > Thanks! > > I'll test the patch for regressions. If there are none, I will commit it. > (I will however delete that 1 line rather than comment it out.) I tested it successfully on XP 32-bit and on Windows 8.1 64-bit. So I applied it (after deleting that one commented out line.) Also, I did not bother to update the changelog because I feel this is a very minor change, and I do not want to bombard users with too many details in the changelog. I will confirm on x2go-project that doing so is OK. Thanks, -Mike#2 ------------=_1422144902-4961-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 14 Jan 2015 19:05:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 885263BC67 for ; Wed, 14 Jan 2015 20:05:50 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id l18so10771545wgh.0 for ; Wed, 14 Jan 2015 11:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uom.edu.gr; s=google; h=from:to:cc:subject:date:message-id:mime-version:content-type :thread-index:content-language; bh=hhQv8yw2OQQcej/ZaULA/ZjBOCcZVimSYbo6OT9NwJ4=; b=S9I73SuJkczGmWiC+a05uWAqDlih56kyGEnXIVeRUH6uqM5uzV3DdQIKlrOrlAopdE LKL7SCyRvcDWb5RmVscza241H+WSn9tdlyHfdn+glLElyEpPu3trc4iWIEancZ5FfZy6 yJnTui9UoVxecE3ymFy9TX1QPKXYjTw4MJkHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:thread-index:content-language; bh=hhQv8yw2OQQcej/ZaULA/ZjBOCcZVimSYbo6OT9NwJ4=; b=PPkYOOcgK/CXB1MG2Iy8+2RzmlDUYkVy4Cstrxv6jshHG06jXGS6GXZoPYwqaBtZx9 to9y9yvWtcSFSLG99rH0dFxJGs+60n3YpA+MSepWpX2YzmXf+FUH5v757MA1FXWe/IiZ CQZeLd7cN450Ybnfg6tKJCT7X8g9SXHX4t7y6d98oeQUJBgNJq+dIFIh5dnBln2zOtuM KFCsoB3PdJViM3KlGAPJ+ATgDzJGgYVU2Bb/LpkISjQ/zjeJ2JPpixDGAoJ3YWZRQ1l/ FxKAsP5yZToeKCECUT0em+Qs8BLOf2Bq0MNCEplDCOMdF+NS0oHxeHGZVwebOQeCfZtU o3nQ== X-Gm-Message-State: ALoCoQklcJRDJdnFD1eBYGnV0v1l36/RGhT+4NLt/THdvcouZGlBZhU9nifG8ucG6Bnt0xnpM+dv X-Received: by 10.180.36.162 with SMTP id r2mr19744990wij.75.1421262350056; Wed, 14 Jan 2015 11:05:50 -0800 (PST) Received: from HomePC (46-198-127-233.adsl.cyta.gr. [46.198.127.233]) by mx.google.com with ESMTPSA id fc6sm19813277wib.12.2015.01.14.11.05.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 Jan 2015 11:05:49 -0800 (PST) From: "George Trakatelis" To: Cc: "'Michael DePaulo'" Subject: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 Date: Wed, 14 Jan 2015 21:05:46 +0200 Message-ID: <000001d0302d$1bc018a0$534049e0$@edu.gr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0001_01D0303D.DF48E8A0" X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdAwLRn27zdagHBEQwylGDCQksl76w== Content-Language: el This is a multi-part message in MIME format. ------=_NextPart_000_0001_01D0303D.DF48E8A0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.3.0 When trying to figure out why I get 'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' in the debugging output of X2Go Client for Windows 4.0.3.0, I bumped onto a common error: Argument mismatch between function call and function definition. That prevents slotSndTunOk() from ever executing. slotStartParec() depends on slotSndTunOk() to execute parec. Executing parec was needed due to a PulseAudio's bug as explained in http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec One peculiar thing is that after fixing that mismatch, which enabled parec to execute, x2goclient became extremely sluggish. The only way to revert things back to normal was to prevent parec from ever executing. It seems that parec in not needed now that X2Go Client uses PulseAudio 5.0. The attached patch saves x2goclient from calling slotStartParec() once per second unnecessarily. Dept. of Applied Informatics, University of Macedonia George Trakatelis ------=_NextPart_000_0001_01D0303D.DF48E8A0 Content-Type: application/octet-stream; name="disable-calling-parec.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="disable-calling-parec.patch" diff --git a/onmainwindow.cpp b/onmainwindow.cpp=0A= index 8e2e11a..829f27c 100644=0A= --- a/onmainwindow.cpp=0A= +++ b/onmainwindow.cpp=0A= @@ -5124,7 +5124,7 @@ void ONMainWindow::slotRetResumeSess ( bool result,=0A= if ( sndSystem=3D=3DPULSE )=0A= {=0A= parecTunnelOk=3Dfalse;=0A= - okSlot=3DSLOT ( slotSndTunOk(int) );=0A= + okSlot=3DSLOT ( slotSndTunOk() );=0A= }=0A= #endif=0A= sndTunnel=3DsshConnection->startTunnel (=0A= @@ -11411,7 +11411,7 @@ void ONMainWindow::slotStartParec ()=0A= "/.pulse-client.conf "+=0A= "parec 1> /dev/null & sleep 1 && kill %1";=0A= =0A= - sshConnection->executeCommand ( scmd );=0A= +// sshConnection->executeCommand ( scmd );=0A= }=0A= #endif=0A= =0A= ------=_NextPart_000_0001_01D0303D.DF48E8A0-- ------------=_1422144902-4961-0--