From mike.gabriel@das-netzwerkteam.de Thu Jan 15 10:04:19 2015 Received: (at 742) by bugs.x2go.org; 15 Jan 2015 09:04:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 6D4AF3BC67 for <742@bugs.x2go.org>; Thu, 15 Jan 2015 10:04:19 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 0B00EC99; Thu, 15 Jan 2015 10:04:19 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D5A023BA20; Thu, 15 Jan 2015 10:04:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IncnxF+k4gTI; Thu, 15 Jan 2015 10:04:18 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id A54173B9E7; Thu, 15 Jan 2015 10:04:18 +0100 (CET) Received: from 134.245.44.3 ([134.245.44.3]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Thu, 15 Jan 2015 09:04:18 +0000 Date: Thu, 15 Jan 2015 09:04:18 +0000 Message-ID: <20150115090418.Horde.Fk6KrbIyXfEcZRKF41xrbg1@mail.das-netzwerkteam.de> From: Mike Gabriel To: George Trakatelis , 742@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#742: Executing parec seems unnecessary now that X2Go Client for Windows 4.0.3.0 uses PulseAudio 5.0 In-Reply-To: <000001d0302d$1bc018a0$534049e0$@edu.gr> User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 134.245.44.3 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=_duFatbilqqDSmE41OIfB7w3"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_duFatbilqqDSmE41OIfB7w3 Content-Type: text/plain; charset=us-ascii; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: tag -1 patch Hi George, hi Mike#2, On Mi 14 Jan 2015 20:05:46 CET, George Trakatelis wrote: > When trying to figure out why I get > 'Object::connect: No such slot ONMainWindow::slotSndTunOk(int)' > in the debugging output of X2Go Client for Windows 4.0.3.0, > I bumped onto a common error: > Argument mismatch between function call and function definition. > That prevents slotSndTunOk() from ever executing. > > slotStartParec() depends on slotSndTunOk() to execute parec. > Executing parec was needed due to a PulseAudio's bug as explained in > http://x2go-dev.x2go.narkive.com/wNgRoxTO/parec > > One peculiar thing is that after fixing that mismatch, > which enabled parec to execute, > x2goclient became extremely sluggish. > The only way to revert things back to normal > was to prevent parec from ever executing. > It seems that parec in not needed now that X2Go Client uses PulseAudio 5.= 0. > > The attached patch saves x2goclient from calling slotStartParec() > once per second unnecessarily. thanks for providing this patch, George. @Mike#2: I know that the component owner concept is not yet in=20=20 place...=20But do you feel like taking over bug triaging for X2Go Client=20= =20 completely=20(as offered in one of your previous mails). If no, please=20= =20 me=20(and others) no via x2go-project ML (because then we need to find a=20= =20 way=20of triaging X2Go Client bugs ASAP). If you still volunteer for=20=20 this=20task, feel free to ping me for feedback whenever needed. From now on, I will hold my feet still for incoming patches if they=20=20 don't=20address pyhoca-gui, pyhoca-cli, python-x2go, x2gobroker or=20=20 nx-libs.=20I will be so free and tag bugs with "patch" whenever I spot a=20= =20 bug=20that ships a patch. Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=_duFatbilqqDSmE41OIfB7w3 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUt4KSAAoJEJr0azAldxsxe4YP/0vMd5WFdcKu0lw0BV3IW2OC G2tAZd3Gnr8MmM4zjNVj1V0U6hrtiwzBWPzFUSg3wG4+FKUwpfxknQmjKJsL7wI2 24cZEwrkHwtxPAHdd522IpBEbUUzIdYX5XRn4UiJpSfALRLxXaHdGa7CrxDaQrlS wff636ug10mG+DzW7ujgK9QsMrT3xKXHzY3NlsBjKkl2oDsK8xI0QLJsNUiNVUHo KWfE+b3fp8Q9m9mCI7fMOzCibE+UeBHFToqn5McB8Og2vgHnlNVWRWVbAPM/9kAU Mvse1PQfGp8fxLbE6/Sb6K8Ap4uMehhBsI5fJc57DzSB5T99zWb6AzmfyM2qrJpc aaMnnuGTBHZO2B9WaVKM8WhkpreUwFAlJB9WFTqRNiS6TxW5sqE756XfVbpgqXLL mXl28EwrJaPOIBFeljHKNfO1UXLYgHl74tv24/l1uoZGQGSQNqMYYIMf95z8ztkV H04FSkXmL6V6HnTutRWf0Xa2I+x9WJ4WO46OZOFFAPz1wDjS2HrOZCawv3W+Eym4 p1pWFynQJCODO9DPU4f4E5kU47v+TJwpzKkTJoappp998CyZ7j/y0LfLmy8S69ds 6eI9WWXl5MIiWDs7Ey2XYk/kwPTgBigu+XntOVtWJIAjt3HUZl0t9STJ36yF96XI YK7K5yFe+/injTvQ/Wik =7oqG -----END PGP SIGNATURE----- --=_duFatbilqqDSmE41OIfB7w3--