X2Go Bug report logs - #741
Default keystrokes are not fully overwritten

version graph

Package: nxagent; Maintainer for nxagent is X2Go Developers <x2go-dev@lists.x2go.org>; Source for nxagent is src:nx-libs.

Reported by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>

Date: Mon, 12 Jan 2015 20:50:01 UTC

Severity: normal

Tags: pending

Found in version 2:3.5.0.28-0x2go1+git20141113.546+wheezy.main.1

Fixed in version 2:3.5.0.29

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#741: [PATCH] fix typo in 320_nxagent_configurable-keystrokes.full.patch
Reply-To: Horst Schirmeier <horst@schirmeier.com>, 741@bugs.x2go.org
Resent-From: Horst Schirmeier <horst@schirmeier.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Mon, 12 Jan 2015 22:40:02 +0000
Resent-Message-ID: <handler.741.B741.14211023748880@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 741
X-X2Go-PR-Package: nxagent
X-X2Go-PR-Keywords: 
Received: via spool by 741-submit@bugs.x2go.org id=B741.14211023748880
          (code B ref 741); Mon, 12 Jan 2015 22:40:02 +0000
Received: (at 741) by bugs.x2go.org; 12 Jan 2015 22:39:34 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: **
X-Spam-Status: No, score=2.5 required=5.0 tests=BAYES_50,SUBJ_OBFU_PUNCT_MANY
	autolearn=no version=3.3.2
X-Greylist: delayed 401 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Mon, 12 Jan 2015 23:39:33 CET
Received: from quickstop.soohrt.org (quickstop.soohrt.org [85.131.246.152])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id EDB3B5DEAB
	for <741@bugs.x2go.org>; Mon, 12 Jan 2015 23:39:33 +0100 (CET)
Received: (qmail 15707 invoked by uid 1014); 12 Jan 2015 22:32:52 -0000
Date: Mon, 12 Jan 2015 23:32:52 +0100
From: Horst Schirmeier <horst@schirmeier.com>
To: 741@bugs.x2go.org
Message-ID: <20150112223252.GG22378@quickstop.soohrt.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)

This suble parenthesis typo made the R_OK check for
/etc/nxagent/keystrokes.cfg always fail.  As a consequence, only
~/.nx/config/keystrokes.cfg could be used for custom keystrokes.

This should fix bug #741.
---
 debian/patches/320_nxagent_configurable-keystrokes.full.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/320_nxagent_configurable-keystrokes.full.patch b/debian/patches/320_nxagent_configurable-keystrokes.full.patch
index ae1897d..bcb8ef2 100644
--- a/debian/patches/320_nxagent_configurable-keystrokes.full.patch
+++ b/debian/patches/320_nxagent_configurable-keystrokes.full.patch
@@ -481,7 +481,7 @@ Description: Make nxagent-specific keyboard bindings configurable
 +    {
 +      /* empty */
 +    }
-+    else if (access(etcfile, R_OK == 0))
++    else if (access(etcfile, R_OK) == 0)
 +    {
 +      if (filename)
 +        free(filename);

-- 
PGP-Key 0xD40E0E7A

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Sat Dec 13 21:51:59 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.