From alavaliant@ra09.com Mon Jan 5 06:08:21 2015 Received: (at submit) by bugs.x2go.org; 5 Jan 2015 05:08:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from thetower.ra09.com (ra09.com [202.124.104.240]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 5DFF65DB48 for ; Mon, 5 Jan 2015 06:08:21 +0100 (CET) Received: from localhost ([127.0.0.1] helo=private.ra09.com) by thetower.ra09.com with esmtp (Exim 4.80) (envelope-from ) id 1Y7zto-00045O-LA for submit@bugs.x2go.org; Mon, 05 Jan 2015 18:08:17 +1300 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_2eac67d1ac0e696a2eb101dac646ac37" Date: Mon, 05 Jan 2015 18:08:16 +1300 From: Jason Alavaliant To: submit@bugs.x2go.org Subject: python-x2gobroker web/plain module strips passwords breaking passwords that start or end with a space Message-ID: X-Sender: alavaliant@ra09.com User-Agent: Roundcube Webmail/1.0.4 --=_2eac67d1ac0e696a2eb101dac646ac37 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Package: python-x2gobroker Version: 0.0.2.3 Tags: patch One of my users was getting their authentication failing when connecting to an x2go broker using the http plain backend. Testing revealed that their password ended with a space which the web/plain module default code was automatically stripping off before passing through to the authservice. The attached patch disables stripping for the password argument so passwords starting/ending with spaces are no longer incorrectly rejected. Thanks Jason --=_2eac67d1ac0e696a2eb101dac646ac37 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="=?UTF-8?Q?x2gobroker-web-plain=2Epy-handle-spaces-at-start-and-end?= =?UTF-8?Q?-of-passwords=2Epatch?=" Content-Disposition: attachment; filename*0*=UTF-8''x2gobroker-web-plain.py-handle-spaces-at-start-and-end; filename*1*=-of-passwords.patch; size=538 LS0tIG9sZC9wbGFpbi5weQkyMDE1LTAxLTA1IDE3OjE5OjQ1LjQ5ODU2NDYwNSArMTMwMAorKysg bmV3L3BsYWluLnB5CTIwMTUtMDEtMDUgMTc6MTY6NDcuOTU4OTU4NzQwICsxMzAwCkBAIC05Niw3 ICs5Niw3IEBACiAgICAgICAgICAgICByYWlzZSB0b3JuYWRvLndlYi5IVFRQRXJyb3IoNDA0KQog CiAgICAgICAgIHVzZXJuYW1lID0gc2VsZi5nZXRfYXJndW1lbnQoJ3VzZXInLCBkZWZhdWx0PScn KQotICAgICAgICBwYXNzd29yZCA9IHNlbGYuZ2V0X2FyZ3VtZW50KCdwYXNzd29yZCcsIGRlZmF1 bHQ9JycpCisgICAgICAgIHBhc3N3b3JkID0gc2VsZi5nZXRfYXJndW1lbnQoJ3Bhc3N3b3JkJywg ZGVmYXVsdD0nJywgc3RyaXA9RmFsc2UpCiAgICAgICAgIGNvb2tpZSA9IHNlbGYuZ2V0X2FyZ3Vt ZW50KCdjb29raWUnLCBkZWZhdWx0PScnKQogICAgICAgICB0YXNrID0gc2VsZi5nZXRfYXJndW1l bnQoJ3Rhc2snLCBkZWZhdWx0PScnKQogICAgICAgICBwcm9maWxlX2lkID0gc2VsZi5nZXRfYXJn dW1lbnQoJ3NpZCcsIGRlZmF1bHQ9JycpCg== --=_2eac67d1ac0e696a2eb101dac646ac37--