From unknown Sat Apr 04 18:42:28 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#715: Proposed patch Reply-To: Michael DePaulo , 715@bugs.x2go.org Resent-From: Michael DePaulo Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 05 Jan 2015 04:15:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 715 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by 715-submit@bugs.x2go.org id=B715.142043112714581 (code B ref 715); Mon, 05 Jan 2015 04:15:01 +0000 Received: (at 715) by bugs.x2go.org; 5 Jan 2015 04:12:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 77B865DB48 for <715@bugs.x2go.org>; Mon, 5 Jan 2015 05:12:05 +0100 (CET) Received: by mail-we0-f177.google.com with SMTP id q59so7075440wes.8 for <715@bugs.x2go.org>; Sun, 04 Jan 2015 20:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Pq7E1UWzPGQ+80JdiQe9gbkvYY780ULLTv7blYBmhy8=; b=kGizseSz7YNh5/GYjFNpY9Hs5xHmlW5mhnQLq0ZiVLD09iJjfafrfnBUA/be+723V+ cqHVFVZvNO8ywb12NEwKG82yGYBrOqZAgc/NvxGNUmzazEx7wIEzVPXpDTNVYAaW9a9U YGGA36SfSNsaMJSlQC5huPLoXvY46CFPVb/mbyqWIb1yFo9OT7wx8cGfZEoSU+7u20bb YEehOPKtBUjrCXZRy4CehV5jxEHjFiJaw3tfKaNWRW4Wdb76ZIfzUiICUOtpO2x9SzYH fjECqHiof2gUiXhX2ld0V88p7PPCF5MKaAFxGtA32n6hbhmROJLVLmNdIjN/KpfsTPPW b5gA== MIME-Version: 1.0 X-Received: by 10.180.21.178 with SMTP id w18mr21119138wie.78.1420431124617; Sun, 04 Jan 2015 20:12:04 -0800 (PST) Received: by 10.180.90.116 with HTTP; Sun, 4 Jan 2015 20:12:04 -0800 (PST) Date: Sun, 4 Jan 2015 23:12:04 -0500 Message-ID: From: Michael DePaulo To: 715@bugs.x2go.org Content-Type: multipart/mixed; boundary=047d7bb70a7c9cf3d6050bdfe4a0 --047d7bb70a7c9cf3d6050bdfe4a0 Content-Type: text/plain; charset=UTF-8 Tags: patch I would like someone who knows Perl better, such as theUser2, to review this patch. Although this is a very small patch, theUser2 advised me to be careful when creating full paths. I tested it successfully under CentOS 5 and CentOS 6. I intended to use "make_path" instead of "mkpath" if File::Path 2.06 or later was detected. However, I could not figure out how to write a statement like "use File::Path( make_path)" if File::Path->VERSION is 2.06 or later. Specifically, it appears that "use" statements are executed at compile time in Perl, so they cannot be used within an if block. And I cannot just specify "use File::Path" for all versions of File::Path because "make_path" is not exported by default. EPEL 5: http://perldoc.perl.org/5.8.8/File/Path.html EPEL 6: http://perldoc.perl.org/5.10.1/File/Path.html Latest: http://perldoc.perl.org/File/Path.html --047d7bb70a7c9cf3d6050bdfe4a0 Content-Type: application/octet-stream; name="perl-File-Path-epel5-compat-v3.patch" Content-Disposition: attachment; filename="perl-File-Path-epel5-compat-v3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i4jbjb570 ZGlmZiAtLWdpdCBhL3gyZ29zZXJ2ZXIvc2Jpbi94MmdvZGJhZG1pbiBiL3gyZ29zZXJ2ZXIvc2Jp bi94MmdvZGJhZG1pbgppbmRleCA2NzY5MjU3Li4yMDE3NWUyIDEwMDc1NQotLS0gYS94Mmdvc2Vy dmVyL3NiaW4veDJnb2RiYWRtaW4KKysrIGIveDJnb3NlcnZlci9zYmluL3gyZ29kYmFkbWluCkBA IC0yMiw3ICsyMiw5IEBACiAKIHVzZSBzdHJpY3Q7CiB1c2UgU3lzOjpTeXNsb2cgcXcoIDpzdGFu ZGFyZCA6bWFjcm9zICk7Ci11c2UgRmlsZTo6UGF0aCBxdyggbWFrZV9wYXRoICk7CisjIFdlIGNh biBTd2l0Y2ggdG8gbWFrZV9wYXRoIG9uY2UgRVBFTCA1IChQZXJsIDUuOC44ICYgRmlsZTo6UGF0 aCAxLjA2KQorIyBpcyBubyBsb25nZXIgc3VwcG9ydGVkLgordXNlIEZpbGU6OlBhdGggcXcoIG1r cGF0aCApOwogdXNlIEdldG9wdDo6TG9uZzsKIHVzZSBDb25maWc6OlNpbXBsZTsgICAKIHVzZSBE Qkk7CkBAIC04Myw3ICs4NSw3IEBAIGlmICgkQ29uZmlnLT5wYXJhbSgiYmFja2VuZCIpIGVxICdz cWxpdGUnKQogCXsKIAkJaWYgKCEgLWQgIiRkaXIiICkKIAkJewotCQkJbWFrZV9wYXRoKCIkZGly Iik7CisJCQlta3BhdGgoIiRkaXIiKTsKIAkJfQogCQlpZiAoIC1lICRkYmZpbGUpCiAJCXsKQEAg LTM0Niw3ICszNDgsNyBAQCBzdWIgYWRkX3VzZXIoKQogCiAJaWYgKCEgLWQgIiRkaXIvLngyZ28i ICkKIAl7Ci0JCW1ha2VfcGF0aCgiJGRpci8ueDJnbyIpOworCQlta3BhdGgoIiRkaXIvLngyZ28i KTsKIAl9CiAKIAkjc2F2ZSB1c2VyIHBhc3N3b3JkCg== --047d7bb70a7c9cf3d6050bdfe4a0--