From unknown Sat Apr 04 18:42:27 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#715: [X2Go-Dev] Bug#715: Proposed patch Reply-To: Mike Gabriel , 715@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 05 Jan 2015 10:15:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 715 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by 715-submit@bugs.x2go.org id=B715.142045281812763 (code B ref 715); Mon, 05 Jan 2015 10:15:02 +0000 Received: (at 715) by bugs.x2go.org; 5 Jan 2015 10:13:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id D740A5DB48 for <715@bugs.x2go.org>; Mon, 5 Jan 2015 11:13:35 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id 4725EE43; Mon, 5 Jan 2015 11:13:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 3242F3C84E; Mon, 5 Jan 2015 11:13:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 82aLvy6cpUXF; Mon, 5 Jan 2015 11:13:35 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id ECC203BAF8; Mon, 5 Jan 2015 11:13:34 +0100 (CET) Received: from bifrost.das-netzwerkteam.de (bifrost.das-netzwerkteam.de [178.62.101.154]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 05 Jan 2015 10:13:34 +0000 Date: Mon, 05 Jan 2015 10:13:34 +0000 Message-ID: <20150105101334.Horde.2WQ_Ieu5pzXhDeMONJTlrg1@mail.das-netzwerkteam.de> From: Mike Gabriel To: Michael DePaulo , 715@bugs.x2go.org In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.2.2) Accept-Language: en,de Organization: DAS-NETZWERKTEAM X-Originating-IP: 178.62.101.154 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Iceweasel/32.0 Content-Type: multipart/signed; boundary="=__Epd56MwPdY0WFZ3yvEwYg6"; protocol="application/pgp-signature"; micalg=pgp-sha1 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=__Epd56MwPdY0WFZ3yvEwYg6 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Michael, On Mo 05 Jan 2015 05:12:04 CET, Michael DePaulo wrote: > Tags: patch > > I would like someone who knows Perl better, such as theUser2, to > review this patch. > > Although this is a very small patch, theUser2 advised me to be careful > when creating full paths. > > I tested it successfully under CentOS 5 and CentOS 6. > > I intended to use "make_path" instead of "mkpath" if File::Path 2.06 > or later was detected. However, I could not figure out how to write a > statement like "use File::Path( make_path)" if File::Path->VERSION is > 2.06 or later. Specifically, it appears that "use" statements are > executed at compile time in Perl, so they cannot be used within an if > block. And I cannot just specify "use File::Path" for all versions of > File::Path because "make_path" is not exported by default. > > EPEL 5: > http://perldoc.perl.org/5.8.8/File/Path.html > > EPEL 6: > http://perldoc.perl.org/5.10.1/File/Path.html > > Latest: > http://perldoc.perl.org/File/Path.html I recommend a more conditional approach testing the existence of the=20=20 make_path=20(and the mkpath) function during runtimed using the=20=20 "defined"=20command. See:=20=20 http://stackoverflow.com/questions/433752/how-can-i-determine-if-a-perl-fun= ction-exists-at-runtime Mike --=20 DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.x= fb --=__Epd56MwPdY0WFZ3yvEwYg6 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJUqmPOAAoJEJr0azAldxsxBzkQAKeGReav1NELhtsx7MYlp6WQ CDSQPAlLdWpBRhkFJRIduLqNzryLiFl1ZcNc7WonxcvM5hK4Q15Fg5e6X8xGa6n8 KsYnD42Kv/Kbe4wdTHsolvlBlgPwCCzJpr2BH8p+qUCXMCm/KGxghME3qqx9P3Rb rKsCuUerhvTJQB3aB85kcG3+2gzEoSyNDwJgK3MxWq5l/PZEO6czSNNS6OyfdoDw iZvF9k65B28YTH2OObeTlR3ECzpmXjkM8K/bkoEZ63+bwYFW5xld5MVzpj4HBce/ ri1zZcTb5iLqWGwXEEimn6wP1BFwI4BNdOr09flfzcpaQq6iYmQbbuBJp1ygrWSH KUeeYDSZsw6J0YVh93rmHNqdNZjTq2P2fikMqTxev78HEPsB/g8Bfc8mFgsPfYc0 MM1tjSLNvXUNgIJdt/y8BC/PnjFPhqQ6xqdIHGvhsaPuchuAHMOlDOjMg5r8fWa8 O5Dlyk2tz7vbKjpbi0nkcsgEruNCWvd22z9RLtYSSkMOGOBSxG94qcMtTQefft+G k0EfaB2n/fO55KdNNRDMlLsLLYIteaK5BxGggB/FGjAlWh9WB0eQ+kh5Y5E61MBt zpxgshK7Ai5aQ1qp20xriS/luxxMlwrUfrIIKaasYZ1ba6slCd5UfRswlegsU4Oh ypwmFV8chH5wSKSbSel0 =M2pW -----END PGP SIGNATURE----- --=__Epd56MwPdY0WFZ3yvEwYg6--