X2Go Bug report logs - #695
Fwd: [Bug 1172639] New: [abrt] nxagent: XKeycodeToKeysym(): nxagent killed by SIGSEGV

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#695: Fwd: [Bug 1172639] New: [abrt] nxagent: XKeycodeToKeysym(): nxagent killed by SIGSEGV
Reply-To: Orion Poplawski <orion@cora.nwra.com>, 695@bugs.x2go.org
Resent-From: Orion Poplawski <orion@cora.nwra.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Wed, 10 Dec 2014 16:30:01 +0000
Resent-Message-ID: <handler.695.B.141822872329977@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: report 695
X-X2Go-PR-Package: nx-libs
X-X2Go-PR-Keywords: 
Received: via spool by submit@bugs.x2go.org id=B.141822872329977
          (code B); Wed, 10 Dec 2014 16:30:01 +0000
Received: (at submit) by bugs.x2go.org; 10 Dec 2014 16:25:23 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID,
	URIBL_BLOCKED autolearn=ham version=3.3.2
Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id DD5895E0EB
	for <submit@bugs.x2go.org>; Wed, 10 Dec 2014 17:25:20 +0100 (CET)
Received: from [10.10.20.7] (barry.cora.nwra.com [10.10.20.7])
	(authenticated bits=0)
	by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id sBAGPIiJ021871
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO)
	for <submit@bugs.x2go.org>; Wed, 10 Dec 2014 09:25:18 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com;
	s=default; t=1418228718;
	bh=TVtvQVa2dzogKnpBfT9t7YU4U28RG+zAJm0TB5G6PEs=;
	h=Message-ID:Date:From:MIME-Version:To:Subject:References:
	 In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=ExAdoiXt/VBvv+YbpnAyoCVjoU1hOHaqmaBFVbbj+1ljSzeWoKwaUdivKIyuzy8Zx
	 QgczC9dTdCnsVmOxfJBxvr9Qcs+NNwQL1zt25UMcmmOEniwk2P/yN4oTfg9bOjVm6V
	 rMTQ/bGubc+Pui7yc9UAKnOmvJ87uGS7GzYRFN/E=
Message-ID: <548873EE.50902@cora.nwra.com>
Date: Wed, 10 Dec 2014 09:25:18 -0700
From: Orion Poplawski <orion@cora.nwra.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: submit@bugs.x2go.org
References: <bug-1172639-140047@bugzilla.redhat.com>
In-Reply-To: <bug-1172639-140047@bugzilla.redhat.com>
X-Forwarded-Message-Id: <bug-1172639-140047@bugzilla.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Package: nx-libs
Version: 3.5.0.28

Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `/usr/lib64/nx/../x2go/bin/x2goagent -extension XFIXES
-nolisten tcp -nolisten t'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  XKeycodeToKeysym (dpy=0x3ece520, kc=0 '\000', col=0) at XKBBind.c:122
122	    if ((kc<xkb->min_key_code)||(kc>xkb->max_key_code))

Thread 1 (Thread 0x7f1ca40e7740 (LWP 1903)):
#0  XKeycodeToKeysym (dpy=0x3ece520, kc=0 '\000', col=0) at XKBBind.c:122
        xkb = 0x0


XKeycodeToKeysym(Display *dpy,
#if NeedWidePrototypes
                 unsigned int kc,
#else
                 KeyCode kc,
#endif
                 int col)
{
    XkbDescRec  *xkb;

    if (_XkbUnavailable(dpy))
        return _XKeycodeToKeysym(dpy, kc, col);

    _XkbCheckPendingRefresh(dpy,dpy->xkb_info);

    xkb = dpy->xkb_info->desc;
    if ((kc<xkb->min_key_code)||(kc>xkb->max_key_code))


Looks like we need a check for xkb being NULL before trying to reference it.

Looks like this is supposed to do that:

#define _XkbUnavailable(d) \
        (((d)->flags&XlibDisplayNoXkb) ||\
         ((!(d)->xkb_info || (!(d)->xkb_info->desc)) && !_XkbLoadDpy(d)))

And _XkbLoadDpy(d) should have initialized dpy->xkb_info->desc, so I'm really
not sure how this could happen.  Unless _XkbCheckPendingRefresh could have set
it back to NULL:

#define _XkbCheckPendingRefresh(d,xi) {\
    if ((xi)->flags&XkbXlibNewKeyboard)\
        _XkbReloadDpy((d));\
    else if ((xi)->flags&XkbMapPending) {\
        if (XkbGetMapChanges((d),(xi)->desc, &(xi)->changes)==Success) {\
            LockDisplay((d));\
            (xi)->changes.changed= 0;\
            UnlockDisplay((d));\
        }\
    }\
}


Also not sure if returning from hibernate is something worth supporting
gracefully.

-------- Forwarded Message --------
Subject: [Bug 1172639] New: [abrt] nxagent: XKeycodeToKeysym(): nxagent killed
by SIGSEGV
Date: Wed, 10 Dec 2014 13:44:59 +0000
From: bugzilla@redhat.com
To: orion@cora.nwra.com

https://bugzilla.redhat.com/show_bug.cgi?id=1172639

            Bug ID: 1172639
           Summary: [abrt] nxagent: XKeycodeToKeysym(): nxagent killed by
                    SIGSEGV
           Product: Fedora
           Version: 21
         Component: nx-libs
          Assignee: orion@cora.nwra.com
          Reporter: ndbecker2@gmail.com
        QA Contact: extras-qa@fedoraproject.org
                CC: orion@cora.nwra.com



Description of problem:
using x2go, put laptop into hibernate.  Then woke up.  Tried to reconnect.

Version-Release number of selected component:
nxagent-3.5.0.28-1.fc21

Additional info:
reporter:       libreport-2.3.0
backtrace_rating: 4
cmdline:        /usr/lib64/nx/../x2go/bin/x2goagent -extension XFIXES -nolisten
tcp -nolisten tcp -dpi 115 -D -auth /home/nbecker/.Xauthority -geometry
1680x1015 -name X2GO-nbecker-91-1418065897_stDKDE_dp24 :91
crash_function: XKeycodeToKeysym
executable:     /usr/lib64/nx/bin/nxagent
kernel:         3.17.4-301.fc21.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (8 frames)
 #0 XKeycodeToKeysym at XKBBind.c:122
 #1 find_keystroke at Keystroke.c:395
 #2 nxagentCheckSpecialKeystroke at Keystroke.c:420
 #3 nxagentDispatchEvents at Events.c:1178
 #4 nxagentBlockHandler at Handlers.c:488
 #5 BlockHandler at dixutils.c:442
 #6 WaitForSomething at WaitFor.c:257
 #7 Dispatch at X/NXdispatch.c:619

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

Send a report that this bug log contains spam.