X2Go Bug report logs - #684
add exclude-hosts parameter to selectsession task

Full log

Message #35 received at 684@bugs.x2go.org (full text, mbox, reply):

Received: (at 684) by bugs.x2go.org; 6 Dec 2014 23:43:48 +0000
From savko@tophouse.ru  Sun Dec  7 00:43:47 2014
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from m.tophouse.ru (m.tophouse.ru [178.238.31.85])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id CFDDB5E0E0
	for <684@bugs.x2go.org>; Sun,  7 Dec 2014 00:43:46 +0100 (CET)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by m.tophouse.ru (Postfix) with ESMTP id 00B8A3513A7;
	Sun,  7 Dec 2014 02:45:31 +0300 (MSK)
Received: from m.tophouse.ru ([127.0.0.1])
	by localhost (m.tophouse.ru [127.0.0.1]) (amavisd-new, port 10032)
	with ESMTP id XzQdNDkaNRfs; Sun,  7 Dec 2014 02:45:29 +0300 (MSK)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by m.tophouse.ru (Postfix) with ESMTP id A563B382FC7;
	Sun,  7 Dec 2014 02:45:29 +0300 (MSK)
X-Virus-Scanned: amavisd-new at m.tophouse.ru
Received: from m.tophouse.ru ([127.0.0.1])
	by localhost (m.tophouse.ru [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id tMB6Gkyefqlv; Sun,  7 Dec 2014 02:45:29 +0300 (MSK)
Received: from m.tophouse.ru (m.tophouse.ru [178.238.31.85])
	by m.tophouse.ru (Postfix) with ESMTP id 1C323382FC4;
	Sun,  7 Dec 2014 02:45:29 +0300 (MSK)
Date: Sun, 7 Dec 2014 03:45:28 +0400 (MSK)
From: Sergey Savko <savko@tophouse.ru>
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 684@bugs.x2go.org
Message-ID: <92856184.99387.1417909528212.JavaMail.zimbra@tophouse.ru>
In-Reply-To: <20141206225605.Horde.h0QDOmvCPLZG5RzMvTt6XA3@mail.das-netzwerkteam.de>
References: <143861477.96320.1417796055431.JavaMail.zimbra@tophouse.ru> <1123477056.96337.1417796091693.JavaMail.zimbra@tophouse.ru> <20141206225605.Horde.h0QDOmvCPLZG5RzMvTt6XA3@mail.das-netzwerkteam.de>
Subject: Re: [X2Go-Dev] Bug#684: select_session offers offline servers to
 X2Go Client
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Mailer: Zimbra 8.0.8_GA_6184 (ZimbraWebClient - GC39 (Win)/8.0.8_GA_6184)
Thread-Topic: Bug#684: select_session offers offline servers to X2Go Client
Thread-Index: 4DVWkN1bMfbL8l2SHX9V5wQpehY9mA==

If the server will give the address to which it can not connect, there will be no load balancing works. 
Since the server is connected to receive the coefficient of loading.


----- Исходное сообщение -----
От: "Mike Gabriel" <mike.gabriel@das-netzwerkteam.de>
Кому: "Sergey Savko" <savko@tophouse.ru>, 684@bugs.x2go.org
Отправленные: Воскресенье, 7 Декабрь 2014 г 1:56:05
Тема: Re: [X2Go-Dev] Bug#684: select_session offers offline servers to X2Go Client

Control: clone -1 -2 -3
Control: reassign -2 x2goclient
Control: reassign -3 python-x2go
Control: retitle -1 add exclude-hosts parameter to selectsession task
Control: retitle -2 request another server from broker provided server is down
Control: retitle -3 request another server from broker provided server is down
Control: severity -1 wishlist
Control: severity -2 wishlist
Control: severity -3 wishlist
Control: block -2 by -1
Control: block -3 by -1
Control: tag -1 - patch

Hi Sergey,

On  Fr 05 Dez 2014 17:14:51 CET, Sergey Savko wrote:

> This patch work after patch from  
> http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=686

After thinking this through a little, I come to the conclusion that  
the broker cannot decide if a machine is down or not.

We have to think very generically. There may be a scenario where the  
broker machine may be on an network segment where it cannot ping/reach  
the X2Go Servers.

The X2Go Clients can reach the X2Go Broker. The broker provides an  
X2Go Server address on the "selectsession" broker task to the X2Go  
Client. Then the X2Go Client should test if that X2Go Server address  
works (via a simple ping6/ping command, machines should always be  
pingable!!!). If the ping fails, X2Go Client should go back to the  
broker and say: hey, that server failed for me, give me another one  
(but not the one you already gave me).

I fear we need to do four things for this bug to get fixed:

   1. extend broker/client communication protocol (second/third/...  
selectsession
      call with a list of hosts that did not work on previous attempts)
   2. extend X2Go Session Broker with an exclude-hosts (or so)  
parameter for the
      selectsession task
   3. Adapt X2Go Client: ping X2Go Server, go back to the broker if  
server is down
      and request another server
   4. Adapt Python X2Go: dito

Regards,
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Send a report that this bug log contains spam.